Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change base image from alpine to distroless #456

Merged
merged 2 commits into from
Jun 28, 2022
Merged

Change base image from alpine to distroless #456

merged 2 commits into from
Jun 28, 2022

Conversation

dimityrmirchev
Copy link
Member

How to categorize this PR?

/area open-source security
/kind enhancement
/platform gcp

What this PR does / why we need it:
This PR changes the base image for provider and admission services from alpine to distroless. The processes will now use a non root user for their execution. This will reduce the attack surface of the images.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

The extension now uses `distroless` instead of `alpine` as a base image.

@dimityrmirchev dimityrmirchev requested review from a team as code owners June 22, 2022 11:46
@gardener-robot gardener-robot added area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related area/security Security related kind/enhancement Enhancement, improvement, extension platform/gcp Google cloud platform/infrastructure needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Jun 22, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 22, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 22, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 23, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 23, 2022
ialidzhikov
ialidzhikov approved these changes Jun 24, 2022
View reviewed changes
Copy link
Member

@ialidzhikov ialidzhikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/squash

@gardener-robot gardener-robot added merge/squash Should be merged via 'Squash and merge' reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Jun 24, 2022
kon-angelo
kon-angelo approved these changes Jun 27, 2022
View reviewed changes
Copy link
Contributor

@kon-angelo kon-angelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kon-angelo kon-angelo merged commit 22f6d70 into gardener:master Jun 28, 2022
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jun 28, 2022
@kon-angelo kon-angelo mentioned this pull request Jul 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kon-angelo kon-angelo kon-angelo approved these changes

@ialidzhikov ialidzhikov ialidzhikov approved these changes

@dkistner dkistner dkistner approved these changes

Assignees
No one assigned
Labels
area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related area/security Security related kind/enhancement Enhancement, improvement, extension merge/squash Should be merged via 'Squash and merge' needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/gcp Google cloud platform/infrastructure reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@dimityrmirchev @dkistner @ialidzhikov @kon-angelo @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot