Skip to content

Update #include to deprecated fmt header#2545

Merged
gabime merged 1 commit intogabime:v1.xfrom
kromain:fix_bench_build
Nov 12, 2022
Merged

Update #include to deprecated fmt header#2545
gabime merged 1 commit intogabime:v1.xfrom
kromain:fix_bench_build

Conversation

@kromain
Copy link
Copy Markdown
Contributor

@kromain kromain commented Nov 11, 2022

The <fmt/locale.h> header has been marked as deprecated for a while and has finally been removed in fmt v0.9.0:
fmtlib/fmt@5c7d315

Replace with <fmt/format.h> instead, as recommended in the deprecated header.

The vcpkg build with the benchmark feature (./vcpkg install spdlog[core,benchmark]) is currently broken because of this:

[5/16] /usr/bin/c++ -DSPDLOG_COMPILED_LIB -DSPDLOG_FMT_EXTERNAL -I/workspaces/vcpkg/buildtrees/spdlog/src/v1.10.0-3cbe543323/include -isystem /workspaces/vcpkg/installed/x64-linux/include -fPIC -g -std=c++11 -MD -MT bench/CMakeFiles/bench.dir/bench.cpp.o -MF bench/CMakeFiles/bench.dir/bench.cpp.o.d -o bench/CMakeFiles/bench.dir/bench.cpp.o -c /workspaces/vcpkg/buildtrees/spdlog/src/v1.10.0-3cbe543323/bench/bench.cpp
FAILED: bench/CMakeFiles/bench.dir/bench.cpp.o 
/usr/bin/c++ -DSPDLOG_COMPILED_LIB -DSPDLOG_FMT_EXTERNAL -I/workspaces/vcpkg/buildtrees/spdlog/src/v1.10.0-3cbe543323/include -isystem /workspaces/vcpkg/installed/x64-linux/include -fPIC -g -std=c++11 -MD -MT bench/CMakeFiles/bench.dir/bench.cpp.o -MF bench/CMakeFiles/bench.dir/bench.cpp.o.d -o bench/CMakeFiles/bench.dir/bench.cpp.o -c /workspaces/vcpkg/buildtrees/spdlog/src/v1.10.0-3cbe543323/bench/bench.cpp
/workspaces/vcpkg/buildtrees/spdlog/src/v1.10.0-3cbe543323/bench/bench.cpp:18:14: fatal error: fmt/locale.h: No such file or directory
   18 | #    include <fmt/locale.h>
      |              ^~~~~~~~~~~~~~
compilation terminated.

The <fmt/locale.h> header has been marked as deprecated for a while
and has finally been removed in fmt v0.9.0:
fmtlib/fmt@5c7d315

Replace with <fmt/format.h> instead, as recommended.
@gabime gabime merged commit c5a09eb into gabime:v1.x Nov 12, 2022
@gabime
Copy link
Copy Markdown
Owner

gabime commented Nov 12, 2022

Thanks @kromain

@kromain kromain deleted the fix_bench_build branch November 14, 2022 15:17
BillyONeal added a commit to microsoft/vcpkg that referenced this pull request Nov 16, 2022
* [spdlog] Update to 1.11.0

* [spdlog] backporting gabime/spdlog#2545

* [spdlog] Add 1.11.0 to versions file

* Remove patch header, add link to upstream merged PR, add quotes.

Co-authored-by: Billy Robert O'Neal III <bion@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants