Conversation
|
There currently are errors in the CI builds at the Test phase |
|
Looks like |
|
The CI is still failing: https://ci.cppget.org/@57c6f5f0-49fe-4d3d-a739-727c1d2bae15 |
|
Looks like it should work... I'll have to check locally. |
|
There seems to be issues with the symlinks on windows, Ill fix these first. |
|
I can reproduce the issue now, will attempt a fix. |
|
Ok the issue was that the testscript was not recognized as such. |
|
I just launched a ci request: https://ci.stage.build2.org/@04f3e9c2-4263-4e3f-8fa8-01aa5585f70b |
|
Welp looks like something else is wrong... |
|
we're getting configuration errors now: There is some problems when fetching the spdlog with git submodules |
|
Can you reproduce the issue locally? I can't.
|
|
I can't reproduce it either |
|
I tried to simplify the fix I did on the symlinks but that's not it: https://ci.stage.build2.org/@31d93a0e-bd43-450c-9bef-76de48d69fed |
|
I updated the package manifest file because i noticed that google-bench was no longer in "testing" but "stable". CI: https://ci.cppget.org/@6cb41d52-e04c-403b-aa18-129ea371696b |
|
@Klaim The CI results of my last changes seem pretty good. What do you think of it ? |
|
Looks like the tests are randomly failing or not? Macos/Gcc seems to segfault, that might suggests some memory usage error so maybe making sure the upstream implementation is supposed to be tested correctly might be necessary. |
|
IF the issues are from the original code, I guess we can publish the package or wait for a fixed version. If we publish it we can always revise or wait to publish the fixed version too. |
EmilRosenquist
left a comment
There was a problem hiding this comment.
I accidentally made the "update" without seeing this pull request (#18). But as @Klaim pointed out this already existed.
I tested this and it works. I think unless we want to patch this release with the upstream pull-request that fixed the include (gabime/spdlog#2545). This is good go!
|
If we're all good to go with it. I'll merge the changes, add the tag and publish it to cppget. Doing another round check to make sure everyone is happy with it. |
|
LGTM
If we realize this is necessary we can always publish a revision for the same version. |
ci