Skip to content

[spdlog] Update to 1.11.0#27771

Merged
BillyONeal merged 4 commits intomicrosoft:masterfrom
KiruyaMomochi:master
Nov 16, 2022
Merged

[spdlog] Update to 1.11.0#27771
BillyONeal merged 4 commits intomicrosoft:masterfrom
KiruyaMomochi:master

Conversation

@KiruyaMomochi
Copy link
Copy Markdown
Contributor

  • [spdlog] Update to 1.11.0
  • [spdlog] Add 1.11.0 to versions file

Describe the pull request

  • What does your PR fix?

    None

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    all, No

  • Does your PR follow the maintainer guide?

    Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    Yes

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

github-actions[bot]
github-actions Bot previously approved these changes Nov 11, 2022
@FrankXie05 FrankXie05 added the category:port-update The issue is with a library, which is requesting update new revision label Nov 11, 2022
@FrankXie05
Copy link
Copy Markdown
Contributor

@KiruyaMomochi We can wait for PR #27740.

@FrankXie05 FrankXie05 added the depends:different-pr This PR or Issue depends on a PR which has been filed label Nov 11, 2022
@kromain
Copy link
Copy Markdown
Contributor

kromain commented Nov 14, 2022

for consideration: backporting gabime/spdlog@c5a09eb to fix the build with the benchmark option

@JonLiu1993 JonLiu1993 linked an issue Nov 15, 2022 that may be closed by this pull request
@FrankXie05
Copy link
Copy Markdown
Contributor

@KiruyaMomochi Now we can continue this PR, please resolve the conflict. And consider adding options SPDLOG_BUILD_BENCH to solve the construction problems. gabime/spdlog#2545

@FrankXie05 FrankXie05 removed the depends:different-pr This PR or Issue depends on a PR which has been filed label Nov 15, 2022
github-actions[bot]
github-actions Bot previously approved these changes Nov 15, 2022
FrankXie05
FrankXie05 previously approved these changes Nov 16, 2022
@FrankXie05 FrankXie05 added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Nov 16, 2022
Copy link
Copy Markdown
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@BillyONeal BillyONeal merged commit d51b969 into microsoft:master Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-update The issue is with a library, which is requesting update new revision info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[spdlog] update to 1.11.0

4 participants