chore: update fullsend per-repo installation - #6488
Conversation
PR Summary by QodoPin fullsend reusable workflows and add per-repo scaffold workflow
AI Description
Diagram
High-Level Assessment
Files changed (3)
|
|
Closing — will re-install after #6490 lands with project_number passthrough. |
Code Review by Qodo
1. Prioritize concurrency collisions
|
| concurrency: | ||
| group: fullsend-prioritize-${{ inputs.source_repo }}-${{ fromJSON(inputs.event_payload).issue.number }} | ||
| cancel-in-progress: true |
There was a problem hiding this comment.
1. Prioritize concurrency collisions 🐞 Bug ☼ Reliability
The new prioritize thin-caller sets concurrency.group using only fromJSON(inputs.event_payload).issue.number, but the called reusable-prioritize.yml explicitly supports either an issue or a pull_request payload; when the payload is PR-shaped, the group suffix becomes empty and cancel-in-progress: true can cancel unrelated runs for the same repo.
Agent Prompt
## Issue description
`concurrency.group` in `.github/workflows/prioritize.yml` uses only `.issue.number` from the JSON payload. When the payload is for a pull request (no `issue` object), the group string can become `fullsend-prioritize-<repo>-`, causing cross-run cancellations due to `cancel-in-progress: true`.
## Issue Context
The called workflow (`.github/workflows/reusable-prioritize.yml`) already anticipates both issue and PR payloads by using `issue.number || pull_request.number` in its own concurrency group.
## Fix Focus Areas
- .github/workflows/prioritize.yml[26-28]
## Suggested change
Update the group to mirror the reusable workflow’s fallback logic, e.g.:
```yaml
concurrency:
group: fullsend-prioritize-${{ inputs.source_repo }}-${{ fromJSON(inputs.event_payload).issue.number || fromJSON(inputs.event_payload).pull_request.number }}
cancel-in-progress: true
```
(Optionally add a final fallback like `${{ github.run_id }}` if neither exists.)
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
| repos: | ||
| - fullsend-ai/fullsend | ||
| - fullsend-ai/fullsend |
There was a problem hiding this comment.
2. Duplicate allow_targets repo 🐞 Bug ⚙ Maintainability
.fullsend/config.yaml lists fullsend-ai/fullsend twice under create_issues.allow_targets.repos, which is redundant and can cause confusing or duplicated downstream behavior in any logic that iterates these targets.
Agent Prompt
## Issue description
The per-repo fullsend config includes the same repo twice in `create_issues.allow_targets.repos`.
## Issue Context
`create_issues.allow_targets.repos` is an allowlist used to control where agents may create issues. Duplicates provide no additional capability and increase the risk of confusion or duplicated actions in any consumer that iterates this list.
## Fix Focus Areas
- .fullsend/config.yaml[17-21]
## Suggested change
Remove one of the duplicated entries so the list contains each repo only once.
Example:
```yaml
create_issues:
allow_targets:
repos:
- fullsend-ai/fullsend
```
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
The default branch (main) has branch protection rules that prevent direct pushes.
Merge this PR to deliver the scaffold files.