fix(#1012): add extract-transcript-error.sh to executableFiles map - #1016
Conversation
|
fullsend review is working on this — view logs |
Site previewPreview: https://bf000232-site.fullsend-ai.workers.dev Commit: |
ReviewFindingsNo findings. Previous runReview: #1016Head SHA: 5af274e SummaryThis is a correct, minimal one-line fix that adds the missing FindingsNone. FooterOutcome: approve |
![fullsend-ai-review[bot]](https://avatars.githubusercontent.com/in/3478501?s=60&v=4){kind=small}
|
/fix Error: internal/scaffold/scaffold.go:40:2: duplicate key "scripts/extract-transcript-error.sh" in map literal |
|
/fs-fix Error: internal/scaffold/scaffold.go:40:2: duplicate key "scripts/extract-transcript-error.sh" in map literal |
scripts/extract-transcript-error.sh was added as an executable file but not registered in the executableFiles map in internal/scaffold/scaffold.go. This caused TestFileModeMatchesFilesystem to fail because the test walks the scaffold directory for executable files and checks each one is present in the map. Note: Go tests could not run in-sandbox (Go 1.24.13 available, project requires >= 1.26.0). Pre-commit could not run (network error). The fix is a single map entry addition verified by manual inspection of the test logic and filesystem state. Closes #1012
5af274e to
bbce3ee
Compare
fullsend-ai-review
Bot
added
the
ready-for-merge
|
/fs-fix Error: internal/scaffold/scaffold.go:40:2: duplicate key "scripts/extract-transcript-error.sh" in map literal |
The entry for scripts/extract-transcript-error.sh appeared twice in the executableFiles map literal — once at line 23 (added by the PR) and again at line 41 (pre-existing). Go rejects duplicate keys in map literals, causing a compile error. Remove the second (pre-existing) entry since the first is in the correct alphabetical position. Addresses review feedback on #1016 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: fullsend-fix <fullsend-code@users.noreply.github.com>
🔧 Fix agent — iteration 1 (human-triggered)Removed duplicate map key for scripts/extract-transcript-error.sh in executableFiles. The PR's addition at line 23 was kept (correct alphabetical position); the pre-existing entry at line 41 was removed. Go tests could not run in sandbox (Go 1.26.0 toolchain unavailable), but the fix is a trivial single-line deletion of a provably duplicate key. Fixed (1):
Tests: failed Decision points
Updated by fullsend fix agent |
The sandbox image pinned Go 1.24.13 while go.mod requires 1.26.0. This version mismatch prevented the code agent from compiling or testing Go code, causing it to submit untested PRs (e.g. PR fullsend-ai#1016 shipped a duplicate map key that go build would have caught). Update GO_VERSION from 1.24.13 to 1.26.0 and replace the SHA256 checksums for linux-amd64 and linux-arm64 archives. Checksums sourced from docker-library/golang at the go1.26.0 release commit. The sandbox image will rebuild automatically via the sandbox-images.yml workflow on push to main. Note: pre-commit could not run in-sandbox (exit 3) because the gitleaks hook tried to auto-download a newer Go toolchain, which is blocked by sandbox network policy. This is the same version mismatch this commit fixes. Closes fullsend-ai#1344
2 participants
scripts/extract-transcript-error.sh was added as an executable file but not registered in the executableFiles map in internal/scaffold/scaffold.go. This caused TestFileModeMatchesFilesystem to fail because the test walks the scaffold directory for executable files and checks each one is present in the map.
Note: Go tests could not run in-sandbox (Go 1.24.13 available, project requires >= 1.26.0). Pre-commit could not run (network error). The fix is a single map entry addition verified by manual inspection of the test logic and filesystem state.
Closes #1012
Post-script verification
agent/1012-add-executable-entry)4935d393ab233d22e4735c4e728cf14bd4da4126..HEAD)