Skip to content

Add concurrency group to dispatch-review job (supports #365) #848

Description

@fullsend-ai-retro

What happened

PR #845 was a Dependabot submodule bump (1-line diff). Two review runs were dispatched to fullsend-ai/.fullsend within 4 seconds of each other: run #975 (18:47:46, completed 18:53:42, 93KB artifact) and run #976 (18:47:50, completed 18:51:18, 16KB artifact). Run #976 produced the approval at 18:51:11. Run #975 ran for ~6 minutes redundantly. The likely cause is the pull_request_target event firing both opened and ready_for_review actions for a non-draft Dependabot PR, each dispatching a separate review.

What could go better

The dispatch-review job should have a concurrency group like dispatch-triage already does, so that only one review dispatch runs per PR at a time. This is a known gap — issue #365 was filed on 2026-04-23 with the exact fix, RICE-scored at 2.7, and remains open. This retro provides concrete evidence: one redundant run consuming ~6 minutes of compute and producing a 93KB artifact that was never used. Confidence is high — the root cause is clearly the missing concurrency group, matching the pattern already established by other dispatch jobs in the same workflow.

Proposed change

Add a concurrency block to the dispatch-review job in .github/workflows/fullsend.yaml, mirroring the pattern from dispatch-triage:

dispatch-review:
  runs-on: ubuntu-latest
  concurrency:
    group: review-${{ github.event.pull_request.number }}
    cancel-in-progress: true

Also audit dispatch-code and dispatch-retro for the same gap, as suggested in #365. This is not a new proposal — it is a priority bump for #365 based on fresh evidence.

Validation criteria

After applying the fix, the next 10 Dependabot or bot-authored PRs on fullsend-ai/fullsend should each produce exactly 1 review run in fullsend-ai/.fullsend (not 2+). Check by comparing review.yml run counts to PR counts over a 1-week window.


Generated by retro agent from #845

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    duplicateThis issue or pull request already exists

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions