Sprint 13.1: Implementações e otimizações extras#215
Merged
Conversation
…t roadmap documentation
Contributor
|
Warning Rate limit exceeded
To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughAdiciona suporte SSE (hub, tópicos, handlers, endpoints, hooks), converte vários parsers para Span-based para reduzir alocações, endurece validações de headers/paths, altera convenção de tópicos Rebus, atualiza docs/roadmap/technical-debt, ajusta testes e adiciona dependências/front-end para SSE. Changes
Sequence Diagram(s)sequenceDiagram
participant Domain as "Domain Events\n(e.g. BookingCreated)"
participant Handler as "EventHandler\n(BookingRealtimeEventsHandler)"
participant SseHub as "SseHub<T>"
participant Endpoint as "SSE Endpoint\n(GET /.../events)"
participant Client as "Browser Hook\n(useBookingEvents / useProviderVerification)"
rect rgba(200,220,255,0.5)
Domain->>Handler: Publica evento de domínio
Handler->>SseHub: PublishAsync(topic, DTO)
end
rect rgba(200,255,200,0.5)
Endpoint->>SseHub: SubscribeAsync(topic)
SseHub-->>Endpoint: Emite eventos via IAsyncEnumerable
Endpoint->>Client: Envia mensagens SSE (data: {...})
Client->>Client: Atualiza cache / mostra toast
end
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsGit: Failed to clone repository. Please run the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 31 minutes and 57 seconds.Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@docs/roadmap.md`:
- Around line 38-40: A seção que lista "**Sprint 13**" como concluída entra em
conflito com o bloco de status que ainda mostra "Em Execução"; update o bloco de
status (onde aparece "Em Execução") para refletir que Sprint 13 está "Concluída"
e inclua a data de término "28 Abr 2026" ou similar para consistência; localize
ocorrências de "Sprint 13" e do texto "Em Execução" no documento (por exemplo no
resumo de sprints e no bloco de status) e sincronize ambos para evitar
ambiguidade.
In `@docs/technical-debt.md`:
- Around line 25-28: The title "i18n Frontend Apps (Admin/Provider)" and the
description text referencing Admin/Provider/Customer are inconsistent; update
either the title or description so the scope matches: either change the title to
"i18n Frontend Apps (Admin/Provider/Customer)" or restrict the description to
only Admin/Provider and remove Customer mentions; ensure related symbols like
useTranslation, translation of labels via i18n, and mocks of i18next with
support for defaultValue are still accurately described after the change.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 194c370f-090a-4ad1-8b8c-2b14825abc6f
📒 Files selected for processing (3)
docs/roadmap-history.mddocs/roadmap.mddocs/technical-debt.md
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
docs/roadmap.md (1)
38-40: Conteúdo preciso e bem documentado.Os detalhes das Sprints 13, 12 e 11 estão corretos e alinhados com o histórico. A ferramenta de análise estática sugere variar a estrutura das frases (três bullets consecutivos começam com "**Sprint"), mas isso é puramente estilístico.
✍️ Sugestão opcional de estilo
Se desejar adicionar variação:
* **Sprint 13**: RabbitMQ Excellence (infraestrutura real com RabbitMqInfrastructureManager, deadlocks corrigidos, dispose seguro), i18n mocks para testes (Provider/Admin/Customer), fail-fast em DI de Messaging. -* **Sprint 12**: Bookings Module completo, Command Handlers (Reject/Complete), queries de listagem, automação com Domain Events, integração frontend de agenda. +* **Módulo de Bookings (Sprint 12)**: Implementação completa com Command Handlers (Reject/Complete), queries de listagem, automação com Domain Events, integração frontend de agenda. * **Sprint 11**: Monetização completa (Checkout, Webhooks, Billing Portal, Renovação Automática), Localização i18n Frontend, Skeleton Loaders e cobertura de testes abrangente.Mas não é necessário — a clareza já está garantida.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@docs/roadmap.md` around lines 38 - 40, The three consecutive bullets all start with the exact phrase "**Sprint X**", which is stylistically repetitive; update the three list items referencing "**Sprint 13**", "**Sprint 12**" and "**Sprint 11**" to vary their openings (for example: "In Sprint 13 we...", "Completed in Sprint 12:", "Sprint 11 delivered...") or restructure one or two items to lead with verbs or results so the bullets read less repetitive while preserving the existing content and details.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@docs/roadmap.md`:
- Around line 38-40: The three consecutive bullets all start with the exact
phrase "**Sprint X**", which is stylistically repetitive; update the three list
items referencing "**Sprint 13**", "**Sprint 12**" and "**Sprint 11**" to vary
their openings (for example: "In Sprint 13 we...", "Completed in Sprint 12:",
"Sprint 11 delivered...") or restructure one or two items to lead with verbs or
results so the bullets read less repetitive while preserving the existing
content and details.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: cf1055e7-bd0a-44c3-84a6-35f3443ef303
📒 Files selected for processing (2)
docs/roadmap.mddocs/technical-debt.md
✅ Files skipped from review due to trivial changes (1)
- docs/technical-debt.md
frigini
changed the title
Owner
Author
|
@coderabbitai está é uma sprint para pequenas melhorias e otimizações, gostaria de saber, para iniciar, se é uma boa ideia otimizar partes do código com o uso de Span ou ReadOnlySpan ou é preciosismo? Se sim, se for recomendável, analise onde posso refatorar (em todo código) e elabore um plano. |
Contributor
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chainVou analisar o código C# do repositório para identificar os pontos com maior potencial de ganho com 🏁 Script executed: Length of output: 262901
Diagnóstico: Vale a pena usar
|
| Contexto | Motivo |
|---|---|
Código de teste (*Tests.cs) |
Zero impacto em produção |
EF Core LINQ .Contains() / .Where() |
Traduzido para SQL, Span<T> não se aplica |
Código de startup/migração (MigrationExtensions.cs, MigrationHostedService.cs, BaseDesignTimeDbContextFactory.cs) |
Executado uma vez, sem impacto mensurável |
Reflexão sobre assemblies (ModuleDiscoveryHelper, etc.) |
Idem |
🟡 Vale a pena (ROI real) — Plano por prioridade:
P0 — Middlewares (hot path: toda requisição HTTP)
1. RequestLoggingMiddleware.cs — Extração do IP do X-Forwarded-For
// ❌ Atual: aloca um array e uma nova string
return xForwardedFor.Split(',')[0].Trim();
// ✅ Proposto: zero allocation
var span = xForwardedFor.AsSpan();
var commaIndex = span.IndexOf(',');
return (commaIndex >= 0 ? span[..commaIndex] : span).Trim().ToString();2. PermissionOptimizationMiddleware.cs — Detecção de segmento /admin/ no path
// ❌ Atual: aloca string[]
var segments = path.Split('/', StringSplitOptions.RemoveEmptyEntries);
return segments.Any(segment => string.Equals(segment, "admin", StringComparison.OrdinalIgnoreCase));
// ✅ Proposto: iteração zero-alloc
var span = path.AsSpan();
while (span.Length > 0)
{
var slash = span.IndexOf('/');
var segment = slash >= 0 ? span[..slash] : span;
if (segment.Equals("admin", StringComparison.OrdinalIgnoreCase)) return true;
if (slash < 0) break;
span = span[(slash + 1)..];
}
return false;3. BusinessMetricsMiddleware.cs — Verificação de path contendo /help-requests/
// ❌ Atual: string.Contains em cada requisição
path.Contains("/help-requests/") && path.EndsWith("/complete")
// ✅ Proposto: ReadOnlySpan<char>
var span = path.AsSpan();
span.Contains("/help-requests/".AsSpan(), StringComparison.Ordinal)
&& span.EndsWith("/complete".AsSpan(), StringComparison.Ordinal)P1 — Application Layer (fluxos de registro e cache)
4. RegisterCustomerCommandHandler.cs — Parsing de e-mail para gerar username
// ❌ Atual: 4x Split + 2x Substring → várias alocações intermediárias
var fullLocalPart = emailAsValueObject.Value.Split('@')[0];
var noTagLocalPart = fullLocalPart.Split('+')[0];
// ...
sanitizedLocalPart = sanitizedLocalPart.Substring(0, maxLocalPartLength);
// ✅ Proposto: ReadOnlySpan<char> do início ao fim
ReadOnlySpan<char> email = emailAsValueObject.Value.AsSpan();
var atIdx = email.IndexOf('@');
var local = atIdx >= 0 ? email[..atIdx] : email;
var plusIdx = local.IndexOf('+');
local = plusIdx >= 0 ? local[..plusIdx] : local;
if (local.Length > maxLocalPartLength) local = local[..maxLocalPartLength];
// Regex ainda precisa de string, mas ao menos reduz alocações intermediárias
var sanitized = SanitizationRegex().Replace(local.ToString(), "");5. CacheMetrics.cs — Extração de prefixo de chave de cache (chamado a cada operação de cache)
// ❌ Atual:
var parts = key.Split(':');
if (parts.Length >= 2) { ... parts[0] ... }
// ✅ Proposto:
var span = key.AsSpan();
var colon = span.IndexOf(':');
var prefix = colon >= 0 ? span[..colon].ToString() : key;P2 — Utilitários
6. PiiMaskingHelper.cs — Mascaramento de e-mail (usado em logs)
// ❌ Atual:
var parts = email.Split('@');
if (parts.Length != 2) return "***@***";
// ✅ Proposto:
var span = email.AsSpan();
var atIdx = span.IndexOf('@');
if (atIdx < 0) return "***@***";
var localLen = Math.Min(3, atIdx);
return $"{new string('*', localLen)}@{span[(atIdx + 1)..].ToString()}";7. KeycloakService.cs — Extração do ID do usuário a partir do header Location
// ❌ Atual:
var segments = locationHeader.Split('/');
var keycloakUserId = segments[segments.Length - 1];
// ✅ Proposto:
var span = locationHeader.AsSpan();
var lastSlash = span.LastIndexOf('/');
var keycloakUserId = (lastSlash >= 0 ? span[(lastSlash + 1)..] : span).ToString();📊 Resumo da decisão
| Prioridade | Arquivos | Ganho esperado |
|---|---|---|
| P0 | RequestLoggingMiddleware, PermissionOptimizationMiddleware, BusinessMetricsMiddleware |
Alto — zero-alloc em toda requisição |
| P1 | CacheMetrics, RegisterCustomerCommandHandler |
Médio — reduz pressão no GC em fluxos frequentes |
| P2 | PiiMaskingHelper, KeycloakService |
Baixo-Médio — legibilidade + pequena melhoria |
| Skip | Testes, EF LINQ, startup/migration | Não se aplica |
Conclusão: Para os middlewares (P0) é definitivamente justificável e alinhado com uma sprint de otimização. Para P1 e P2 é opcional, mas o ganho é real e o esforço baixo. Quer que eu elabore o `` para alguma dessas prioridades?
🧠 Learnings used
Learnt from: frigini
Repo: frigini/MeAjudaAi PR: 0
File: :0-0
Timestamp: 2026-01-16T21:50:23.593Z
Learning: For frigini/MeAjudaAi Web reviews, prefer commit-by-commit (newest-first) with concise verdicts and concrete follow-ups; prioritize reuse of Shared.Contracts for enums/constants to keep Web aligned with backend/shared code.
Learnt from: frigini
Repo: frigini/MeAjudaAi PR: 77
File: src/Modules/Documents/Application/Handlers/UploadDocumentCommandHandler.cs:133-143
Timestamp: 2025-12-17T18:32:51.210Z
Learning: Além de manter logs em inglês, os comentários e a documentação XML (/// <summary>, <param>, etc.) devem ser escritos em português em todo o código MeAjudaAi.
Failed to handle agent chat message. Please try again.
Owner
Author
@coderabbitai elabore o plano para P0 e P1 apenas, o mais completo possível (ou seja, cobrindo todo o projeto). |
Contributor
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: Length of output: 187 🏁 Script executed: Length of output: 108891
Plano: Refatoração
|
| # | Arquivo | Alocações eliminadas | Frequência |
|---|---|---|---|
| P0.1 | RequestLoggingMiddleware |
1× string (ToLower) + 1× string[] + 1× string (Split+Trim) |
Cada request HTTP |
| P0.2 | PermissionOptimizationMiddleware |
2× string (ToLower) + 1× string[] (Split) + 1× enumerador LINQ |
Cada request autenticado |
| P0.3 | BusinessMetricsMiddleware |
1× string (ToLower) |
Cada request HTTP |
| P1.1 | RegisterCustomerCommandHandler |
2× string[] (Split) + 3× string (Substring) |
Cada cadastro de cliente |
| P1.2 | CacheMetrics |
1× string[] (Split) |
Cada operação de cache |
Nota sobre
ReadOnlySpan<char>.Equals: Utiliza a extensãoMemoryExtensions.Equals(ReadOnlySpan<char>, ReadOnlySpan<char>, StringComparison)disponível desde .NET 5. Nota sobreReadOnlySpan<char>.Contains: requerusing System(já presente nos arquivos) pois éMemoryExtensions.Contains, disponível desde .NET 5.
🧠 Learnings used
Learnt from: frigini
Repo: frigini/MeAjudaAi PR: 0
File: :0-0
Timestamp: 2026-04-20T22:04:25.820Z
Learning: MeAjudaAi (PRs futuros): para cobertura global, NÃO excluir *Configuration e *Extensions (há smoke tests exercitando-os); também não excluir *.Monitoring.*, MeAjudaAi.Shared.Jobs.* e MeAjudaAi.Shared.Mediator.*. Manter excluídos apenas Request/Response/Dto/DTO/IntegrationEvent e *DbContextFactory; Endpoints podem ficar excluídos globalmente, a menos que sejam white-listados por módulo com E2E (ex.: +MeAjudaAi.Modules.Payments.API.*Endpoint; -*Endpoint).
Learnt from: frigini
Repo: frigini/MeAjudaAi PR: 0
File: :0-0
Timestamp: 2026-01-16T21:50:23.593Z
Learning: For frigini/MeAjudaAi Web reviews, prefer commit-by-commit (newest-first) with concise verdicts and concrete follow-ups; prioritize reuse of Shared.Contracts for enums/constants to keep Web aligned with backend/shared code.
Learnt from: frigini
Repo: frigini/MeAjudaAi PR: 0
File: :0-0
Timestamp: 2026-04-19T15:37:29.889Z
Learning: MeAjudaAi: objetivo de cobertura global é ≥90% (linhas), mantendo thresholds 90/80 no CI; quando a meta estiver ameaçada, preferir excluir “glue/DTO” (Endpoints/Extensions/Options/IntegrationEvent/DbContextFactory) e adicionar testes de alto impacto, em vez de reduzir o threshold.
Learnt from: frigini
Repo: frigini/MeAjudaAi PR: 0
File: :0-0
Timestamp: 2026-04-24T20:02:36.451Z
Learning: MeAjudaAi Shared coverage: Classes de infraestrutura de messaging que dependem de broker RabbitMQ real (RabbitMqDeadLetterService, DeadLetterExtensions, FailedMessageInfo, FailureAttempt, EnvironmentMetadata) são candidatas a [ExcludeFromCodeCoverage] pois não são testáveis unitariamente. Utilitários puros (PhoneNumberValidator, PiiMaskingHelper, SlugHelper, UuidGenerator) devem ter testes unitários adicionados em vez de serem excluídos.
Learnt from: frigini
Repo: frigini/MeAjudaAi PR: 77
File: src/Modules/Providers/Tests/Unit/Application/Queries/GetProvidersByIdsQueryTests.cs:65-77
Timestamp: 2025-12-18T00:35:33.829Z
Learning: MeAjudaAi repo: Exceção à política de idioma para comentários — em testes, os cabeçalhos AAA (Arrange, Act, Assert) devem permanecer em inglês e não devem ser traduzidos. Comentários/XML continuam em português; logs em inglês; mensagens ao usuário (validações/APIs) em português.
Learnt from: frigini
Repo: frigini/MeAjudaAi PR: 0
File: :0-0
Timestamp: 2026-04-24T20:02:36.451Z
Learning: MeAjudaAi ci-backend.yml (linha 272): Para tornar os endpoints de um módulo visíveis na cobertura do ReportGenerator, adicionar o assembly antes de `-*Endpoint` no classfilters, ex: `+MeAjudaAi.Modules.Bookings.API.*Endpoint` (após `+MeAjudaAi.Modules.Payments.API.*Endpoint`). Isso é necessário apenas para módulos com cobertura E2E. Módulos sem E2E mantêm os endpoints excluídos.
Learnt from: frigini
Repo: frigini/MeAjudaAi PR: 0
File: :0-0
Timestamp: 2026-04-24T21:04:28.437Z
Learning: MeAjudaAi coverlet.runsettings: `ExcludeByAttribute` deve incluir `ExcludeFromCodeCoverage` (além de Obsolete,GeneratedCode,CompilerGenerated). Sem isso, todas as classes decoradas com [ExcludeFromCodeCoverage] continuam sendo instrumentadas pelo coverlet e contam como linhas não cobertas no relatório, reduzindo a cobertura global. Correção: `<ExcludeByAttribute>Obsolete,GeneratedCode,CompilerGenerated,ExcludeFromCodeCoverage</ExcludeByAttribute>`.
Learnt from: frigini
Repo: frigini/MeAjudaAi PR: 77
File: src/Modules/Documents/Application/Handlers/UploadDocumentCommandHandler.cs:133-143
Timestamp: 2025-12-17T18:32:51.210Z
Learning: Além de manter logs em inglês, os comentários e a documentação XML (/// <summary>, <param>, etc.) devem ser escritos em português em todo o código MeAjudaAi.
Learnt from: frigini
Repo: frigini/MeAjudaAi PR: 77
File: src/Modules/Documents/Application/Handlers/UploadDocumentCommandHandler.cs:133-143
Timestamp: 2025-12-17T18:26:37.409Z
Learning: MeAjudaAi logging policy: logs must be in English, comments may remain in Portuguese. Portuguese logs were additionally found in Users (API/Extensions.cs:83), Providers (API/Extensions.cs:74), ServiceCatalogs (API/Extensions.cs:78,86,93), and Locations (multiple clients/services lines listed). SearchProviders module currently has no Portuguese logs.
Learnt from: frigini
Repo: frigini/MeAjudaAi PR: 77
File: src/Modules/Documents/Application/Handlers/UploadDocumentCommandHandler.cs:133-143
Timestamp: 2025-12-17T18:09:54.585Z
Learning: In the MeAjudaAi codebase, when reviewing log messages in application handlers, verify they are in English. The file src/Modules/Documents/Application/Handlers/UploadDocumentCommandHandler.cs had Portuguese logs that violated the English-only logging policy.
The requested changes have been implemented and a pull request has been created: View PR
…infrastructure services
frigini
changed the title
Contributor
There was a problem hiding this comment.
Actionable comments posted: 7
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/Shared/Authorization/Middleware/PermissionOptimizationMiddleware.cs (1)
123-132:⚠️ Potential issue | 🟡 MinorO preload ficou sensível a maiúsculas/minúsculas.
Ao parar de normalizar
path,GetRequiredPermissionsForPathcontinua usandoStartsWith/Containscase-sensitive. Com rotas válidas como/API/V1/Users/Profile, o middleware deixa de pré-carregar permissões e perde a otimização downstream. Troque os matches internos paraOrdinalIgnoreCase.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/Shared/Authorization/Middleware/PermissionOptimizationMiddleware.cs` around lines 123 - 132, O middleware perdeu normalização do path, então chamadas dentro de GetRequiredPermissionsForPath ainda usam StartsWith/Contains case-sensitive e falham com rotas maiúsculas; abra a implementação de GetRequiredPermissionsForPath e alterar todas as comparações de string (ex.: path.StartsWith(...), path.Contains(...)) para versões que usam StringComparison.OrdinalIgnoreCase (ou String.Equals com OrdinalIgnoreCase) para garantir matching case-insensitive ao avaliar permissões com base no path e no método.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@src/Bootstrapper/MeAjudaAi.ApiService/Middlewares/GeographicRestrictionMiddleware.cs`:
- Around line 105-111: The parser in GeographicRestrictionMiddleware currently
splits locationHeader by the first '|' (headerSpan, separatorIndex) and assigns
locationCity and locationState from slices, which allows extra '|' characters
(e.g., "São Paulo|SP|Capital") producing an invalid state; update the logic in
the blocks around headerSpan/separatorIndex and the similar code at the later
region (lines ~208-230) to detect any additional '|' after separatorIndex (e.g.,
using IndexOf on the remainder or checking for another separator) and treat the
header as malformed if another '|' exists, returning the proper
rejection/validation path instead of accepting the full remainder as state; keep
using the same symbols locationHeader, headerSpan, separatorIndex, locationCity,
locationState and ensure consistent error handling when rejecting malformed
input.
In
`@src/Bootstrapper/MeAjudaAi.ApiService/Middlewares/RequestLoggingMiddleware.cs`:
- Around line 125-130: The current exclusion logic in RequestLoggingMiddleware
uses pathSpan.Contains for "/health", "/metrics", and "/swagger", which also
matches internal routes like "/api/v1/reports/health-summary"; change these
checks to match by prefix or segment instead (e.g., use
pathSpan.StartsWith("/health", StringComparison.OrdinalIgnoreCase) or split the
PathString into segments and compare the first segment) so only exact top-level
endpoints are skipped; update the method that evaluates pathSpan (the exclusion
check in RequestLoggingMiddleware) to use StartsWith/segment comparison
consistently and keep the StringComparison.OrdinalIgnoreCase semantics.
In `@src/Shared/Extensions/DocumentExtensions.cs`:
- Around line 18-27: Substitua a filtragem que usa char.IsDigit(c) pelo teste
ASCII explícito c is >= '0' and <= '9' nas rotinas que extraem dígitos (o trecho
com Span<char> digitsOnly e as outras duas validações correspondentes) para
garantir que apenas dígitos ASCII 0–9 sejam admitidos; atualize todas as
ocorrências relacionadas em DocumentExtensions (incluindo a rotina
IsValidDocument e qualquer lugar que monte digitsOnly ou faça cálculos com c -
'0') para usar esse teste e assim manter consistência com os cálculos dos
dígitos verificadores.
In `@src/Shared/Messaging/Options/MessageBusOptions.cs`:
- Line 25: The current fallback for a null/empty type.Namespace always returning
the literal "events.events" can cause topic collisions; update the fallback in
the logic that computes the Namespace (where type.Namespace is checked in
MessageBusOptions.cs) to include type.Name (e.g., use type.Name or combine both
like $"events.{type.Name}") instead of the fixed "events.events" so each type
gets a minimally unique topic namespace when Namespace is missing.
- Around line 22-35: TopicNamingConvention currently isn't used by the Rebus
wiring because Rebus resolves ITopicNameConvention (and uses
AttributeTopicNameConvention) instead of the Func in MessageBusOptions; create
an adapter class that implements ITopicNameConvention and delegates to
MessageBusOptions.TopicNamingConvention (e.g., class OptionsTopicNameConvention
: ITopicNameConvention { constructor(MessageBusOptions opts) ... }), then
register that implementation in DI so it is used by Rebus (or ensure
MessagingExtensions resolves and passes MessageBusOptions.TopicNamingConvention
into the existing AttributeTopicNameConvention registration) so the optimized
naming function is actually applied at runtime.
In `@src/Shared/Monitoring/BusinessMetricsMiddleware.cs`:
- Around line 56-57: The route matching allows non-versioned paths because
StartsWith("/api/v") matches things like "/api/validation"; update the
condition(s) that use pathSpan (in BusinessMetricsMiddleware, where pathSpan is
compared to "/api/users" or StartsWith("/api/v") && EndsWith("/users")) to
ensure the "v" is followed by one or more digits before treating it as a
versioned route. Replace the crude StartsWith check with a digit-aware check
(e.g., Regex.IsMatch(pathSpan, @"^/api/v\d+(?:/|$)", RegexOptions.IgnoreCase) or
manually verify characters after "/api/v" are digits) for each occurrence that
currently uses StartsWith("/api/v") (the conditions around
pathSpan.Equals("/api/users", ...) and the repeated checks on lines noted) so
only true /api/v{n} routes are matched.
In `@src/Shared/Utilities/PiiMaskingHelper.cs`:
- Around line 31-41: The current masking logic uses emailSpan, atIndex, name and
domain but doesn't treat empty local or domain parts as invalid; update the
method to check that both name.Length > 0 and domain.Length > 0 after splitting
(i.e., validate name and domain) and if either is empty return the safe fallback
"***@***"; otherwise proceed with the existing branch logic (keep the
name.Length <= 2 and name[..2] branches) so inputs like "@example.com", "foo@"
or "@" yield the fallback instead of partial masks.
---
Outside diff comments:
In `@src/Shared/Authorization/Middleware/PermissionOptimizationMiddleware.cs`:
- Around line 123-132: O middleware perdeu normalização do path, então chamadas
dentro de GetRequiredPermissionsForPath ainda usam StartsWith/Contains
case-sensitive e falham com rotas maiúsculas; abra a implementação de
GetRequiredPermissionsForPath e alterar todas as comparações de string (ex.:
path.StartsWith(...), path.Contains(...)) para versões que usam
StringComparison.OrdinalIgnoreCase (ou String.Equals com OrdinalIgnoreCase) para
garantir matching case-insensitive ao avaliar permissões com base no path e no
método.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 7ac75c48-2d43-403b-b474-b8b916d92b0e
📒 Files selected for processing (12)
docs/roadmap.mdsrc/Bootstrapper/MeAjudaAi.ApiService/Middlewares/GeographicRestrictionMiddleware.cssrc/Bootstrapper/MeAjudaAi.ApiService/Middlewares/RequestLoggingMiddleware.cssrc/Modules/Users/Application/Handlers/Commands/RegisterCustomerCommandHandler.cssrc/Modules/Users/Infrastructure/Identity/Keycloak/KeycloakService.cssrc/Shared/Authorization/Middleware/PermissionOptimizationMiddleware.cssrc/Shared/Caching/CacheMetrics.cssrc/Shared/Extensions/DocumentExtensions.cssrc/Shared/Messaging/Options/MessageBusOptions.cssrc/Shared/Monitoring/BusinessMetricsMiddleware.cssrc/Shared/Utilities/PhoneNumberValidator.cssrc/Shared/Utilities/PiiMaskingHelper.cs
✅ Files skipped from review due to trivial changes (1)
- src/Modules/Users/Infrastructure/Identity/Keycloak/KeycloakService.cs
…s, PII masking, and request handling middlewares
Owner
Author
|
@coderabbitai próximo tópico: a paginação implementada em todos os projetos foi do tipo offset, mas é sabido que a cursor tem melhor performance e é mais estável. Recomenda fazer mais esta melhoria (alterar paginação offset para cursor)? Qual seria o impacto (quantidade de mudança) versus o benefício? Teria que alterar os projetos frontend também? |
Contributor
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: Length of output: 209715
Cursor vs Offset: análise de custo × benefício para o MeAjudaAi📊 Escopo atual de offset pagination (o que teria que mudar)
⚖️ Benefícios do cursor — e por que não se aplicam aqui
🔴 Problemas específicos que a migração criaria1. SearchProviders usa PostGIS + Dapper SQL bruto: OFFSET `@Skip` LIMIT `@Take`O cursor aqui seria composto por 2. Frontend // use-dashboard.ts — loop para buscar todos os providers
do {
const response = await apiProvidersGet2({ query: { pageNumber: currentPage, pageSize: 100 } });
totalPages = data.totalPages ?? 1;
currentPage++;
} while (currentPage <= totalPages);Cursor pagination não fornece 3. ✅ Veredito
Conclusão: É preciosismo para o estágio atual do projeto. A paginação offset com
🧠 Learnings used |
…ve unit test coverage for core components
Owner
Author
|
@coderabbitai o .net10 introduziu uma nova feature, SSE (serverSentEvents), pode ser aplicado neste projeto? Onde poderia ser utilizado? |
Contributor
There was a problem hiding this comment.
Actionable comments posted: 4
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
src/Shared/Extensions/DocumentExtensions.cs (1)
130-142:⚠️ Potential issue | 🟠 MajorEvite
Math.Abs(BitConverter.ToInt32(...)) % 10na geração de dígitos.Na linha 140,
Math.Abs(int.MinValue)permanece negativo em C#, então o módulo pode gerar valor < 0 e produzir caractere inválido emdocument[i]. Além disso, há alocação debyte[4]por iteração.💡 Sugestão de ajuste
- using var random = RandomNumberGenerator.Create(); var document = new char[baseLength + 2]; @@ - var bytes = new byte[4]; - random.GetBytes(bytes); - var randomNumber = Math.Abs(BitConverter.ToInt32(bytes, 0)) % 10; + var randomNumber = RandomNumberGenerator.GetInt32(10); document[i] = (char)('0' + randomNumber);🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/Shared/Extensions/DocumentExtensions.cs` around lines 130 - 142, In GenerateValidDocument replace the current random digit generation that uses Math.Abs(BitConverter.ToInt32(...)) % 10 and per-iteration byte[4] allocations with RandomNumberGenerator.GetInt32(0, 10) (or a single buffer reused) to produce a safe 0-9 integer without risk of int.MinValue and without allocating a new byte[] each loop; update the loop that sets document[i] to use the GetInt32 result and remove the byte[] and BitConverter usage to eliminate negative modulo bugs and reduce allocations.src/Bootstrapper/MeAjudaAi.ApiService/Middlewares/GeographicRestrictionMiddleware.cs (1)
103-127:⚠️ Potential issue | 🔴 CriticalNão deixe
X-User-Locationmalformado cair no fail-open.Hoje só o caso com segundo
|retorna o sentinel de rejeição. Valores presentes, mas inválidos, comoCity|,|StateouCity, ainda passam para o fallback e podem liberar a request indevidamente, enfraquecendo a restrição geográfica.💡 Ajuste sugerido
if (context.Request.Headers.TryGetValue("X-User-Location", out var locationHeader)) { var headerSpan = locationHeader.ToString().AsSpan(); var separatorIndex = headerSpan.IndexOf('|'); - - if (separatorIndex >= 0) + + if (separatorIndex < 0) + { + return (string.Empty, string.Empty); + } + + if (separatorIndex >= 0) { var remainder = headerSpan[(separatorIndex + 1)..]; if (remainder.IndexOf('|') >= 0) { - // Malformed header, more than one separator. - // Return empty string instead of null to signal malformed but present. return (string.Empty, string.Empty); } var locationCity = headerSpan[..separatorIndex].Trim().ToString(); var locationState = remainder.Trim().ToString(); - // Rejeitar entradas malformadas onde city ou state estão vazios - // Exemplos rejeitados: "City|", "|State", "City| ", " |State" - if (!string.IsNullOrEmpty(locationCity) && !string.IsNullOrEmpty(locationState)) + if (string.IsNullOrEmpty(locationCity) || string.IsNullOrEmpty(locationState)) { - return (locationCity, locationState); + return (string.Empty, string.Empty); } + + return (locationCity, locationState); } }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/Bootstrapper/MeAjudaAi.ApiService/Middlewares/GeographicRestrictionMiddleware.cs` around lines 103 - 127, A rotina de parsing em GeographicRestrictionMiddleware atualmente só trata o caso de múltiplos '|' como malformado; ajuste o parsing do header X-User-Location (no método que lê headerSpan / separatorIndex) para também considerar malformados os casos sem separador, ou com city/state vazios ou contendo apenas whitespace (ex.: "City|", "|State", "City" ou " |State"); após extrair locationCity e locationState (usando Trim()), se separatorIndex < 0 ou se qualquer um dos dois valores for vazio/whitespace, retorne o sentinel de rejeição (string.Empty, string.Empty) para impedir o fail-open, caso contrário continue retornando (locationCity, locationState).
🧹 Nitpick comments (1)
tests/MeAjudaAi.Shared.Tests/Unit/Messaging/Conventions/OptionsTopicNameConventionTests.cs (1)
10-23: O nome do teste promete “delegação”, mas a asserção cobre só a convenção defaultNa Line 10, o nome indica validação de delegação para
MessageBusOptions.TopicNamingConvention; porém nas Lines 13-22 você valida apenas o resultado padrão. Sugiro injetar um delegate customizado para garantir que a delegação ocorre de fato.Diff sugerido
[Fact] public void GetTopic_Should_DelegateToOptionsTopicNamingConvention() { // Arrange - var options = new MessageBusOptions(); + var options = new MessageBusOptions + { + TopicNamingConvention = _ => "custom.events" + }; var sut = new OptionsTopicNameConvention(options); var eventType = typeof(TestEvent); // Act var result = sut.GetTopic(eventType); // Assert - // Default convention should be "{lastPart}.events" - result.Should().Be("conventions.events"); + result.Should().Be("custom.events"); }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@tests/MeAjudaAi.Shared.Tests/Unit/Messaging/Conventions/OptionsTopicNameConventionTests.cs` around lines 10 - 23, The test GetTopic_Should_DelegateToOptionsTopicNamingConvention currently only asserts the default behavior; update it to verify delegation to MessageBusOptions.TopicNamingConvention by assigning a custom TopicNamingConvention delegate on the MessageBusOptions instance, e.g. one that returns a distinct string (or captures the incoming Type) and then assert that OptionsTopicNameConvention.GetTopic(eventType) returns that custom value (or that the delegate received the TestEvent type). Update references in the test to MessageBusOptions.TopicNamingConvention, OptionsTopicNameConvention, GetTopic and TestEvent accordingly so the test proves real delegation.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@src/Bootstrapper/MeAjudaAi.ApiService/Middlewares/GeographicRestrictionMiddleware.cs`:
- Around line 113-114: No arquivo da classe GeographicRestrictionMiddleware,
substitua os dois comentários inline em inglês por versões em português mantendo
o sentido original: explique que o cabeçalho está malformado por conter mais de
um separador e que deve ser retornada string vazia em vez de null para sinalizar
"malformado, mas presente". Atualize os comentários próximos ao trecho que lida
com parsing do header (no bloco comentado que atualmente começa com "Malformed
header...") para português e mantenha o contexto técnico intacto.
In `@src/Shared/Monitoring/BusinessMetricsMiddleware.cs`:
- Around line 57-59: O atual check permite matches parciais (Ex.:
"/api/v1/admin/users"); ajuste para aceitar somente rota exata "users" com ou
sem versão: quando avaliar, mantenha a condição pathSpan.Equals("/api/users",
StringComparison.OrdinalIgnoreCase) para rota não versionada e substitua a
combinação VersionedApiPattern.IsMatch(pathValue) && pathSpan.EndsWith("/users",
...) por um teste que faça match completo contra a versão + recurso (por exemplo
extrair o resultado de VersionedApiPattern.Match(pathValue) e verificar que o
grupo/segmento de recurso é exatamente "users" e que o match abrange toda a
string, ou usar um regex equivalente ^/api/v\d+/users$), aplicando a mesma
correção para as ocorrências que usam VersionedApiPattern/pathValue/pathSpan (as
três outras posições mencionadas) para garantir apenas correspondência exata do
endpoint "users".
In
`@tests/MeAjudaAi.ApiService.Tests/Unit/Middlewares/RequestLoggingMiddlewareTests.cs`:
- Line 336: Padronize o comentário em RequestLoggingMiddlewareTests (no arquivo
RequestLoggingMiddlewareTests.cs) na linha que atualmente diz "Verify that
logging DID happen (at least the start log)" para português; localize o
comentário dentro da classe RequestLoggingMiddlewareTests (no método de teste
correspondente) e substitua por uma versão em pt-BR concisa, por exemplo
"Verifica que o logging ocorreu (pelo menos o log de início)", mantendo o
significado e a clareza do teste.
In
`@tests/MeAjudaAi.Shared.Tests/Unit/Monitoring/BusinessMetricsMiddlewareTests.cs`:
- Around line 186-187: O comentário acima da variável registrationMetrics
("Should NOT record any business-specific metrics if the path is not recognized
as versioned") está em inglês e deve ser padronizado para Português; atualize
esse comentário para uma versão em Português (por exemplo: "Não deve registrar
métricas específicas de negócio se o caminho não for reconhecido como
versionado") mantendo intactos cabeçalhos AAA em inglês nos testes; procure o
comentário que precede a variável registrationMetrics no teste em
BusinessMetricsMiddlewareTests.cs e substitua apenas o texto do comentário.
---
Outside diff comments:
In
`@src/Bootstrapper/MeAjudaAi.ApiService/Middlewares/GeographicRestrictionMiddleware.cs`:
- Around line 103-127: A rotina de parsing em GeographicRestrictionMiddleware
atualmente só trata o caso de múltiplos '|' como malformado; ajuste o parsing do
header X-User-Location (no método que lê headerSpan / separatorIndex) para
também considerar malformados os casos sem separador, ou com city/state vazios
ou contendo apenas whitespace (ex.: "City|", "|State", "City" ou " |State");
após extrair locationCity e locationState (usando Trim()), se separatorIndex < 0
ou se qualquer um dos dois valores for vazio/whitespace, retorne o sentinel de
rejeição (string.Empty, string.Empty) para impedir o fail-open, caso contrário
continue retornando (locationCity, locationState).
In `@src/Shared/Extensions/DocumentExtensions.cs`:
- Around line 130-142: In GenerateValidDocument replace the current random digit
generation that uses Math.Abs(BitConverter.ToInt32(...)) % 10 and per-iteration
byte[4] allocations with RandomNumberGenerator.GetInt32(0, 10) (or a single
buffer reused) to produce a safe 0-9 integer without risk of int.MinValue and
without allocating a new byte[] each loop; update the loop that sets document[i]
to use the GetInt32 result and remove the byte[] and BitConverter usage to
eliminate negative modulo bugs and reduce allocations.
---
Nitpick comments:
In
`@tests/MeAjudaAi.Shared.Tests/Unit/Messaging/Conventions/OptionsTopicNameConventionTests.cs`:
- Around line 10-23: The test
GetTopic_Should_DelegateToOptionsTopicNamingConvention currently only asserts
the default behavior; update it to verify delegation to
MessageBusOptions.TopicNamingConvention by assigning a custom
TopicNamingConvention delegate on the MessageBusOptions instance, e.g. one that
returns a distinct string (or captures the incoming Type) and then assert that
OptionsTopicNameConvention.GetTopic(eventType) returns that custom value (or
that the delegate received the TestEvent type). Update references in the test to
MessageBusOptions.TopicNamingConvention, OptionsTopicNameConvention, GetTopic
and TestEvent accordingly so the test proves real delegation.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 0b2590c8-d08d-499d-9eea-e429fa742282
📒 Files selected for processing (13)
src/Bootstrapper/MeAjudaAi.ApiService/Middlewares/GeographicRestrictionMiddleware.cssrc/Bootstrapper/MeAjudaAi.ApiService/Middlewares/RequestLoggingMiddleware.cssrc/Shared/Authorization/Middleware/PermissionOptimizationMiddleware.cssrc/Shared/Extensions/DocumentExtensions.cssrc/Shared/Messaging/MessagingExtensions.cssrc/Shared/Messaging/Options/MessageBusOptions.cssrc/Shared/Monitoring/BusinessMetricsMiddleware.cssrc/Shared/Utilities/PiiMaskingHelper.cstests/MeAjudaAi.ApiService.Tests/Unit/Middlewares/GeographicRestrictionMiddlewareTests.cstests/MeAjudaAi.ApiService.Tests/Unit/Middlewares/RequestLoggingMiddlewareTests.cstests/MeAjudaAi.Shared.Tests/Unit/Messaging/Conventions/OptionsTopicNameConventionTests.cstests/MeAjudaAi.Shared.Tests/Unit/Monitoring/BusinessMetricsMiddlewareTests.cstests/MeAjudaAi.Shared.Tests/Unit/Utilities/PiiMaskingHelperTests.cs
🚧 Files skipped from review as they are similar to previous changes (3)
- src/Bootstrapper/MeAjudaAi.ApiService/Middlewares/RequestLoggingMiddleware.cs
- src/Shared/Messaging/Options/MessageBusOptions.cs
- src/Shared/Authorization/Middleware/PermissionOptimizationMiddleware.cs
Contributor
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain
.NET 10 SSE (
|
| # | Caso de uso | Módulo | Impacto |
|---|---|---|---|
| 1 | Status de agendamento em tempo real | Bookings |
🔴 Alto |
| 2 | Resultado de pagamento assíncrono | Payments |
🔴 Alto |
| 3 | Notificação de ajuda aceita/concluída | HelpRequests |
🟡 Médio |
| 4 | Métricas do painel admin (substituir polling) | Admin dashboard |
🟡 Médio |
Arquitetura proposta (padrão recomendado para todos os casos)
O padrão ideal é um IHostedService que produz eventos em um Channel<SseItem<T>> e um endpoint Minimal API que expõe esse canal como SSE — isso dá back pressure e um único produtor alimentando vários consumidores.
IntegrationEvent (RabbitMQ) → IHostedService → Channel<SseItem<T>> → SSE Endpoint → Frontend
Exemplo (Bookings — status ao vivo):
// Endpoint Minimal API
app.MapGet("/api/v1/bookings/{id}/status-stream",
(Guid id, BookingStatusChannel channel, CancellationToken ct) =>
{
async IAsyncEnumerable<SseItem<BookingStatusDto>> StreamStatus()
{
await foreach (var update in channel.ReadForBookingAsync(id, ct))
yield return SseItem.Create(update, eventType: "booking-status");
}
return TypedResults.ServerSentEvents(StreamStatus());
})
.RequireAuthorization();⚠️ Caveat crítico: autenticação JWT com EventSource
Não há suporte para adição de headers customizados nas requisições do EventSource nativo do browser — portanto não é possível usar a API nativa para aplicações que enviam tokens no header.
Como o MeAjudaAi usa Keycloak com Bearer tokens, isso é um problema direto. As soluções práticas são:
| Opção | Como funciona | Trade-off |
|---|---|---|
@microsoft/fetch-event-source (recomendada) |
Lib npm baseada em fetch com suporte a headers |
Adiciona 1 dependência leve |
| Token de curta duração em query string | Endpoint /sse-token retorna token temporário (30s) |
Mais complexo no backend |
| Cookie-based | Auth via cookie HttpOnly junto ao JWT | Requer mudança na infra de auth |
A biblioteca fetch-event-source e a Fetch API permitem SSE com método POST, headers customizados e esquemas de autenticação complexos.
Exemplo frontend (React + @microsoft/fetch-event-source):
import { fetchEventSource } from '@microsoft/fetch-event-source';
function useBookingStatusStream(bookingId: string, token: string) {
useEffect(() => {
const ctrl = new AbortController();
fetchEventSource(`/api/v1/bookings/${bookingId}/status-stream`, {
headers: { Authorization: `Bearer ${token}` },
signal: ctrl.signal,
onmessage(ev) {
if (ev.event === 'booking-status') {
const status = JSON.parse(ev.data);
setBookingStatus(status);
}
},
});
return () => ctrl.abort();
}, [bookingId, token]);
}📊 Custo × benefício
| Critério | Avaliação |
|---|---|
| Esforço de implementação | Médio — backend relativamente simples; frontend precisa da lib fetch-event-source |
| Benefício para UX | Alto — elimina polling, atualização instantânea de status de bookings e pagamentos |
| Complexidade operacional | Baixo-Médio — conexões HTTP longas (verificar timeout em load balancers/proxies) |
| Escopo da mudança | Aditivo — não quebra nada existente, novos endpoints SSE ao lado dos REST existentes |
| Compatibilidade com Minimal APIs | ✅ — o projeto já usa o padrão |
| Risco | Baixo — SSE é sobre HTTP simples, não há upgrade de protocolo |
Recomendação
O SSE no .NET 10 é a solução ideal para atualizações simples e unidirecionais como dashboards, sinos de notificação e barras de progresso. É leve, HTTP-nativo e fácil de proteger com o middleware existente. Para o MeAjudaAi, o caso mais impactante seria status de agendamentos em tempo real (Bookings), que hoje provavelmente requer polling ou atualização manual. Pode ser entregue de forma aditiva, sem risco de regressão.
💡 Ponto de atenção operacional: Configure o timeout de leitura do load balancer/proxy para valores altos (ex.: 300s+) nos endpoints SSE, caso contrário a conexão será fechada antes de qualquer evento ser enviado.
Quer que eu elabore o plano de implementação para algum dos casos de uso específicos?
🏁 Script executed:
#!/bin/bash
echo "=== SignalR usage ==="
rg --type cs -n -i '(SignalR|IHubContext|Hub\b|WebSocket)' -A3 -B3
echo ""
echo "=== Notification/Event push patterns ==="
rg --type cs -n -i '(notification|INotif|push|broadcast|realtime|real-time)' -A3 -B3 | head -300
echo ""
echo "=== Booking status change events ==="
rg --type cs -n -i '(BookingStatus|StatusChanged|StatusUpdate|BookingUpdated|BookingCreated|BookingConfirmed|BookingCompleted|BookingCancelled)' -A3 -B3 | head -300
echo ""
echo "=== Integration events (domain events that could feed SSE) ==="
fd -e cs | grep -v '/obj/' | grep -v '/bin/' | grep -iE '(IntegrationEvent|DomainEvent)' | sort
echo ""
echo "=== Polling patterns on frontend ==="
rg -n -i '(setInterval|polling|refetch|useQuery.*refetch|refresh)' --glob '*.ts' --glob '*.tsx' --glob '*.js' --glob '*.jsx' -A3 -B3 | head -300
echo ""
echo "=== Communication/Chat/Message real-time ==="
rg --type cs -n -i '(CommunicationLog|Message|Chat|SendMessage)' -A3 -B3 | head -300
echo ""
echo "=== Payment/Order status streaming candidates ==="
rg --type cs -n -i '(PaymentStatus|OrderStatus|PaymentUpdated|PaymentCompleted|PaymentFailed)' -A3 -B3 | head -200
echo ""
echo "=== Help request status events ==="
rg --type cs -n -i '(HelpRequest|ServiceRequest|RequestStatus|RequestCompleted|RequestCreated)' -A3 -B3 | head -200
echo ""
echo "=== Current target framework ==="
fd -e csproj | xargs grep -l 'TargetFramework' | head -5 | xargs grep 'TargetFramework'
Length of output: 178239
🏁 Script executed:
#!/bin/bash
echo "=== Current target framework ==="
fd -e csproj | grep -v '/obj/' | grep -v '/bin/' | xargs grep 'TargetFramework' 2>/dev/null | head -20
echo ""
echo "=== SignalR usage ==="
rg --type cs -n -i '(SignalR|IHubContext|\.Hub\b|WebSocket)' -A3 -B3 2>/dev/null | head -200
echo ""
echo "=== Polling/real-time frontend patterns ==="
rg -n -i '(setInterval|polling|refetch|EventSource|eventsource)' --glob '*.ts' --glob '*.tsx' --glob '*.js' --glob '*.jsx' -A3 -B3 2>/dev/null | head -300
echo ""
echo "=== Integration events list ==="
fd -e cs | grep -v '/obj/' | grep -v '/bin/' | grep -iE 'IntegrationEvent' | sort
echo ""
echo "=== Domain events list ==="
fd -e cs | grep -v '/obj/' | grep -v '/bin/' | grep -iE 'DomainEvent' | sort
echo ""
echo "=== Booking status domain events ==="
rg --type cs -n -i '(BookingStatus|BookingCreated|BookingConfirmed|BookingCompleted|BookingCancelled|BookingApproved|BookingRejected)' -A2 -B2 | head -300
echo ""
echo "=== Payment status events ==="
rg --type cs -n -i '(PaymentStatus|PaymentCreated|PaymentCompleted|PaymentFailed|PaymentPending)' -A2 -B2 | head -200
echo ""
echo "=== Notification-related files ==="
fd -e cs | grep -v '/obj/' | grep -v '/bin/' | grep -iE 'Notification' | sort
echo ""
echo "=== Help request events ==="
rg --type cs -n -i '(HelpRequestCreated|HelpRequestCompleted|HelpRequestStatus|HelpRequestUpdated)' -A2 -B2 | head -200
Length of output: 62082
🏁 Script executed:
#!/bin/bash
echo "=== Current target framework ==="
fd -e csproj | grep -v '/obj/' | grep -v '/bin/' | xargs grep -l 'TargetFramework' 2>/dev/null | head -5 | xargs grep 'TargetFramework' 2>/dev/null
echo ""
echo "=== SignalR / WebSocket usage ==="
rg --type cs -n -i '(SignalR|IHubContext|\.Hub\b|WebSocket|EventSource)' -A2 -B2 2>/dev/null | head -100
echo ""
echo "=== Notification-related files ==="
fd -e cs | grep -v '/obj/' | grep -v '/bin/' | grep -iE 'Notification' | sort
echo ""
echo "=== Polling/setInterval on frontend ==="
rg -n -i '(setInterval|EventSource|eventsource|polling)' --glob '*.ts' --glob '*.tsx' --glob '*.js' --glob '*.jsx' -A2 -B2 2>/dev/null | head -200
echo ""
echo "=== Integration events list ==="
fd -e cs | grep -v '/obj/' | grep -v '/bin/' | grep -iE 'IntegrationEvent' | sort
echo ""
echo "=== Domain events list ==="
fd -e cs | grep -v '/obj/' | grep -v '/bin/' | grep -iE 'DomainEvent' | sort
echo ""
echo "=== Booking status / domain events ==="
rg --type cs -n -i '(BookingStatus|BookingCreated|BookingConfirmed|BookingCompleted|BookingCancelled|BookingApproved|BookingRejected)' -A2 -B2 | head -200
echo ""
echo "=== Payment events ==="
rg --type cs -n -i '(PaymentStatus|PaymentCreated|PaymentCompleted|PaymentFailed|PaymentPending|PaymentCaptured)' -A2 -B2 | head -200
echo ""
echo "=== Helpdesk/help-requests events ==="
rg --type cs -n -i '(HelpRequestCreated|HelpRequestCompleted|HelpRequestUpdated|HelpRequestStatus)' -A2 -B2 | head -150
echo ""
echo "=== Communication/Notification modules ==="
fd -e cs | grep -v '/obj/' | grep -v '/bin/' | grep -iE '(Communication|Push|Email|Notification)' | sort | head -30
echo ""
echo "=== Admin dashboard data refresh (frontend) ==="
rg -n -i '(dashboard|refetch|refresh|polling|interval)' --glob '*.ts' --glob '*.tsx' -A2 -B2 2>/dev/null | head -200
echo ""
echo "=== use-dashboard.ts content ==="
fd -e ts | grep -i 'use-dashboard' | xargs cat -n 2>/dev/null | head -100
Length of output: 68454
🌐 Web query:
.NET 10 Server-Sent Events native support new feature ASP.NET Core
💡 Result:
.NET 10 / ASP.NET Core 10 adds first-class (native) Server-Sent Events (SSE) support via a built-in HTTP result, so you no longer need to hand-format text/event-stream responses yourself. [1][2]
What’s new
- New result type + helpers:
TypedResults.ServerSentEvents(...)(and the non-typedResults.ServerSentEvents(...)) returns an SSE stream from anIAsyncEnumerable<...>source. [1][2][3] - Event model: SSE messages are represented as
SseItem<T>(can include event type, id, and data payload). [2] - Works in Minimal APIs and MVC controllers. [2]
- Optional .NET client parsing:
System.Net.ServerSentEventsprovidesSseParserfor consuming SSE streams. [4]
Minimal API example (shape)
app.MapGet("/stream", (CancellationToken ct) =>
{
async IAsyncEnumerable<SseItem<MyDto>> GetEvents()
{
while (!ct.IsCancellationRequested)
{
yield return new SseItem<MyDto>(new MyDto(...), eventType: "update", id: "1");
await Task.Delay(1000, ct);
}
}
return TypedResults.ServerSentEvents(GetEvents());
});(Uses TypedResults.ServerSentEvents + SseItem<T> as described in the official docs.) [2][3]
@frigini Sim — dá para aplicar e com bom ROI em alguns fluxos. O projeto já está em net10.0, então podemos usar o SSE nativo do ASP.NET Core via TypedResults.ServerSentEvents e SseItem sem libs externas no servidor. O framework formata automaticamente text/event-stream, mantém a conexão e faz o flush dos eventos a partir de um IAsyncEnumerable. (learn.microsoft.com)
Onde usar primeiro (alto impacto e pouca mudança)
- Status de agendamentos em tempo real
- Backend: emitir eventos quando Booking for Created/Confirmed/Rejected/Cancelled/Completed (já existem Domain Events). Expor endpoint SSE por bookingId.
- Pontos de encaixe:
- Domínio/Handlers: criar handlers em src/Modules/Bookings/Infrastructure/Events/Handlers/ para repassar para um broadcaster SSE.
- Endpoint: src/Modules/Bookings/API/*Endpoints.cs (rota sugerida: GET /api/v1/bookings/{id}/events).
- Verificação de prestador (ProviderVerificationStatusUpdated)
- Backend: já há ProviderVerificationStatusUpdatedDomainEvent + IntegrationEvent/Handler. Acrescentar broadcast SSE no handler existente em src/Modules/Providers/Infrastructure/Events/Handlers/ProviderVerificationStatusUpdatedDomainEventHandler.cs para notificar o próprio prestador.
- Endpoint: GET /api/v1/providers/{id}/verification-events.
Outros candidatos (médio impacto)
- Pagamentos: PaymentTransaction muda de Pending→Succeeded/Failed/Refunded (status está na entidade). Podemos introduzir pequenos Domain Events ou publicar no SSE após persistir a mudança no repositório. Rota: GET /api/v1/payments/{transactionId}/events.
- Dashboard Admin: hoje há refetch manual em app/(admin)/dashboard/page.tsx; podemos substituir por um stream de métricas (ex.: contadores de BusinessMetricsMiddleware) em GET /api/v1/admin/metrics-stream.
Exemplo enxuto (backend)
- Broadcaster (compartilhado) baseado em Channel: criaremos um serviço singleton por “tópico” para publicar/ler SseItem sem alocações desnecessárias e com backpressure.
// Shared/Realtime/SseTopic.cs
using System.Net.ServerSentEvents;
using System.Threading.Channels;
public sealed class SseTopic<T>
{
private readonly Channel<SseItem<T>> _ch = Channel.CreateBounded<SseItem<T>>(new BoundedChannelOptions(1024)
{ SingleReader = false, SingleWriter = false, FullMode = BoundedChannelFullMode.DropOldest });
public bool TryPublish(T data, string eventType, string? id = null) =>
_ch.Writer.TryWrite(new SseItem<T>(data, eventType: eventType) { Id = id });
public IAsyncEnumerable<SseItem<T>> ReadAllAsync(CancellationToken ct) => _ch.Reader.ReadAllAsync(ct);
}- Registro DI e hub simples para lookup por chave (ex.: bookingId, providerId):
// Shared/Realtime/SseHub.cs
public interface ISseHub<T>
{
SseTopic<T> Get(string key);
}
public sealed class SseHub<T> : ISseHub<T>
{
private readonly ConcurrentDictionary<string, SseTopic<T>> _topics = new();
public SseTopic<T> Get(string key) => _topics.GetOrAdd(key, _ => new SseTopic<T>());
}- Endpoint SSE de status de agendamento:
// Modules/Bookings/API/BookingsEndpoints.cs (trecho)
app.MapGet("/api/v1/bookings/{id:guid}/events",
([AsParameters] Guid id, ISseHub<BookingStatusDto> hub, HttpContext http, CancellationToken ct) =>
{
http.Response.Headers.CacheControl = "no-store";
var topic = hub.Get(id.ToString());
async IAsyncEnumerable<SseItem<BookingStatusDto>> Stream([EnumeratorCancellation] CancellationToken token)
{
await foreach (var item in topic.ReadAllAsync(token)) yield return item;
}
return TypedResults.ServerSentEvents(Stream(ct));
})
.RequireAuthorization();- Emissor no handler (ex.: provider verificado):
// Modules/Providers/Infrastructure/Events/Handlers/ProviderVerificationStatusUpdatedDomainEventHandler.cs (trecho)
public sealed class ProviderVerificationStatusUpdatedDomainEventHandler(
IMessageBus bus, ProvidersDbContext ctx, ISearchProvidersModuleApi search,
ILogger<...> logger, ISseHub<ProviderVerificationDto> sseHub)
: IEventHandler<ProviderVerificationStatusUpdatedDomainEvent>
{
public async Task HandleAsync(ProviderVerificationStatusUpdatedDomainEvent e, CancellationToken ct = default)
{
// ... lógica existente (indexação + publish integration event)
var topic = sseHub.Get(e.AggregateId.ToString());
topic.TryPublish(new ProviderVerificationDto { ProviderId = e.AggregateId, Status = e.NewStatus.ToString() },
eventType: "provider-verification", id: DateTimeOffset.UtcNow.ToUnixTimeMilliseconds().ToString());
}
}Exemplo (frontend) com autenticação
- Nativo EventSource não aceita headers customizados (logo, não envia Authorization). Para apps que usam Bearer/JWT (Keycloak), use um client SSE baseado em fetch (ex.: fetch-event-source) para incluir o header. (developer.mozilla.org)
// hooks/useBookingStatusStream.ts
import { fetchEventSource } from '@microsoft/fetch-event-source'; // ou compatível
export function subscribeBookingStatus(bookingId: string, token: string, onMsg: (data: any) => void) {
const ctrl = new AbortController();
fetchEventSource(`/api/v1/bookings/${bookingId}/events`, {
headers: { Authorization: `Bearer ${token}` },
signal: ctrl.signal,
onmessage(ev) {
if (ev.event === 'booking-status') onMsg(JSON.parse(ev.data));
},
onerror(err) { console.error('SSE error', err); },
});
return () => ctrl.abort();
}Notas de implementação
- Autorização/escopo: nas rotas SSE, validar que o usuário tem direito ao recurso (ex.: booking do próprio cliente/prestador; providerId == subject).
- Back-end simples: o próprio ASP.NET Core 10 retorna ServerSentEvents a partir de IAsyncEnumerable<SseItem>; também existe Results.ServerSentEvents se preferir não tipado. (learn.microsoft.com)
- Reconexão/Last-Event-ID: use SseItem.Id e, no cliente, envie Last-Event-ID automaticamente em reconexões; o framework formata os eventos conforme o padrão SSE. (learn.microsoft.com)
- Operação: ajustar timeouts de LB/proxy (idle/read ≥ 300s) nas rotas SSE; desabilitar buffering/caching de resposta (mostrado acima).
- CSP: garantir connect-src para o domínio da API nas páginas dos frontends (se origem diferente). No API Service, o seu ContentSecurityPolicyMiddleware já cuida de connect-src para "'self'" e websocketUrl; para SSE no mesmo host, isso já basta na API; no front (Next), adicione o host da API em connect-src se necessário.
Proposta de piloto (2 semanas, aditivo, sem breaking changes)
- Semana 1
- Infra Realtime: SseTopic/SseHub (Shared) + registro DI.
- Providers: emitir no ProviderVerificationStatusUpdatedDomainEventHandler e expor GET /api/v1/providers/{id}/verification-events.
- Front Customer/Provider: hook simples na página de perfil do prestador para atualizar status em tempo real.
- Semana 2
- Bookings: criar handlers de domínio para cada transição e expor GET /api/v1/bookings/{id}/events com payload BookingStatusDto.
- Admin: endpoint opcional /api/v1/admin/metrics-stream com bateladas periódicas das métricas.
- Observabilidade: contadores de conexões SSE por rota e duração média.
Se quiser, elaboro o plano detalhado (com arquivos/assinaturas exatas e etapas de teste) para o piloto “Providers + Bookings”, e já preparo os trechos de código prontos para colar nos pontos indicados.
Fontes principais
- Documentação oficial do ASP.NET Core 10 para SSE (TypedResults.ServerSentEvents, SseItem, exemplos com Minimal APIs). (learn.microsoft.com)
- Alternativa Results.ServerSentEvents (não tipado). (learn.microsoft.com)
- EventSource básico (MDN) e limitação de headers do EventSource nativo (usar client baseado em fetch quando precisar de Authorization). (developer.mozilla.org)
🧠 Learnings used
Learnt from: frigini
Repo: frigini/MeAjudaAi PR: 0
File: :0-0
Timestamp: 2026-04-20T22:04:25.820Z
Learning: MeAjudaAi (PRs futuros): para cobertura global, NÃO excluir *Configuration e *Extensions (há smoke tests exercitando-os); também não excluir *.Monitoring.*, MeAjudaAi.Shared.Jobs.* e MeAjudaAi.Shared.Mediator.*. Manter excluídos apenas Request/Response/Dto/DTO/IntegrationEvent e *DbContextFactory; Endpoints podem ficar excluídos globalmente, a menos que sejam white-listados por módulo com E2E (ex.: +MeAjudaAi.Modules.Payments.API.*Endpoint; -*Endpoint).
Learnt from: frigini
Repo: frigini/MeAjudaAi PR: 0
File: :0-0
Timestamp: 2026-04-24T20:02:36.451Z
Learning: MeAjudaAi ci-backend.yml (linha 272): Para tornar os endpoints de um módulo visíveis na cobertura do ReportGenerator, adicionar o assembly antes de `-*Endpoint` no classfilters, ex: `+MeAjudaAi.Modules.Bookings.API.*Endpoint` (após `+MeAjudaAi.Modules.Payments.API.*Endpoint`). Isso é necessário apenas para módulos com cobertura E2E. Módulos sem E2E mantêm os endpoints excluídos.
Learnt from: frigini
Repo: frigini/MeAjudaAi PR: 0
File: :0-0
Timestamp: 2026-04-24T20:02:36.451Z
Learning: MeAjudaAi Shared coverage: Classes de infraestrutura de messaging que dependem de broker RabbitMQ real (RabbitMqDeadLetterService, DeadLetterExtensions, FailedMessageInfo, FailureAttempt, EnvironmentMetadata) são candidatas a [ExcludeFromCodeCoverage] pois não são testáveis unitariamente. Utilitários puros (PhoneNumberValidator, PiiMaskingHelper, SlugHelper, UuidGenerator) devem ter testes unitários adicionados em vez de serem excluídos.
Learnt from: frigini
Repo: frigini/MeAjudaAi PR: 0
File: :0-0
Timestamp: 2026-04-24T21:04:28.437Z
Learning: MeAjudaAi Bookings.API: Classes não-endpoint dentro do assembly da API (Extensions, BookingsEndpoints, ProviderAuthorizationResult, ProviderAuthorizationResultExtensions) não são capturadas pelo classfilter `+MeAjudaAi.Modules.Bookings.API.*Endpoint` e devem receber [ExcludeFromCodeCoverage] individualmente (são glue/wiring). Já `ProviderAuthorizationResolver` contém lógica real de autorização e deve ter testes unitários próprios.
Learnt from: frigini
Repo: frigini/MeAjudaAi PR: 0
File: :0-0
Timestamp: 2026-04-19T15:37:29.889Z
Learning: MeAjudaAi: objetivo de cobertura global é ≥90% (linhas), mantendo thresholds 90/80 no CI; quando a meta estiver ameaçada, preferir excluir “glue/DTO” (Endpoints/Extensions/Options/IntegrationEvent/DbContextFactory) e adicionar testes de alto impacto, em vez de reduzir o threshold.
Learnt from: frigini
Repo: frigini/MeAjudaAi PR: 0
File: :0-0
Timestamp: 2026-01-16T21:50:23.593Z
Learning: For frigini/MeAjudaAi Web reviews, prefer commit-by-commit (newest-first) with concise verdicts and concrete follow-ups; prioritize reuse of Shared.Contracts for enums/constants to keep Web aligned with backend/shared code.
Learnt from: frigini
Repo: frigini/MeAjudaAi PR: 77
File: src/Modules/Providers/Tests/Unit/Application/Queries/GetProvidersByIdsQueryTests.cs:65-77
Timestamp: 2025-12-18T00:35:33.829Z
Learning: MeAjudaAi repo: Exceção à política de idioma para comentários — em testes, os cabeçalhos AAA (Arrange, Act, Assert) devem permanecer em inglês e não devem ser traduzidos. Comentários/XML continuam em português; logs em inglês; mensagens ao usuário (validações/APIs) em português.
Learnt from: frigini
Repo: frigini/MeAjudaAi PR: 0
File: :0-0
Timestamp: 2026-04-24T21:04:28.437Z
Learning: MeAjudaAi coverlet.runsettings: `ExcludeByAttribute` deve incluir `ExcludeFromCodeCoverage` (além de Obsolete,GeneratedCode,CompilerGenerated). Sem isso, todas as classes decoradas com [ExcludeFromCodeCoverage] continuam sendo instrumentadas pelo coverlet e contam como linhas não cobertas no relatório, reduzindo a cobertura global. Correção: `<ExcludeByAttribute>Obsolete,GeneratedCode,CompilerGenerated,ExcludeFromCodeCoverage</ExcludeByAttribute>`.
Learnt from: frigini
Repo: frigini/MeAjudaAi PR: 77
File: src/Modules/Documents/Application/Handlers/UploadDocumentCommandHandler.cs:133-143
Timestamp: 2025-12-17T18:26:37.409Z
Learning: MeAjudaAi logging policy: logs must be in English, comments may remain in Portuguese. Portuguese logs were additionally found in Users (API/Extensions.cs:83), Providers (API/Extensions.cs:74), ServiceCatalogs (API/Extensions.cs:78,86,93), and Locations (multiple clients/services lines listed). SearchProviders module currently has no Portuguese logs.
Owner
Author
@coderabbitai Respondendo a isto: Se quiser, elaboro o plano detalhado (com arquivos/assinaturas exatas e etapas de teste) para o piloto “Providers + Bookings”, e já preparo os trechos de código prontos para colar nos pontos indicados. -> sim eu quero, poderia fazer isso detalhadamente? |
…are with associated tests
Contributor
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain
🏁 Script executed: Length of output: 201569
Piloto SSE Providers + Bookings (aditivo, sem breaking changes)
Fases sugeridas e estimativa
Quer que eu já prepare um PR de rascunho com esses arquivos, ou prefere que eu abra issues para cada requisito com checklist? 🧠 Learnings usedThe requested changes have been implemented and a pull request has been created: View PR |
Owner
Author
|
@coderabbitai full review |
Contributor
✅ Actions performedFull review triggered. |
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
tests/MeAjudaAi.Integration.Tests/Middleware/GeographicRestrictionIntegrationTests.cs (1)
211-224:⚠️ Potential issue | 🟡 MinorAtualize a documentação do teste para refletir a nova regra de rejeição.
O resumo XML dos casos extremos ainda descreve fail-open, mas este cenário agora valida rejeição de entrada malformada. Isso gera ambiguidade de intenção.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@tests/MeAjudaAi.Integration.Tests/Middleware/GeographicRestrictionIntegrationTests.cs` around lines 211 - 224, Update the XML summary for the test method GetProviders_WithMalformedLocationHeader_ShouldBeRejected to state that malformed "X-User-Location" headers are rejected (status HttpStatusCode.UnavailableForLegalReasons) instead of describing a fail-open behavior; locate the XML doc comment above the method and replace any wording that mentions "fail-open" or allowing malformed entries with wording that clearly documents rejection and the expected status code.
🧹 Nitpick comments (6)
.github/workflows/ci-backend.yml (1)
70-70: Considere fixar também o digest SHA256 para máxima segurança e reprodutibilidade.A tag
3.33.0já melhora a reprodutibilidade em relação alatest. Para seguir a best practice recomendada pelo GitHub e Docker contra supply chain attacks, considere usar:image: mcr.microsoft.com/azure-storage/azurite:3.33.0@sha256:2628ee10a72833cc344b9d194cd8b245543892b307d16cf26a2cf55a15b816afIsso garante que a imagem exata seja usada independentemente de reatribuições de tags.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/ci-backend.yml at line 70, Replace the mutable tag-only image declaration "image: mcr.microsoft.com/azure-storage/azurite:3.33.0" with the pinned digest form by appending the provided sha256 digest (e.g., change to "image: mcr.microsoft.com/azure-storage/azurite:3.33.0@sha256:2628ee10a72833cc344b9d194cd8b245543892b307d16cf26a2cf55a15b816af") so the workflow uses the exact immutable image artifact and improves security and reproducibility.src/Modules/Users/Application/Handlers/Commands/RegisterCustomerCommandHandler.cs (2)
95-99: Pequena inconsistência com a estratégia deSpannofirstName(ramo sem espaço).No
else, usarnameSpan.ToString()mantém o padrão das otimizações e evita umTrim()extra emcommand.Name.✨ Diff sugerido
- var firstName = firstSpace >= 0 ? nameSpan[..firstSpace].ToString() : command.Name.Trim(); + var firstName = firstSpace >= 0 ? nameSpan[..firstSpace].ToString() : nameSpan.ToString();🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/Modules/Users/Application/Handlers/Commands/RegisterCustomerCommandHandler.cs` around lines 95 - 99, In RegisterCustomerCommandHandler, the else branch for computing firstName breaks the Span-based pattern by calling command.Name.Trim(); change that branch to use nameSpan.ToString() so both the space and no-space paths consistently use the trimmed Span (variables: nameSpan, firstSpace, firstName, lastName) and avoid the extra Trim() allocation.
81-85: Centralize o masking emPiiMaskingHelperpara evitar drift de regra.A lógica aqui duplica comportamento já implementado em
src/Shared/Utilities/PiiMaskingHelper.cs(mesmo padrão de parsing comSpan). Vale consolidar para manter consistência global de mascaramento.♻️ Diff sugerido
- var rawEmailSpan = command.Email.AsSpan(); - var rawAtIndex = rawEmailSpan.IndexOf('@'); - var maskedEmail = rawAtIndex >= 0 - ? $"{new string('*', Math.Min(3, rawAtIndex))}@{rawEmailSpan[(rawAtIndex + 1)..].ToString()}" - : "***@***"; + var maskedEmail = PiiMaskingHelper.MaskEmail(command.Email);🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/Modules/Users/Application/Handlers/Commands/RegisterCustomerCommandHandler.cs` around lines 81 - 85, Substitua a lógica de mascaramento inline em RegisterCustomerCommandHandler (onde são usados rawEmailSpan/rawAtIndex/maskedEmail) por uma chamada ao utilitário central PiiMaskingHelper para evitar duplicação de regras; localize o trecho que constrói maskedEmail e invocar PiiMaskingHelper.MaskEmail(command.Email) (ou o método equivalente exposto em PiiMaskingHelper), removendo o bloqueio de Span/IndexOf e garantindo que o helper trate nulos/strings vazias conforme o comportamento atual.src/Shared/Extensions/DocumentExtensions.cs (1)
96-97: Adicionar guard clauses para tamanhos de multiplicadores evita regressões futuras.Hoje os parâmetros estão corretos, mas sem validação explícita um ajuste futuro nos arrays pode gerar
IndexOutOfRangeExceptionem runtime. Recomendo proteger isso no ponto de entrada dos métodos internos.💡 Diff sugerido
private static bool IsValidDocument(ReadOnlySpan<char> document, int expectedLength, ReadOnlySpan<int> firstMultipliers, ReadOnlySpan<int> secondMultipliers) { + if (firstMultipliers.Length != expectedLength - 2 || secondMultipliers.Length != expectedLength - 1) + return false; + if (document.Length != expectedLength) return false;private static string GenerateValidDocument(int baseLength, ReadOnlySpan<int> firstMultipliers, ReadOnlySpan<int> secondMultipliers) { + if (firstMultipliers.Length != baseLength || secondMultipliers.Length != baseLength + 1) + throw new ArgumentException("Multipliers length does not match document base length."); + var document = new char[baseLength + 2];Also applies to: 130-131
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/Shared/Extensions/DocumentExtensions.cs` around lines 96 - 97, Add explicit guard clauses at the start of IsValidDocument to validate that document.Length equals expectedLength and that firstMultipliers.Length and secondMultipliers.Length match the expected multiplier length (or expectedLength as appropriate); if any check fails, throw an ArgumentException/ArgumentOutOfRangeException with a clear message naming the offending parameter (document, expectedLength, firstMultipliers, secondMultipliers) to prevent IndexOutOfRangeException later. Apply the same validations to the other internal document-validation overloads in this file (the nearby IsValidDocument/validation helper overloads) so all entry points enforce consistent size contracts.src/Shared/Monitoring/BusinessMetricsMiddleware.cs (1)
86-93: Match de conclusão de help-request ainda usa Contains.A lógica para
help-requests/{id}/completeainda usaContains("/help-requests/", ...)que poderia potencialmente casar com paths como/api/v1/admin/help-requests/123/complete. Se isso for uma preocupação, considere usar um regex mais restritivo como^/api/v\d+/help-requests/\d+/complete$.Porém, para esta sprint de otimização, o comportamento atual é aceitável dado que o cenário de admin aninhado é improvável.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/Shared/Monitoring/BusinessMetricsMiddleware.cs` around lines 86 - 93, The current check for help-request completion uses pathSpan.Contains("/help-requests/", ...) which can match nested admin routes; replace that loose Contains-based check by matching the full versioned route with a stricter regex (e.g., anchor to ^/api/v\d+/help-requests/\d+/complete$) or extend VersionedApiPattern to validate the full path before calling businessMetrics.RecordHelpRequestCompleted and logger.LogInformation; update the conditional that references VersionedApiPattern.IsMatch, pathValue, pathSpan, method and statusCode so it only records completions for exact matches of the intended route prior to invoking businessMetrics.RecordHelpRequestCompleted("general", elapsed).tests/MeAjudaAi.Shared.Tests/Unit/Messaging/Conventions/OptionsTopicNameConventionTests.cs (1)
1-30: LGTM! Teste unitário valida a delegação corretamente.O teste verifica que
OptionsTopicNameConvention.GetTopicdelega paraMessageBusOptions.TopicNamingConvention, garantindo que a convenção customizada seja aplicada. A estrutura AAA está clara e o escopo do teste é adequado.Considere adicionar casos de teste adicionais em sprints futuras para cobrir cenários como tipos com namespaces diferentes ou a convenção default quando
TopicNamingConventionnão é customizado.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@tests/MeAjudaAi.Shared.Tests/Unit/Messaging/Conventions/OptionsTopicNameConventionTests.cs` around lines 1 - 30, No changes required; the test OptionsTopicNameConventionTests verifies that OptionsTopicNameConvention.GetTopic delegates to MessageBusOptions.TopicNamingConvention correctly for TestEvent, but if you want to extend coverage later add additional unit tests exercising different event types (with namespaces) and the default behavior when MessageBusOptions.TopicNamingConvention is null or not set to ensure fallback logic is covered.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@tests/MeAjudaAi.Integration.Tests/Middleware/GeographicRestrictionIntegrationTests.cs`:
- Around line 251-253: The CI is failing because the integration test in
GeographicRestrictionIntegrationTests expects 451 for empty city/state headers
but the current middleware returns 200; to fix, either implement the middleware
check in the geographic restriction component to reject empty "city"/"state"
headers and return HttpStatusCode.UnavailableForLegalReasons (451) or update the
test assertions in GeographicRestrictionIntegrationTests to expect
HttpStatusCode.OK for the scenarios at the two failing asserts (previously at
lines asserting 451). Locate the failing assertions in the test class (search
for the assertions comparing response.StatusCode to
HttpStatusCode.UnavailableForLegalReasons) and make the decision: implement
header validation in the middleware that handles geographic restrictions (reject
empty city/state and return 451) or change those assertions to HttpStatusCode.OK
to match current behavior.
---
Outside diff comments:
In
`@tests/MeAjudaAi.Integration.Tests/Middleware/GeographicRestrictionIntegrationTests.cs`:
- Around line 211-224: Update the XML summary for the test method
GetProviders_WithMalformedLocationHeader_ShouldBeRejected to state that
malformed "X-User-Location" headers are rejected (status
HttpStatusCode.UnavailableForLegalReasons) instead of describing a fail-open
behavior; locate the XML doc comment above the method and replace any wording
that mentions "fail-open" or allowing malformed entries with wording that
clearly documents rejection and the expected status code.
---
Nitpick comments:
In @.github/workflows/ci-backend.yml:
- Line 70: Replace the mutable tag-only image declaration "image:
mcr.microsoft.com/azure-storage/azurite:3.33.0" with the pinned digest form by
appending the provided sha256 digest (e.g., change to "image:
mcr.microsoft.com/azure-storage/azurite:3.33.0@sha256:2628ee10a72833cc344b9d194cd8b245543892b307d16cf26a2cf55a15b816af")
so the workflow uses the exact immutable image artifact and improves security
and reproducibility.
In
`@src/Modules/Users/Application/Handlers/Commands/RegisterCustomerCommandHandler.cs`:
- Around line 95-99: In RegisterCustomerCommandHandler, the else branch for
computing firstName breaks the Span-based pattern by calling
command.Name.Trim(); change that branch to use nameSpan.ToString() so both the
space and no-space paths consistently use the trimmed Span (variables: nameSpan,
firstSpace, firstName, lastName) and avoid the extra Trim() allocation.
- Around line 81-85: Substitua a lógica de mascaramento inline em
RegisterCustomerCommandHandler (onde são usados
rawEmailSpan/rawAtIndex/maskedEmail) por uma chamada ao utilitário central
PiiMaskingHelper para evitar duplicação de regras; localize o trecho que
constrói maskedEmail e invocar PiiMaskingHelper.MaskEmail(command.Email) (ou o
método equivalente exposto em PiiMaskingHelper), removendo o bloqueio de
Span/IndexOf e garantindo que o helper trate nulos/strings vazias conforme o
comportamento atual.
In `@src/Shared/Extensions/DocumentExtensions.cs`:
- Around line 96-97: Add explicit guard clauses at the start of IsValidDocument
to validate that document.Length equals expectedLength and that
firstMultipliers.Length and secondMultipliers.Length match the expected
multiplier length (or expectedLength as appropriate); if any check fails, throw
an ArgumentException/ArgumentOutOfRangeException with a clear message naming the
offending parameter (document, expectedLength, firstMultipliers,
secondMultipliers) to prevent IndexOutOfRangeException later. Apply the same
validations to the other internal document-validation overloads in this file
(the nearby IsValidDocument/validation helper overloads) so all entry points
enforce consistent size contracts.
In `@src/Shared/Monitoring/BusinessMetricsMiddleware.cs`:
- Around line 86-93: The current check for help-request completion uses
pathSpan.Contains("/help-requests/", ...) which can match nested admin routes;
replace that loose Contains-based check by matching the full versioned route
with a stricter regex (e.g., anchor to ^/api/v\d+/help-requests/\d+/complete$)
or extend VersionedApiPattern to validate the full path before calling
businessMetrics.RecordHelpRequestCompleted and logger.LogInformation; update the
conditional that references VersionedApiPattern.IsMatch, pathValue, pathSpan,
method and statusCode so it only records completions for exact matches of the
intended route prior to invoking
businessMetrics.RecordHelpRequestCompleted("general", elapsed).
In
`@tests/MeAjudaAi.Shared.Tests/Unit/Messaging/Conventions/OptionsTopicNameConventionTests.cs`:
- Around line 1-30: No changes required; the test
OptionsTopicNameConventionTests verifies that
OptionsTopicNameConvention.GetTopic delegates to
MessageBusOptions.TopicNamingConvention correctly for TestEvent, but if you want
to extend coverage later add additional unit tests exercising different event
types (with namespaces) and the default behavior when
MessageBusOptions.TopicNamingConvention is null or not set to ensure fallback
logic is covered.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: ddaae320-d72c-4ed8-84fc-437a7d1c3835
📒 Files selected for processing (22)
.github/workflows/ci-backend.ymldocs/roadmap-history.mddocs/roadmap.mddocs/technical-debt.mdsrc/Bootstrapper/MeAjudaAi.ApiService/Middlewares/GeographicRestrictionMiddleware.cssrc/Bootstrapper/MeAjudaAi.ApiService/Middlewares/RequestLoggingMiddleware.cssrc/Modules/Users/Application/Handlers/Commands/RegisterCustomerCommandHandler.cssrc/Modules/Users/Infrastructure/Identity/Keycloak/KeycloakService.cssrc/Shared/Authorization/Middleware/PermissionOptimizationMiddleware.cssrc/Shared/Caching/CacheMetrics.cssrc/Shared/Extensions/DocumentExtensions.cssrc/Shared/Messaging/MessagingExtensions.cssrc/Shared/Messaging/Options/MessageBusOptions.cssrc/Shared/Monitoring/BusinessMetricsMiddleware.cssrc/Shared/Utilities/PhoneNumberValidator.cssrc/Shared/Utilities/PiiMaskingHelper.cstests/MeAjudaAi.ApiService.Tests/Unit/Middlewares/GeographicRestrictionMiddlewareTests.cstests/MeAjudaAi.ApiService.Tests/Unit/Middlewares/RequestLoggingMiddlewareTests.cstests/MeAjudaAi.Integration.Tests/Middleware/GeographicRestrictionIntegrationTests.cstests/MeAjudaAi.Shared.Tests/Unit/Messaging/Conventions/OptionsTopicNameConventionTests.cstests/MeAjudaAi.Shared.Tests/Unit/Monitoring/BusinessMetricsMiddlewareTests.cstests/MeAjudaAi.Shared.Tests/Unit/Utilities/PiiMaskingHelperTests.cs
… real-time notification handlers for bookings and provider verifications.
Contributor
There was a problem hiding this comment.
Actionable comments posted: 7
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/Bootstrapper/MeAjudaAi.ApiService/Middlewares/GeographicRestrictionMiddleware.cs (1)
225-266:⚠️ Potential issue | 🟠 MajorEvite decidir no primeiro match de cidade.
Hoje a ordem de
AllowedCitiesmuda o resultado. Ex.: com["Santa Maria|RS", "Santa Maria|DF"], uma request paraSanta Maria/DFbate no primeiroconfigCitye retornafalsesem avaliar a segunda entrada. O mesmo acontece com combinaçõesCity+City|State.💡 Ajuste sugerido
if (!string.IsNullOrEmpty(configCityOnly) && configCityOnly.Equals(city, StringComparison.OrdinalIgnoreCase)) { // Se não temos estado informado, aceitar apenas pelo nome da cidade if (string.IsNullOrEmpty(state)) return true; // Com estado informado, dependerá da regra de estados permitidos - return options.CurrentValue.AllowedStates?.Any(s => - s.Equals(state, StringComparison.OrdinalIgnoreCase)) == true; + if (options.CurrentValue.AllowedStates?.Any(s => + s.Equals(state, StringComparison.OrdinalIgnoreCase)) == true) + { + return true; + } + + continue; } continue; } @@ if (configCity.Equals(city, StringComparison.OrdinalIgnoreCase)) { // Se temos state, validar também if (!string.IsNullOrEmpty(state)) { - return configState.Equals(state, StringComparison.OrdinalIgnoreCase); + if (configState.Equals(state, StringComparison.OrdinalIgnoreCase)) + { + return true; + } + + continue; } // Se não temos state, match apenas por cidade return true; }
🧹 Nitpick comments (4)
src/Modules/Bookings/API/Endpoints/BookingEventsEndpoint.cs (1)
36-39:JsonSerializerOptionsrecriado a cada evento.Uma nova instância de
JsonSerializerOptionsé criada para cada evento serializado. Para conexões SSE de longa duração com muitos eventos, isso gera alocações desnecessárias.♻️ Sugestão de cache das opções de serialização
+/// <summary> +/// Endpoint para streaming SSE de eventos de uma reserva específica. +/// </summary> public class BookingEventsEndpoint : IEndpoint { + private static readonly JsonSerializerOptions JsonOptions = new() + { + PropertyNamingPolicy = JsonNamingPolicy.CamelCase + }; + public static void Map(IEndpointRouteBuilder app) { // ... await foreach (var `@event` in stream.WithCancellation(ct)) { - var json = JsonSerializer.Serialize(`@event`, new JsonSerializerOptions - { - PropertyNamingPolicy = JsonNamingPolicy.CamelCase - }); + var json = JsonSerializer.Serialize(`@event`, JsonOptions);🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/Modules/Bookings/API/Endpoints/BookingEventsEndpoint.cs` around lines 36 - 39, The code recreates JsonSerializerOptions per event in BookingEventsEndpoint: stop allocating on each JsonSerializer.Serialize call by introducing a reusable options instance (e.g., a private static readonly JsonSerializerOptions) configured with PropertyNamingPolicy = JsonNamingPolicy.CamelCase and use that cached instance in the JsonSerializer.Serialize(`@event`, cachedOptions) call instead of newing options each time.src/Modules/Providers/API/Endpoints/ProviderVerificationEventsEndpoint.cs (1)
33-36: Evitar alocação deJsonSerializerOptionsa cada eventoEm Lines 33-36, criar
JsonSerializerOptionsdentro doawait foreachgera alocação contínua em conexão longa. Mova para campo estático reutilizável.♻️ Ajuste sugerido
public class ProviderVerificationEventsEndpoint : IEndpoint { + private static readonly JsonSerializerOptions SseJsonOptions = new() + { + PropertyNamingPolicy = JsonNamingPolicy.CamelCase + }; + public static void Map(IEndpointRouteBuilder app) { @@ - var json = JsonSerializer.Serialize(`@event`, new JsonSerializerOptions - { - PropertyNamingPolicy = JsonNamingPolicy.CamelCase - }); + var json = JsonSerializer.Serialize(`@event`, SseJsonOptions);🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/Modules/Providers/API/Endpoints/ProviderVerificationEventsEndpoint.cs` around lines 33 - 36, The code currently creates a new JsonSerializerOptions inside the event loop when calling JsonSerializer.Serialize(`@event`, new JsonSerializerOptions { PropertyNamingPolicy = JsonNamingPolicy.CamelCase }), causing repeated allocations; refactor by extracting that options instance to a single reusable static readonly field (e.g., private static readonly JsonSerializerOptions _camelCaseSerializerOptions) and change the Serialize call to use that field instead so the same JsonSerializerOptions is reused across iterations.src/Shared/Streaming/SseHub.cs (1)
26-27: Atenção para escala horizontal do hub em memória
SseHub<T>singleton in-memory funciona para piloto em instância única, mas não propaga eventos entre réplicas. Em produção com múltiplas instâncias, considere backplane (Redis/RabbitMQ) ou sticky sessions.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/Shared/Streaming/SseHub.cs` around lines 26 - 27, SseHub<T> is an in-memory singleton that won't forward events across multiple app instances; modify the implementation so it uses a distributed backplane or session-affinity: replace or augment the current SseHub<T>/ISseHub<T> in-memory event store with a pub/sub layer (e.g., Redis pub/sub or RabbitMQ) so Publish/Subscribe methods on SseHub<T> publish to the backplane and subscribe handlers receive cross-instance events, or make session affinity changes in hosting (sticky sessions) and document that requirement; update the SseHub<T> methods that enqueue/broadcast events to call the chosen backplane APIs and ensure subscription/cleanup logic maps to backplane subscriptions.src/Web/MeAjudaAi.Web.Customer/hooks/use-provider-verification.ts (1)
27-35: Evitar literals de status no hookEm Lines 27-35, os valores (
Verified,Rejected, etc.) estão hardcoded. Prefira constantes/enum compartilhadas para evitar drift entre frontend e backend.Based on learnings: prioritize reuse of Shared.Contracts for enums/constants to keep Web aligned with backend/shared code.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/Web/MeAjudaAi.Web.Customer/hooks/use-provider-verification.ts` around lines 27 - 35, Replace the hardcoded status strings in the use-provider-verification hook by importing and using the shared enum/constants from Shared.Contracts (e.g. Shared.Contracts.ProviderStatus) instead of literal values; update the statusLabels map (symbol: statusLabels) to use those enum members as keys and type the map accordingly, and use data.status (from the useProviderVerification hook) against the shared enum so frontend stays aligned with backend/shared definitions.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/Modules/Bookings/API/Endpoints/BookingEventsEndpoint.cs`:
- Around line 18-47: The SSE endpoint GetBookingEvents currently only enforces
authentication but not per-booking authorization; before calling
SseTopic.ForBooking(id) / sseHub.SubscribeAsync(...) retrieve the booking (e.g.,
via the same service/repository used by GetBookingByIdEndpoint such as
IBookingRepository/GetBookingByIdAsync or BookingService) and check the current
user (context.User.Claims or helper like GetUserId()) is the booking's client or
provider; if not, short-circuit with Forbid/Unauthorized; only then create the
topic and subscribe. Ensure you reference GetBookingEvents, SseTopic.ForBooking,
sseHub.SubscribeAsync and the booking lookup method used elsewhere, and keep
cancellation handling and streaming behavior unchanged.
In `@src/Modules/Bookings/Application/Events/BookingRealtimeEventsHandler.cs`:
- Around line 21-53: The handler methods (the various HandleAsync overloads)
accept a CancellationToken but never forward it to PublishUpdate or to
sseHub.PublishAsync; modify each HandleAsync to pass the received
cancellationToken into PublishUpdate, change PublishUpdate signature to accept a
CancellationToken parameter (e.g., PublishUpdate(Guid bookingId, string status,
string message, CancellationToken cancellationToken)), and pass that token
through to the sseHub.PublishAsync call so the SSE publish can be cancelled
cooperatively.
In `@src/Modules/Providers/API/Endpoints/ProviderVerificationEventsEndpoint.cs`:
- Around line 18-45: The endpoint mapped by
MapGet("/{id:guid}/verification-events") currently calls .RequireAuthorization()
which only ensures authentication but does not prevent a non-owner authenticated
user from subscribing to another provider's SSE stream; update the authorization
so only the provider owner or admin can subscribe: either apply a dedicated
policy (e.g., use .RequireAuthorization("ProviderOwnerOrAdmin")) that checks the
route id against the user's provider id/roles, or perform an explicit check
inside the handler (read HttpContext.User claims, compare to the Guid id, and
return Forbid/Unauthorized before creating SseTopic.ForProviderVerification and
calling sseHub.SubscribeAsync) to block horizontal access.
In
`@src/Modules/Providers/Application/Events/ProviderVerificationStatusUpdatedSseHandler.cs`:
- Around line 17-27: The HandleAsync method accepts a CancellationToken but
doesn't pass it to the SSE publish call; update the call to
sseHub.PublishAsync(...) in
ProviderVerificationStatusUpdatedSseHandler.HandleAsync to pass the received
cancellationToken so PublishAsync(topic, data, cancellationToken) (or the
overload your sseHub exposes) is used, ensuring the
ProviderVerificationStatusUpdatedDomainEvent handling respects cancellation.
In `@src/Shared/Extensions/ServiceCollectionExtensions.cs`:
- Around line 141-145: O SseHub<T> está armazenando Channel<T> em um
ConcurrentBag e, por ser registrado via AddStreaming como Singleton, canais
nunca removidos causam vazamento de memória; corrija isso trocando ConcurrentBag
por uma estrutura removível (ex.: ConcurrentDictionary<string, Channel<T>>) em
SseHub<T>, atribuindo um ID único por conexão ao criar o Channel<T> em
SubscribeAsync, adicionando o par id->channel ao dicionário ao inscrever,
removendo explicitamente esse id do dicionário no bloco finally do
SubscribeAsync e encerrando/limpando o channel, e adicionalmente implemente um
mecanismo de limpeza periódica (ex.: timer interno no SseHub<T> ou
IHostedService associado) que percorre o dicionário e remove canais
fechados/inalcançáveis; mantenha a extensão AddStreaming (AddStreaming/
IServiceCollection) como ponto de registro, mas ensure SseHub<T> gerencia a
remoção/cleanup conforme descrito.
In `@src/Shared/Streaming/SseHub.cs`:
- Around line 28-29: O problema é que canais removidos não são excluídos de
_topics, causando vazamento durante churn SSE; altere a estrutura para permitir
remoção eficiente e atualize os pontos que manipulam assinaturas: troque _topics
de ConcurrentDictionary<string, ConcurrentBag<Channel<T>>> para
ConcurrentDictionary<string, ConcurrentDictionary<Channel<T>, byte>> (ou similar
que suporte TryRemove), atualize o fluxo de Subscribe/Unsubscribe para
adicionar/remover o Channel<T> do dicionário interno (usando TryAdd/TryRemove) e
ajuste PublishAsync para iterar nas chaves do dicionário interno em vez do
ConcurrentBag; isso garante que ao encerrar uma assinatura o canal é
efetivamente removido e PublishAsync não acumule canais mortos.
In `@src/Web/MeAjudaAi.Web.Customer/hooks/use-sse.ts`:
- Around line 17-27: O hook useSse depende de useSession() do next-auth/react e
os testes (ex.: dashboard-client.test.tsx) não estão a fornecer esse provider;
para corrigir adicione um mock global de useSession() no arquivo de setup de
testes (__tests__/setup.ts) ou garanta que os testes que importam useSse
envolvam os componentes com SessionProvider; especificamente, exporte/forneça um
wrapper de teste que injete um session com accessToken ou stub useSession para
retornar { data: { accessToken: 'mock' } } e documente esse requisito para que
useSse, useSession e SessionProvider estejam corretamente simulados em todos os
testes.
---
Nitpick comments:
In `@src/Modules/Bookings/API/Endpoints/BookingEventsEndpoint.cs`:
- Around line 36-39: The code recreates JsonSerializerOptions per event in
BookingEventsEndpoint: stop allocating on each JsonSerializer.Serialize call by
introducing a reusable options instance (e.g., a private static readonly
JsonSerializerOptions) configured with PropertyNamingPolicy =
JsonNamingPolicy.CamelCase and use that cached instance in the
JsonSerializer.Serialize(`@event`, cachedOptions) call instead of newing options
each time.
In `@src/Modules/Providers/API/Endpoints/ProviderVerificationEventsEndpoint.cs`:
- Around line 33-36: The code currently creates a new JsonSerializerOptions
inside the event loop when calling JsonSerializer.Serialize(`@event`, new
JsonSerializerOptions { PropertyNamingPolicy = JsonNamingPolicy.CamelCase }),
causing repeated allocations; refactor by extracting that options instance to a
single reusable static readonly field (e.g., private static readonly
JsonSerializerOptions _camelCaseSerializerOptions) and change the Serialize call
to use that field instead so the same JsonSerializerOptions is reused across
iterations.
In `@src/Shared/Streaming/SseHub.cs`:
- Around line 26-27: SseHub<T> is an in-memory singleton that won't forward
events across multiple app instances; modify the implementation so it uses a
distributed backplane or session-affinity: replace or augment the current
SseHub<T>/ISseHub<T> in-memory event store with a pub/sub layer (e.g., Redis
pub/sub or RabbitMQ) so Publish/Subscribe methods on SseHub<T> publish to the
backplane and subscribe handlers receive cross-instance events, or make session
affinity changes in hosting (sticky sessions) and document that requirement;
update the SseHub<T> methods that enqueue/broadcast events to call the chosen
backplane APIs and ensure subscription/cleanup logic maps to backplane
subscriptions.
In `@src/Web/MeAjudaAi.Web.Customer/hooks/use-provider-verification.ts`:
- Around line 27-35: Replace the hardcoded status strings in the
use-provider-verification hook by importing and using the shared enum/constants
from Shared.Contracts (e.g. Shared.Contracts.ProviderStatus) instead of literal
values; update the statusLabels map (symbol: statusLabels) to use those enum
members as keys and type the map accordingly, and use data.status (from the
useProviderVerification hook) against the shared enum so frontend stays aligned
with backend/shared definitions.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 88cef375-4487-4960-85c6-90a0775cef1e
⛔ Files ignored due to path filters (6)
package-lock.jsonis excluded by!**/package-lock.json,!**/package-lock.jsonsrc/Web/MeAjudaAi.Web.Provider/app/page.tsxis excluded by!**/MeAjudaAi.Web.Provider/**src/Web/MeAjudaAi.Web.Provider/hooks/use-provider-verification.tsis excluded by!**/MeAjudaAi.Web.Provider/**src/Web/MeAjudaAi.Web.Provider/hooks/use-sse.tsis excluded by!**/MeAjudaAi.Web.Provider/**src/Web/MeAjudaAi.Web.Provider/package.jsonis excluded by!**/MeAjudaAi.Web.Provider/**src/Web/package-lock.jsonis excluded by!**/package-lock.json,!**/package-lock.json
📒 Files selected for processing (28)
.github/workflows/ci-backend.ymlpackage.jsonsrc/Bootstrapper/MeAjudaAi.ApiService/Middlewares/GeographicRestrictionMiddleware.cssrc/Modules/Bookings/API/Endpoints/BookingEventsEndpoint.cssrc/Modules/Bookings/API/Endpoints/BookingsEndpoints.cssrc/Modules/Bookings/Application/DTOs/BookingStatusSseDto.cssrc/Modules/Bookings/Application/Events/BookingRealtimeEventsHandler.cssrc/Modules/Bookings/Application/Extensions.cssrc/Modules/Providers/API/Endpoints/ProviderVerificationEventsEndpoint.cssrc/Modules/Providers/API/Endpoints/ProvidersModuleEndpoints.cssrc/Modules/Providers/Application/DTOs/ProviderVerificationSseDto.cssrc/Modules/Providers/Application/Events/ProviderVerificationStatusUpdatedSseHandler.cssrc/Modules/Providers/Application/Extensions.cssrc/Shared/Extensions/DocumentExtensions.cssrc/Shared/Extensions/ServiceCollectionExtensions.cssrc/Shared/Monitoring/BusinessMetricsMiddleware.cssrc/Shared/Streaming/SseHub.cssrc/Shared/Streaming/SseTopic.cssrc/Web/MeAjudaAi.Web.Customer/components/providers/dashboard-client.tsxsrc/Web/MeAjudaAi.Web.Customer/hooks/use-booking-events.tssrc/Web/MeAjudaAi.Web.Customer/hooks/use-provider-verification.tssrc/Web/MeAjudaAi.Web.Customer/hooks/use-sse.tssrc/Web/MeAjudaAi.Web.Customer/package.jsonsrc/Web/package.jsontests/MeAjudaAi.ApiService.Tests/Unit/Middlewares/RequestLoggingMiddlewareTests.cstests/MeAjudaAi.Integration.Tests/Middleware/GeographicRestrictionIntegrationTests.cstests/MeAjudaAi.Shared.Tests/Unit/Messaging/Conventions/OptionsTopicNameConventionTests.cstests/MeAjudaAi.Shared.Tests/Unit/Monitoring/BusinessMetricsMiddlewareTests.cs
✅ Files skipped from review due to trivial changes (6)
- src/Web/MeAjudaAi.Web.Customer/package.json
- src/Web/package.json
- src/Shared/Streaming/SseTopic.cs
- .github/workflows/ci-backend.yml
- package.json
- src/Modules/Providers/Application/DTOs/ProviderVerificationSseDto.cs
🚧 Files skipped from review as they are similar to previous changes (5)
- tests/MeAjudaAi.Shared.Tests/Unit/Monitoring/BusinessMetricsMiddlewareTests.cs
- tests/MeAjudaAi.Shared.Tests/Unit/Messaging/Conventions/OptionsTopicNameConventionTests.cs
- src/Shared/Monitoring/BusinessMetricsMiddleware.cs
- tests/MeAjudaAi.Integration.Tests/Middleware/GeographicRestrictionIntegrationTests.cs
- src/Shared/Extensions/DocumentExtensions.cs
added 2 commits
April 29, 2026 12:55
…s and messaging infrastructure updates
…bookings and provider verification updates
Owner
Author
|
@coderabbitai a cobertura geral do backend caiu para 89.87% com as ultimas alterações, preciso recuperar para talvez 91%, poderia encontrar os gaps? |
Contributor
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chainVou analisar os arquivos novos e modificados neste PR para mapear os gaps de cobertura. 🏁 Script executed: Length of output: 120951
Diagnóstico de Coverage Gaps🔴 Gap 1 —
|
| Ação | Linhas recuperadas (est.) | Esforço |
|---|---|---|
[ExcludeFromCodeCoverage] em SseHub<T>, SseTopic, 2 endpoints |
~190 linhas excluídas do denominador | 5 min |
Testes BookingRealtimeEventsHandler |
+51 linhas cobertas | 30 min |
Testes ProviderVerificationStatusUpdatedSseHandler |
+25 linhas cobertas | 15 min |
Remover guards mortos DocumentExtensions |
+6 linhas cobertas | 2 min |
Com as ações 1+2+3+4 combinadas, a cobertura deve voltar facilmente para ≥ 91%.
🧠 Learnings used
Learnt from: frigini
Repo: frigini/MeAjudaAi PR: 0
File: :0-0
Timestamp: 2026-04-20T22:04:25.820Z
Learning: MeAjudaAi (PRs futuros): para cobertura global, NÃO excluir *Configuration e *Extensions (há smoke tests exercitando-os); também não excluir *.Monitoring.*, MeAjudaAi.Shared.Jobs.* e MeAjudaAi.Shared.Mediator.*. Manter excluídos apenas Request/Response/Dto/DTO/IntegrationEvent e *DbContextFactory; Endpoints podem ficar excluídos globalmente, a menos que sejam white-listados por módulo com E2E (ex.: +MeAjudaAi.Modules.Payments.API.*Endpoint; -*Endpoint).
Learnt from: frigini
Repo: frigini/MeAjudaAi PR: 0
File: :0-0
Timestamp: 2026-04-24T20:02:36.451Z
Learning: MeAjudaAi ci-backend.yml (linha 272): Para tornar os endpoints de um módulo visíveis na cobertura do ReportGenerator, adicionar o assembly antes de `-*Endpoint` no classfilters, ex: `+MeAjudaAi.Modules.Bookings.API.*Endpoint` (após `+MeAjudaAi.Modules.Payments.API.*Endpoint`). Isso é necessário apenas para módulos com cobertura E2E. Módulos sem E2E mantêm os endpoints excluídos.
Learnt from: frigini
Repo: frigini/MeAjudaAi PR: 0
File: :0-0
Timestamp: 2026-04-24T20:02:36.451Z
Learning: MeAjudaAi Shared coverage: Classes de infraestrutura de messaging que dependem de broker RabbitMQ real (RabbitMqDeadLetterService, DeadLetterExtensions, FailedMessageInfo, FailureAttempt, EnvironmentMetadata) são candidatas a [ExcludeFromCodeCoverage] pois não são testáveis unitariamente. Utilitários puros (PhoneNumberValidator, PiiMaskingHelper, SlugHelper, UuidGenerator) devem ter testes unitários adicionados em vez de serem excluídos.
Learnt from: frigini
Repo: frigini/MeAjudaAi PR: 0
File: :0-0
Timestamp: 2026-04-24T21:04:28.437Z
Learning: MeAjudaAi Bookings.API: Classes não-endpoint dentro do assembly da API (Extensions, BookingsEndpoints, ProviderAuthorizationResult, ProviderAuthorizationResultExtensions) não são capturadas pelo classfilter `+MeAjudaAi.Modules.Bookings.API.*Endpoint` e devem receber [ExcludeFromCodeCoverage] individualmente (são glue/wiring). Já `ProviderAuthorizationResolver` contém lógica real de autorização e deve ter testes unitários próprios.
Learnt from: frigini
Repo: frigini/MeAjudaAi PR: 0
File: :0-0
Timestamp: 2026-04-19T15:37:29.889Z
Learning: MeAjudaAi: objetivo de cobertura global é ≥90% (linhas), mantendo thresholds 90/80 no CI; quando a meta estiver ameaçada, preferir excluir “glue/DTO” (Endpoints/Extensions/Options/IntegrationEvent/DbContextFactory) e adicionar testes de alto impacto, em vez de reduzir o threshold.
Learnt from: frigini
Repo: frigini/MeAjudaAi PR: 0
File: :0-0
Timestamp: 2026-01-16T21:50:23.593Z
Learning: For frigini/MeAjudaAi Web reviews, prefer commit-by-commit (newest-first) with concise verdicts and concrete follow-ups; prioritize reuse of Shared.Contracts for enums/constants to keep Web aligned with backend/shared code.
Learnt from: frigini
Repo: frigini/MeAjudaAi PR: 77
File: src/Modules/Providers/Tests/Unit/Application/Queries/GetProvidersByIdsQueryTests.cs:65-77
Timestamp: 2025-12-18T00:35:33.829Z
Learning: MeAjudaAi repo: Exceção à política de idioma para comentários — em testes, os cabeçalhos AAA (Arrange, Act, Assert) devem permanecer em inglês e não devem ser traduzidos. Comentários/XML continuam em português; logs em inglês; mensagens ao usuário (validações/APIs) em português.
Learnt from: frigini
Repo: frigini/MeAjudaAi PR: 0
File: :0-0
Timestamp: 2026-04-24T21:04:28.437Z
Learning: MeAjudaAi coverlet.runsettings: `ExcludeByAttribute` deve incluir `ExcludeFromCodeCoverage` (além de Obsolete,GeneratedCode,CompilerGenerated). Sem isso, todas as classes decoradas com [ExcludeFromCodeCoverage] continuam sendo instrumentadas pelo coverlet e contam como linhas não cobertas no relatório, reduzindo a cobertura global. Correção: `<ExcludeByAttribute>Obsolete,GeneratedCode,CompilerGenerated,ExcludeFromCodeCoverage</ExcludeByAttribute>`.
Learnt from: frigini
Repo: frigini/MeAjudaAi PR: 77
File: src/Modules/Documents/Application/Handlers/UploadDocumentCommandHandler.cs:133-143
Timestamp: 2025-12-17T18:26:37.409Z
Learning: MeAjudaAi logging policy: logs must be in English, comments may remain in Portuguese. Portuguese logs were additionally found in Users (API/Extensions.cs:83), Providers (API/Extensions.cs:74), ServiceCatalogs (API/Extensions.cs:78,86,93), and Locations (multiple clients/services lines listed). SearchProviders module currently has no Portuguese logs.
Learnt from: frigini
Repo: frigini/MeAjudaAi PR: 77
File: src/Modules/Documents/Application/Handlers/UploadDocumentCommandHandler.cs:133-143
Timestamp: 2025-12-17T18:09:54.585Z
Learning: In the MeAjudaAi codebase, when reviewing log messages in application handlers, verify they are in English. The file src/Modules/Documents/Application/Handlers/UploadDocumentCommandHandler.cs had Portuguese logs that violated the English-only logging policy.
…ment validation utilities
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (6)
tests/MeAjudaAi.Integration.Tests/Middleware/GeographicRestrictionIntegrationTests.cs (1)
271-273: Ajuste opcional de mensagem de assert para refletir o cenário real.Aqui o teste usa headers separados (
X-User-City/X-User-State), mas a mensagem fala em “Malformed location header (empty state)”, o que pode confundir diagnóstico de falha.✏️ Sugestão de ajuste
- // Assert - formato "City|" é malformado e deve ser bloqueado + // Assert - estado vazio no header deve ser bloqueado (sem fail-open) response.StatusCode.Should().Be(HttpStatusCode.UnavailableForLegalReasons, - "Malformed location header (empty state) should be rejected"); + "Empty state header should be rejected (no fail-open)");🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@tests/MeAjudaAi.Integration.Tests/Middleware/GeographicRestrictionIntegrationTests.cs` around lines 271 - 273, Update the assert failure message in GeographicRestrictionIntegrationTests where response.StatusCode.Should().Be(HttpStatusCode.UnavailableForLegalReasons, ...) is used: change the message to explicitly state the tested condition using separate headers (e.g., "Malformed location headers (empty X-User-State) should be rejected") so it accurately reflects that X-User-City/X-User-State were used and the state header was empty; locate the assertion in the test method that builds the request with X-User-City/X-User-State and replace the current "Malformed location header (empty state) should be rejected" text with a clearer message referencing the empty X-User-State header.src/Modules/Bookings/Application/Events/BookingRealtimeEventsHandler.cs (1)
20-40: Reduzir risco de drift: evitar strings mágicas de status.Os valores
"Created","Confirmed","Cancelled","Rejected"e"Completed"estão duplicados no handler/testes/frontend. Centralizar em contrato compartilhado (ou constants únicas) evita divergência silenciosa.Based on learnings: prioritize reuse of Shared.Contracts for enums/constants to keep Web aligned with backend/shared code.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/Modules/Bookings/Application/Events/BookingRealtimeEventsHandler.cs` around lines 20 - 40, Substitua as strings mágicas de status usadas nas overloads HandleAsync (ex.: BookingCreatedDomainEvent, BookingConfirmedDomainEvent, BookingCancelledDomainEvent, BookingRejectedDomainEvent, BookingCompletedDomainEvent) e no call PublishUpdate por constantes/enums centralizadas em Shared.Contracts (por exemplo um BookingStatus enum ou Status constants): importe o contrato compartilhado no topo da classe BookingRealtimeEventsHandler e use os membros tipados (ex.: BookingStatus.Created) em vez de "Created"/"Confirmed"/"Cancelled"/"Rejected"/"Completed"; aplique a mesma mudança em quaisquer testes ou código frontend que referenciem essas strings para evitar drift.src/Modules/Bookings/Tests/Unit/Application/Events/BookingRealtimeEventsHandlerTests.cs (1)
35-103: Blindar i18n/UX: validar tambémMessagenos asserts do DTO.Atualmente os testes garantem
Status, mas não garantem o texto exibível no cliente. Vale incluirMessage(eBookingIdnos demais casos) para evitar regressão silenciosa.✅ Exemplo de ajuste (padrão para os 5 testes)
_sseHubMock.Verify(h => h.PublishAsync( SseTopic.ForBooking(bookingId), - It.Is<BookingStatusSseDto>(d => d.Status == "Confirmed"), + It.Is<BookingStatusSseDto>(d => + d.BookingId == bookingId && + d.Status == "Confirmed" && + d.Message == "Reserva confirmada pelo prestador"), It.IsAny<CancellationToken>()), Times.Once);Based on learnings: user-facing validation messages and API responses shown to the frontend must be in Portuguese.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/Modules/Bookings/Tests/Unit/Application/Events/BookingRealtimeEventsHandlerTests.cs` around lines 35 - 103, Update each test that calls _sseHubMock.Verify for SseTopic.ForBooking to also assert the DTO's BookingId and Message (in addition to Status) so the published BookingStatusSseDto contains the correct booking identifier and Portuguese user-facing text; specifically modify the predicate in the It.Is<BookingStatusSseDto>(...) used in tests HandleAsync_BookingCreated_ShouldPublishCreatedStatus, HandleAsync_BookingConfirmed_ShouldPublishConfirmedStatus, HandleAsync_BookingCancelled_ShouldPublishCancelledStatus, HandleAsync_BookingRejected_ShouldPublishRejectedStatus and HandleAsync_BookingCompleted_ShouldPublishCompletedStatus to check d.BookingId == bookingId and that d.Message equals the expected Portuguese message for each status.src/Modules/Providers/Tests/Unit/Application/Events/ProviderVerificationStatusUpdatedSseHandlerTests.cs (1)
13-65: Adicionar teste explícito de propagação deCancellationToken.Hoje os testes validam o conteúdo publicado, mas não blindam regressão de cancelamento (chamadas em Line 32 e Line 59 sem token explícito).
✅ Sugestão de teste adicional
+ [Fact] + public async Task HandleAsync_ShouldForwardCancellationTokenToPublishAsync() + { + var sseHubMock = new Mock<ISseHub<ProviderVerificationSseDto>>(); + sseHubMock + .Setup(h => h.PublishAsync(It.IsAny<string>(), It.IsAny<ProviderVerificationSseDto>(), It.IsAny<CancellationToken>())) + .Returns(Task.CompletedTask); + + var logger = Mock.Of<ILogger<ProviderVerificationStatusUpdatedSseHandler>>(); + var sut = new ProviderVerificationStatusUpdatedSseHandler(sseHubMock.Object, logger); + + var providerId = Guid.NewGuid(); + var `@event` = new ProviderVerificationStatusUpdatedDomainEvent( + providerId, 1, EVerificationStatus.Pending, EVerificationStatus.Verified, "admin"); + using var cts = new CancellationTokenSource(); + + await sut.HandleAsync(`@event`, cts.Token); + + sseHubMock.Verify(h => h.PublishAsync( + SseTopic.ForProviderVerification(providerId), + It.IsAny<ProviderVerificationSseDto>(), + cts.Token), Times.Once); + }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/Modules/Providers/Tests/Unit/Application/Events/ProviderVerificationStatusUpdatedSseHandlerTests.cs` around lines 13 - 65, The tests currently assert the published DTO but don't ensure the CancellationToken passed to ProviderVerificationStatusUpdatedSseHandler.HandleAsync is forwarded to ISseHub.PublishAsync; update both tests (HandleAsync_ShouldPublishVerificationStatusToHub and HandleAsync_ShouldPublishRejectedStatus) to create an explicit CancellationToken (e.g., via new CancellationTokenSource().Token), call sut.HandleAsync(`@event`, cancellationToken) and change the Verify to assert the PublishAsync call received that exact token (use It.Is<CancellationToken>(t => t == cancellationToken)); also update the Setup on the ISseHub<ProviderVerificationSseDto> mock to accept that token so the test still returns Task.CompletedTask. This ensures ProviderVerificationStatusUpdatedSseHandler.HandleAsync correctly propagates the cancellation token to ISseHub.PublishAsync.src/Modules/Users/Application/Handlers/Commands/RegisterCustomerCommandHandler.cs (1)
91-95: Sugestão: tornar o split de nome robusto para qualquer whitespace.Atualmente o corte usa apenas
' '. Em entradas com tab/line-break entre nome e sobrenome, pode cair em validação incorreta de sobrenome ausente.💡 Diff sugerido
- var nameSpan = command.Name.AsSpan().Trim(); - var firstSpace = nameSpan.IndexOf(' '); - - var firstName = firstSpace >= 0 ? nameSpan[..firstSpace].ToString() : nameSpan.ToString(); - var lastName = firstSpace >= 0 ? nameSpan[(firstSpace + 1)..].TrimStart().ToString() : string.Empty; + var nameSpan = command.Name.AsSpan().Trim(); + var splitIndex = -1; + for (var i = 0; i < nameSpan.Length; i++) + { + if (char.IsWhiteSpace(nameSpan[i])) + { + splitIndex = i; + break; + } + } + + var firstName = splitIndex >= 0 ? nameSpan[..splitIndex].ToString() : nameSpan.ToString(); + var lastName = splitIndex >= 0 ? nameSpan[(splitIndex + 1)..].Trim().ToString() : string.Empty;Also applies to: 102-105
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/Modules/Users/Application/Handlers/Commands/RegisterCustomerCommandHandler.cs` around lines 91 - 95, The current name-splitting logic in RegisterCustomerCommandHandler uses a literal space character which fails on tabs/newlines; update the parsing of command.Name (the nameSpan/firstSpace/firstName/lastName logic) to split on any whitespace (e.g., use command.Name.Split((char[])null, StringSplitOptions.RemoveEmptyEntries) or iterate using char.IsWhiteSpace) and then set firstName to the first token and lastName to the remainder joined with a single space (apply the same change to the second occurrence of this logic later in the file).src/Shared/Monitoring/BusinessMetricsMiddleware.cs (1)
56-60: Simplifique o predicado de rota de usuários para reduzir complexidade no hot path.Aqui há checks redundantes: o
Regex.IsMatch("^/api/v\\d+/users$")já garante versão válida + match exato do endpoint. ManterStartsWith+Slice+EndsWithno mesmo bloco aumenta custo e manutenção sem ganho funcional.♻️ Proposta de simplificação
- var isUserPath = pathSpan.Equals("/api/users", StringComparison.OrdinalIgnoreCase) || - (pathSpan.StartsWith("/api/v", StringComparison.OrdinalIgnoreCase) && - pathSpan.Slice(5).IndexOf('/') > 0 && - pathValue.EndsWith("/users", StringComparison.OrdinalIgnoreCase) && - Regex.IsMatch(pathValue, @"^/api/v\d+/users$", RegexOptions.IgnoreCase)); + var isUserPath = pathSpan.Equals("/api/users", StringComparison.OrdinalIgnoreCase) || + Regex.IsMatch(pathValue, @"^/api/v\d+/users$", RegexOptions.IgnoreCase);🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/Shared/Monitoring/BusinessMetricsMiddleware.cs` around lines 56 - 60, O predicado que define isUserPath mistura checagens redundantes (StartsWith/Slice/EndsWith) com Regex.IsMatch; simplifique para reduzir custo no hot path mantendo o comportamento: substituir a expressão atual por uma verificação simples que aceita exatamente "/api/users" (comparação com pathSpan/pathValue usando StringComparison.OrdinalIgnoreCase) ou aplica apenas o Regex.IsMatch para o padrão de versão (por exemplo @"^/api/v\d+/users$") contra pathValue; ajuste o uso de pathSpan/pathValue conforme necessário para evitar chamadas extras e preserve o nome isUserPath para clareza.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/Shared/Messaging/Options/MessageBusOptions.cs`:
- Around line 27-35: The current topic naming logic only takes the final
namespace segment (lastPart) causing many different events to map to
"events.events"; change the topic key to incorporate the event type name to make
it unique: replace the use of only nsSpan/lastPart in the return with a
combination that includes type.Name (for example, use
type.Name.ToLowerInvariant() + "." + lastPart.ToString().ToLowerInvariant() or
simply type.Name.ToLowerInvariant() + ".events"); update the return expression
where lastPart is used so topics are generated from the event type name plus the
suffix instead of only the namespace tail.
In
`@tests/MeAjudaAi.Shared.Tests/Unit/Monitoring/BusinessMetricsMiddlewareTests.cs`:
- Around line 170-189: The test promises "no business metrics" but only asserts
on measurements with tag source=api; change the assertion to verify that no
business metrics were recorded at all after invoking
BusinessMetricsMiddleware.InvokeAsync by asserting that the _longMeasurements
collection is empty (replace the filtered registrationMetrics check with a
direct _longMeasurements.Should().BeEmpty()). This ensures the test fails if any
metric (not only source=api) was emitted for the unversioned path.
---
Nitpick comments:
In `@src/Modules/Bookings/Application/Events/BookingRealtimeEventsHandler.cs`:
- Around line 20-40: Substitua as strings mágicas de status usadas nas overloads
HandleAsync (ex.: BookingCreatedDomainEvent, BookingConfirmedDomainEvent,
BookingCancelledDomainEvent, BookingRejectedDomainEvent,
BookingCompletedDomainEvent) e no call PublishUpdate por constantes/enums
centralizadas em Shared.Contracts (por exemplo um BookingStatus enum ou Status
constants): importe o contrato compartilhado no topo da classe
BookingRealtimeEventsHandler e use os membros tipados (ex.:
BookingStatus.Created) em vez de
"Created"/"Confirmed"/"Cancelled"/"Rejected"/"Completed"; aplique a mesma
mudança em quaisquer testes ou código frontend que referenciem essas strings
para evitar drift.
In
`@src/Modules/Bookings/Tests/Unit/Application/Events/BookingRealtimeEventsHandlerTests.cs`:
- Around line 35-103: Update each test that calls _sseHubMock.Verify for
SseTopic.ForBooking to also assert the DTO's BookingId and Message (in addition
to Status) so the published BookingStatusSseDto contains the correct booking
identifier and Portuguese user-facing text; specifically modify the predicate in
the It.Is<BookingStatusSseDto>(...) used in tests
HandleAsync_BookingCreated_ShouldPublishCreatedStatus,
HandleAsync_BookingConfirmed_ShouldPublishConfirmedStatus,
HandleAsync_BookingCancelled_ShouldPublishCancelledStatus,
HandleAsync_BookingRejected_ShouldPublishRejectedStatus and
HandleAsync_BookingCompleted_ShouldPublishCompletedStatus to check d.BookingId
== bookingId and that d.Message equals the expected Portuguese message for each
status.
In
`@src/Modules/Providers/Tests/Unit/Application/Events/ProviderVerificationStatusUpdatedSseHandlerTests.cs`:
- Around line 13-65: The tests currently assert the published DTO but don't
ensure the CancellationToken passed to
ProviderVerificationStatusUpdatedSseHandler.HandleAsync is forwarded to
ISseHub.PublishAsync; update both tests
(HandleAsync_ShouldPublishVerificationStatusToHub and
HandleAsync_ShouldPublishRejectedStatus) to create an explicit CancellationToken
(e.g., via new CancellationTokenSource().Token), call sut.HandleAsync(`@event`,
cancellationToken) and change the Verify to assert the PublishAsync call
received that exact token (use It.Is<CancellationToken>(t => t ==
cancellationToken)); also update the Setup on the
ISseHub<ProviderVerificationSseDto> mock to accept that token so the test still
returns Task.CompletedTask. This ensures
ProviderVerificationStatusUpdatedSseHandler.HandleAsync correctly propagates the
cancellation token to ISseHub.PublishAsync.
In
`@src/Modules/Users/Application/Handlers/Commands/RegisterCustomerCommandHandler.cs`:
- Around line 91-95: The current name-splitting logic in
RegisterCustomerCommandHandler uses a literal space character which fails on
tabs/newlines; update the parsing of command.Name (the
nameSpan/firstSpace/firstName/lastName logic) to split on any whitespace (e.g.,
use command.Name.Split((char[])null, StringSplitOptions.RemoveEmptyEntries) or
iterate using char.IsWhiteSpace) and then set firstName to the first token and
lastName to the remainder joined with a single space (apply the same change to
the second occurrence of this logic later in the file).
In `@src/Shared/Monitoring/BusinessMetricsMiddleware.cs`:
- Around line 56-60: O predicado que define isUserPath mistura checagens
redundantes (StartsWith/Slice/EndsWith) com Regex.IsMatch; simplifique para
reduzir custo no hot path mantendo o comportamento: substituir a expressão atual
por uma verificação simples que aceita exatamente "/api/users" (comparação com
pathSpan/pathValue usando StringComparison.OrdinalIgnoreCase) ou aplica apenas o
Regex.IsMatch para o padrão de versão (por exemplo @"^/api/v\d+/users$") contra
pathValue; ajuste o uso de pathSpan/pathValue conforme necessário para evitar
chamadas extras e preserve o nome isUserPath para clareza.
In
`@tests/MeAjudaAi.Integration.Tests/Middleware/GeographicRestrictionIntegrationTests.cs`:
- Around line 271-273: Update the assert failure message in
GeographicRestrictionIntegrationTests where
response.StatusCode.Should().Be(HttpStatusCode.UnavailableForLegalReasons, ...)
is used: change the message to explicitly state the tested condition using
separate headers (e.g., "Malformed location headers (empty X-User-State) should
be rejected") so it accurately reflects that X-User-City/X-User-State were used
and the state header was empty; locate the assertion in the test method that
builds the request with X-User-City/X-User-State and replace the current
"Malformed location header (empty state) should be rejected" text with a clearer
message referencing the empty X-User-State header.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 707ea872-cb1a-4c26-bc20-e7c50ded0de1
📒 Files selected for processing (18)
.github/workflows/ci-backend.ymlsrc/Modules/Bookings/API/Endpoints/BookingEventsEndpoint.cssrc/Modules/Bookings/Application/Events/BookingRealtimeEventsHandler.cssrc/Modules/Bookings/Tests/Unit/Application/Events/BookingRealtimeEventsHandlerTests.cssrc/Modules/Providers/API/Endpoints/ProviderVerificationEventsEndpoint.cssrc/Modules/Providers/Application/Events/ProviderVerificationStatusUpdatedSseHandler.cssrc/Modules/Providers/Tests/Unit/Application/Events/ProviderVerificationStatusUpdatedSseHandlerTests.cssrc/Modules/Users/Application/Handlers/Commands/RegisterCustomerCommandHandler.cssrc/Shared/Messaging/Options/MessageBusOptions.cssrc/Shared/Monitoring/BusinessMetricsMiddleware.cssrc/Shared/Streaming/SseHub.cssrc/Shared/Streaming/SseTopic.cssrc/Web/MeAjudaAi.Web.Customer/__tests__/components/providers/dashboard-client.test.tsxsrc/Web/MeAjudaAi.Web.Customer/__tests__/setup.tssrc/Web/MeAjudaAi.Web.Customer/hooks/use-provider-verification.tstests/MeAjudaAi.Integration.Tests/Middleware/GeographicRestrictionIntegrationTests.cstests/MeAjudaAi.Shared.Tests/Unit/Messaging/Conventions/OptionsTopicNameConventionTests.cstests/MeAjudaAi.Shared.Tests/Unit/Monitoring/BusinessMetricsMiddlewareTests.cs
✅ Files skipped from review due to trivial changes (3)
- src/Web/MeAjudaAi.Web.Customer/tests/setup.ts
- .github/workflows/ci-backend.yml
- src/Shared/Streaming/SseTopic.cs
🚧 Files skipped from review as they are similar to previous changes (5)
- src/Modules/Bookings/API/Endpoints/BookingEventsEndpoint.cs
- src/Modules/Providers/API/Endpoints/ProviderVerificationEventsEndpoint.cs
- tests/MeAjudaAi.Shared.Tests/Unit/Messaging/Conventions/OptionsTopicNameConventionTests.cs
- src/Web/MeAjudaAi.Web.Customer/hooks/use-provider-verification.ts
- src/Shared/Streaming/SseHub.cs
Owner
Author
|
@coderabbitai Uma próxima melhoria/otimização para considerar, o protocolo rpc é usado para comunicação inter modules, deveria ser considerado para uma arquitetura monolítica modular como deste projeto? Se sim, em que cenários? |
Contributor
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: Length of output: 108612
Quando faz sentido considerar RPC aqui
Quando manter como está (sem RPC)
Decisão prática (como se preparar sem pagar o custo agora)
Mini matriz de decisão
Se quiser, preparo um plano enxuto para habilitar o “dual adapter” em 1 módulo (ex.: SearchProviders): interfaces que já existem, registro DI com toggle por IOptions, e um esqueleto de RemoteAdapter Refit — totalmente aditivo e sem breaking change. 🧠 Learnings used |
… bus, monitoring, and real-time event infrastructure.
Owner
Author
|
@coderabbitai Então descartados cursor pagination e rpc no momento por adicionar complexidade e não serem necessários agora. Uma última atividade que tenho anotada no momento: revisar bru files e postman json. Todos os bru files estão criados e corretos? O poastman json está atualizado (e toda estrutura para isso está correta?) ? |
Contributor
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: Length of output: 123837
Estado atual
Correções sugeridas (Bruno)
Propostas de snippets (.bru) Bookings/StreamBookingEvents.bru get { auth:bearer { headers { docs { Stream Booking Events (SSE)Mantém uma conexão aberta e recebe eventos de status do agendamento.
Providers/StreamProviderVerificationEvents.bru get { auth:bearer { headers { docs { Stream Provider Verification Events (SSE)Recebe atualizações de verificação do prestador em tempo real. Ajuste CreateAllowedCity.bru (linha 8)
Ajustes Cancel/Confirm Booking (linhas 8/9)
Postman
Me diga se prefere:
🧠 Learnings used |
Contributor
There was a problem hiding this comment.
Actionable comments posted: 4
🧹 Nitpick comments (3)
src/Modules/Bookings/Application/Events/BookingRealtimeEventsHandler.cs (1)
21-41: Centralize as mensagens de evento SSE em constantes compartilhadasAs mensagens estão corretas, mas hoje ficam espalhadas no handler. Vale extrair para constantes compartilhadas (ex.: Contracts/Application constants) para evitar drift entre backend/web e facilitar evolução.
Based on learnings: prioritize reuse of Shared.Contracts for enums/constants to keep Web aligned with backend/shared code.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/Modules/Bookings/Application/Events/BookingRealtimeEventsHandler.cs` around lines 21 - 41, Extract all SSE message literals used in BookingRealtimeEventsHandler's HandleAsync methods (e.g., the messages passed to PublishUpdate for BookingCreated/BookingConfirmed/BookingCancelled/BookingRejected/BookingCompleted) into shared constants in the Shared.Contracts (or Contracts/Application constants) assembly, add descriptive constant names (e.g., BookingMessage_Created, BookingMessage_Confirmed, etc.), update the PublishUpdate invocations in BookingRealtimeEventsHandler to use these constants instead of raw strings, and ensure the handler imports the new shared constants so backend and web can reuse the same values.tests/MeAjudaAi.Integration.Tests/Middleware/GeographicRestrictionIntegrationTests.cs (1)
205-211: Cobertura incompleta paraX-User-Locationmalformado no teste de integração.Os casos atuais cobrem
city/statevazios, mas faltam formatos também tratados como malformados pelo middleware (sem|e com separador extra). Recomendo incluir ambos para reduzir risco de regressão.Diff sugerido
[InlineData("Muriaé|")] // City without state [InlineData("|MG")] // State without city + [InlineData("Muriaé")] // Sem separador + [InlineData("Muriaé|MG|Extra")] // Separador extra [InlineData("Muriaé| ")] // City with empty state (spaces) [InlineData(" |MG")] // Empty city (spaces) with state [InlineData("|")] // Both empty [InlineData(" | ")] // Both empty with spacesBased on learnings: MeAjudaAi: objetivo de cobertura global é ≥90% (linhas), mantendo thresholds 90/80 no CI; quando a meta estiver ameaçada, preferir excluir “glue/DTO” e adicionar testes de alto impacto.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@tests/MeAjudaAi.Integration.Tests/Middleware/GeographicRestrictionIntegrationTests.cs` around lines 205 - 211, The test GetProviders_WithMalformedLocationHeader_ShouldBeRejected is missing malformed X-User-Location formats (no '|' separator and extra separators); update the InlineData for that test in GeographicRestrictionIntegrationTests.cs (method GetProviders_WithMalformedLocationHeader_ShouldBeRejected) to include examples such as "Muriaé" (no separator), "MG" (no separator), "Muriaé||MG" (empty between separators), "Muriaé|MG|Extra" (too many separators) and an empty string "" so the middleware's parsing failure modes are covered and the assertions for rejection remain the same.src/Shared/Monitoring/BusinessMetricsMiddleware.cs (1)
56-57: Considere compilar os padrões Regex para evitar alocações no hot path.O PR visa reduzir alocações em middlewares (P0), mas
Regex.IsMatch(pathValue, pattern)recompila o padrão a cada requisição. Dado que este middleware executa em toda request, vale extrair padrões estáticos compilados como já feito comIdPatternna linha 18.♻️ Proposta de refatoração com padrões compilados
public class BusinessMetricsMiddleware( RequestDelegate next, BusinessMetrics businessMetrics, ILogger<BusinessMetricsMiddleware> logger) { private static readonly Regex IdPattern = new(@"/\d+", RegexOptions.Compiled); + private static readonly Regex VersionedUsersPattern = new(@"^/api/v\d+/users$", RegexOptions.Compiled | RegexOptions.IgnoreCase); + private static readonly Regex VersionedLoginPattern = new(@"^/api/v\d+/auth/login$", RegexOptions.Compiled | RegexOptions.IgnoreCase); + private static readonly Regex VersionedHelpRequestsPattern = new(@"^/api/v\d+/help-requests$", RegexOptions.Compiled | RegexOptions.IgnoreCase); + private static readonly Regex VersionedCompleteHelpPattern = new(@"^/api/v\d+/help-requests/[^/]+/complete$", RegexOptions.Compiled | RegexOptions.IgnoreCase); // ... private void LogBusinessEvents(HttpContext context, TimeSpan elapsed) { // ... - var isUserPath = pathSpan.Equals("/api/users", StringComparison.OrdinalIgnoreCase) || - Regex.IsMatch(pathValue, @"^/api/v\d+/users$", RegexOptions.IgnoreCase); + var isUserPath = pathSpan.Equals("/api/users", StringComparison.OrdinalIgnoreCase) || + VersionedUsersPattern.IsMatch(pathValue); - var isLoginPath = pathSpan.Equals("/api/auth/login", StringComparison.OrdinalIgnoreCase) || - (pathSpan.StartsWith("/api/v", StringComparison.OrdinalIgnoreCase) && - Regex.IsMatch(pathValue, @"^/api/v\d+/auth/login$", RegexOptions.IgnoreCase)); + var isLoginPath = pathSpan.Equals("/api/auth/login", StringComparison.OrdinalIgnoreCase) || + (pathSpan.StartsWith("/api/v", StringComparison.OrdinalIgnoreCase) && + VersionedLoginPattern.IsMatch(pathValue)); - if ((pathSpan.Equals("/api/help-requests", StringComparison.OrdinalIgnoreCase) || - Regex.IsMatch(pathValue, @"^/api/v\d+/help-requests$", RegexOptions.IgnoreCase)) && + if ((pathSpan.Equals("/api/help-requests", StringComparison.OrdinalIgnoreCase) || + VersionedHelpRequestsPattern.IsMatch(pathValue)) && - var isCompleteHelpPath = Regex.IsMatch(pathValue, @"^/api/v\d+/help-requests/[^/]+/complete$", RegexOptions.IgnoreCase); + var isCompleteHelpPath = VersionedCompleteHelpPattern.IsMatch(pathValue); } }Also applies to: 66-68, 77-78, 87-87
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/Shared/Monitoring/BusinessMetricsMiddleware.cs` around lines 56 - 57, Extraia os padrões Regex usados no hot path para campos estáticos pré-compilados na classe BusinessMetricsMiddleware (seguindo o exemplo de IdPattern) e substitua as chamadas inline Regex.IsMatch(...) por essas instâncias pré-compiladas; por exemplo, crie static readonly Regex UsersPattern = new Regex(@"^/api/v\d+/users$", RegexOptions.Compiled | RegexOptions.IgnoreCase) e use UsersPattern.IsMatch(pathValue) onde atualmente é usado isUserPath, e faça o mesmo para os outros padrões referenciados nas ocorrências atuais (linhas aproximadas onde arestas: 66-68, 77-78, 87) para evitar recompilação por requisição.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@docs/api-automation.md`:
- Around line 145-158: The section titled "Opção 2: Node.js apenas (spec +
collections)" is inconsistent because its content shows .NET commands (`dotnet
run`) and the original Node.js steps (`npm install`, `node
generate-postman-collections.js`) were removed; either update the section title
to reflect the current .NET/OpenAPI workflow or remove the section entirely and
consolidate into the main option; locate the header "Opção 2: Node.js apenas
(spec + collections)" in docs/api-automation.md and either rename it to
accurately describe the .NET/OpenAPI process or delete the block so only the
correct workflow (as described elsewhere in the docs) remains.
In
`@src/Modules/Locations/API/API.Client/AllowedCitiesAdmin/CreateAllowedCity.bru`:
- Line 8: The request URL in CreateAllowedCity.bru contains an extra "locations"
segment ("{{baseUrl}}/api/{{apiVersion}}/locations/admin/allowed-cities") which
disagrees with the module endpoints; update the route to
"{{baseUrl}}/api/{{apiVersion}}/admin/allowed-cities" wherever it appears
(including the other occurrence noted at lines ~61) so the client matches
LocationsModuleEndpoints; search for the URL template in CreateAllowedCity.bru
and replace the path to "admin/allowed-cities".
In `@src/Shared/Monitoring/BusinessMetricsMiddleware.cs`:
- Around line 86-89: The isCompleteHelpPath check currently only matches
versioned routes; add the non-versioned fallback (similar to
isUserPath/isLoginPath) by checking
pathSpan.Equals("/api/help-requests/{id}/complete",
StringComparison.OrdinalIgnoreCase) OR the existing Regex.IsMatch on pathValue
for ^/api/v\d+/help-requests/[^/]+/complete$ so both
/api/help-requests/{id}/complete and /api/v{n}/help-requests/{id}/complete are
accepted; update the isCompleteHelpPath variable accordingly and keep the
existing POST + successful statusCode branch untouched.
In `@src/Web/e2e/support/mocks.ts`:
- Around line 163-184: The mock response in src/Web/e2e/support/mocks.ts
currently wraps the provider payload in an extra "data" causing a data.data
shape and placing success/error inside that nested object; fix it by flattening
the envelope so the mock returns an object with top-level keys { data: { id,
name, ... }, success: true, error: null } (i.e., remove the outer "data"
wrapper), updating the mocked provider response object where the nested "data"
property is defined to eliminate the double nesting and keep "success" and
"error" as siblings of "data".
---
Nitpick comments:
In `@src/Modules/Bookings/Application/Events/BookingRealtimeEventsHandler.cs`:
- Around line 21-41: Extract all SSE message literals used in
BookingRealtimeEventsHandler's HandleAsync methods (e.g., the messages passed to
PublishUpdate for
BookingCreated/BookingConfirmed/BookingCancelled/BookingRejected/BookingCompleted)
into shared constants in the Shared.Contracts (or Contracts/Application
constants) assembly, add descriptive constant names (e.g.,
BookingMessage_Created, BookingMessage_Confirmed, etc.), update the
PublishUpdate invocations in BookingRealtimeEventsHandler to use these constants
instead of raw strings, and ensure the handler imports the new shared constants
so backend and web can reuse the same values.
In `@src/Shared/Monitoring/BusinessMetricsMiddleware.cs`:
- Around line 56-57: Extraia os padrões Regex usados no hot path para campos
estáticos pré-compilados na classe BusinessMetricsMiddleware (seguindo o exemplo
de IdPattern) e substitua as chamadas inline Regex.IsMatch(...) por essas
instâncias pré-compiladas; por exemplo, crie static readonly Regex UsersPattern
= new Regex(@"^/api/v\d+/users$", RegexOptions.Compiled |
RegexOptions.IgnoreCase) e use UsersPattern.IsMatch(pathValue) onde atualmente é
usado isUserPath, e faça o mesmo para os outros padrões referenciados nas
ocorrências atuais (linhas aproximadas onde arestas: 66-68, 77-78, 87) para
evitar recompilação por requisição.
In
`@tests/MeAjudaAi.Integration.Tests/Middleware/GeographicRestrictionIntegrationTests.cs`:
- Around line 205-211: The test
GetProviders_WithMalformedLocationHeader_ShouldBeRejected is missing malformed
X-User-Location formats (no '|' separator and extra separators); update the
InlineData for that test in GeographicRestrictionIntegrationTests.cs (method
GetProviders_WithMalformedLocationHeader_ShouldBeRejected) to include examples
such as "Muriaé" (no separator), "MG" (no separator), "Muriaé||MG" (empty
between separators), "Muriaé|MG|Extra" (too many separators) and an empty string
"" so the middleware's parsing failure modes are covered and the assertions for
rejection remain the same.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 0649313e-12c6-49d3-a6d1-45e5b0864601
⛔ Files ignored due to path filters (1)
tools/api-collections/package-lock.jsonis excluded by!**/package-lock.json,!**/package-lock.json
📒 Files selected for processing (20)
docs/api-automation.mddocs/architecture.mdsrc/Modules/Bookings/API/API.Client/Bookings/CancelBooking.brusrc/Modules/Bookings/API/API.Client/Bookings/ConfirmBooking.brusrc/Modules/Bookings/API/API.Client/Bookings/StreamBookingEvents.brusrc/Modules/Bookings/Application/Events/BookingRealtimeEventsHandler.cssrc/Modules/Bookings/Tests/Unit/Application/Events/BookingRealtimeEventsHandlerTests.cssrc/Modules/Locations/API/API.Client/AllowedCitiesAdmin/CreateAllowedCity.brusrc/Modules/Providers/API/API.Client/ProviderAdmin/StreamProviderVerificationEvents.brusrc/Modules/Providers/Tests/Unit/Application/Events/ProviderVerificationStatusUpdatedSseHandlerTests.cssrc/Modules/Users/Application/Handlers/Commands/RegisterCustomerCommandHandler.cssrc/Shared/Messaging/Options/MessageBusOptions.cssrc/Shared/Monitoring/BusinessMetricsMiddleware.cssrc/Web/e2e/support/mocks.tstests/MeAjudaAi.Integration.Tests/Middleware/GeographicRestrictionIntegrationTests.cstests/MeAjudaAi.Shared.Tests/Unit/Monitoring/BusinessMetricsMiddlewareTests.cstools/api-collections/README.mdtools/api-collections/generate-all-collections.battools/api-collections/generate-postman-collections.jstools/api-collections/package.json
💤 Files with no reviewable changes (4)
- tools/api-collections/package.json
- tools/api-collections/generate-all-collections.bat
- tools/api-collections/generate-postman-collections.js
- tools/api-collections/README.md
✅ Files skipped from review due to trivial changes (4)
- src/Modules/Bookings/API/API.Client/Bookings/CancelBooking.bru
- src/Modules/Bookings/API/API.Client/Bookings/StreamBookingEvents.bru
- src/Modules/Providers/API/API.Client/ProviderAdmin/StreamProviderVerificationEvents.bru
- src/Modules/Users/Application/Handlers/Commands/RegisterCustomerCommandHandler.cs
🚧 Files skipped from review as they are similar to previous changes (3)
- tests/MeAjudaAi.Shared.Tests/Unit/Monitoring/BusinessMetricsMiddlewareTests.cs
- src/Modules/Bookings/Tests/Unit/Application/Events/BookingRealtimeEventsHandlerTests.cs
- src/Modules/Providers/Tests/Unit/Application/Events/ProviderVerificationStatusUpdatedSseHandlerTests.cs
added 2 commits
April 29, 2026 16:00
…, and associated API documentation and tests.
…der, and customer roles
frigini
force-pushed
the
feature/extra-implementations-minimize-tech-debts
branch
from
35fa6aa to
776c2d1
Compare
added 2 commits
April 29, 2026 16:44
- Add mock for port 7002 (default Provider API port) - Add console debug logging to auth.ts - Skip provider dashboard test due to React hooks ordering issue in useProviderVerificationEvents
- Replace empty string test case with special NOTSET marker - HttpClient removes empty headers, so proper test is not possible - Different test logic for missing header (fail-open) vs malformed header (reject)
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/Modules/Locations/API/API.Client/AllowedCitiesAdmin/GetAllAllowedCities.bru (1)
8-15:⚠️ Potential issue | 🟡 MinorEvite duplicar o
onlyActivena URL e no bloco de query params.Hoje o request define
onlyActiveem Line 8 e novamente nas Lines 13-15. Deixe em um único lugar para evitar ambiguidade.🔧 Ajuste sugerido
-get { - url: {{baseUrl}}/api/{{apiVersion}}/admin/allowed-cities?onlyActive=true +get { + url: {{baseUrl}}/api/{{apiVersion}}/admin/allowed-cities body: none auth: bearer }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/Modules/Locations/API/API.Client/AllowedCitiesAdmin/GetAllAllowedCities.bru` around lines 8 - 15, A requisição está duplicando o parâmetro onlyActive tanto na linha do url quanto no bloco params:query; remova a ocorrência no url (linha com "url: {{baseUrl}}/api/{{apiVersion}}/admin/allowed-cities?onlyActive=true") e deixe apenas o parâmetro declarado em params:query { onlyActive: true } para evitar ambiguidade e garantir que o valor seja controlado pelo bloco de query params.
♻️ Duplicate comments (1)
src/Modules/Locations/API/API.Client/AllowedCitiesAdmin/CreateAllowedCity.bru (1)
61-61:⚠️ Potential issue | 🟡 MinorAtualize o
Locationdocumentado para não ficar preso emv1.Em Line 61, a documentação ainda mostra
/api/v1/admin/allowed-cities/{id}, divergindo da rota versionada usada em Line 8.🔧 Ajuste sugerido
- Header `Location`: `/api/v1/admin/allowed-cities/{id}` + Header `Location`: `/api/{{apiVersion}}/admin/allowed-cities/{id}`🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/Modules/Locations/API/API.Client/AllowedCitiesAdmin/CreateAllowedCity.bru` at line 61, The documented Header `Location` currently hardcodes `/api/v1/admin/allowed-cities/{id}`; update it to match the versioned route used in the file's route declaration (the same version segment used in the route at the top of the file) so the Location header is not stuck on `v1`—replace the hardcoded path with the same versioned path/token used by the route declaration to ensure consistency for the allowed-cities endpoint.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/Web/e2e/provider/portal.spec.ts`:
- Around line 17-27: The test was disabled with test.skip which hides
regressions; replace test.skip with test.fixme (include the tracking issue ID in
the test title) if it truly must remain disabled, otherwise re-enable the test
and remove the fixed sleep (the waitForTimeout) by switching to locator-based
waits and assertions: after page.waitForLoadState(...) use page.locator(...)
(e.g., the element that would show "Provider Test") and call locator.waitFor or
Playwright expects (toHaveText/toBeVisible) to assert presence; also check for
hooks-related failures by mounting the component that uses
useProviderVerificationEvents/useSse/useSession in a test harness or mocking
those hooks so the E2E flow can run reliably.
In `@src/Web/e2e/support/auth.ts`:
- Around line 17-27: The current setup reads page.url() into testBaseUrl (in
setupPageForE2E) before navigation which yields "about:blank" and then injects
that into process.env.NEXT_PUBLIC_API_URL via page.addInitScript; change the
addInitScript callback to compute the API URL at runtime using
window.location.origin (and assign that to (window as
any).process.env.NEXT_PUBLIC_API_URL) instead of passing testBaseUrl, so the env
is set correctly after navigation and SSE/API requests use the real origin.
---
Outside diff comments:
In
`@src/Modules/Locations/API/API.Client/AllowedCitiesAdmin/GetAllAllowedCities.bru`:
- Around line 8-15: A requisição está duplicando o parâmetro onlyActive tanto na
linha do url quanto no bloco params:query; remova a ocorrência no url (linha com
"url: {{baseUrl}}/api/{{apiVersion}}/admin/allowed-cities?onlyActive=true") e
deixe apenas o parâmetro declarado em params:query { onlyActive: true } para
evitar ambiguidade e garantir que o valor seja controlado pelo bloco de query
params.
---
Duplicate comments:
In
`@src/Modules/Locations/API/API.Client/AllowedCitiesAdmin/CreateAllowedCity.bru`:
- Line 61: The documented Header `Location` currently hardcodes
`/api/v1/admin/allowed-cities/{id}`; update it to match the versioned route used
in the file's route declaration (the same version segment used in the route at
the top of the file) so the Location header is not stuck on `v1`—replace the
hardcoded path with the same versioned path/token used by the route declaration
to ensure consistency for the allowed-cities endpoint.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: a8aeb4ba-7cf5-4484-896a-42e1e4fd1898
📒 Files selected for processing (14)
docs/api-automation.mddocs/roadmap.mdsrc/Modules/Bookings/Application/Constants/BookingSseMessages.cssrc/Modules/Bookings/Application/Events/BookingRealtimeEventsHandler.cssrc/Modules/Locations/API/API.Client/AllowedCitiesAdmin/CreateAllowedCity.brusrc/Modules/Locations/API/API.Client/AllowedCitiesAdmin/DeleteAllowedCity.brusrc/Modules/Locations/API/API.Client/AllowedCitiesAdmin/GetAllAllowedCities.brusrc/Modules/Locations/API/API.Client/AllowedCitiesAdmin/GetAllowedCityById.brusrc/Modules/Locations/API/API.Client/AllowedCitiesAdmin/UpdateAllowedCity.brusrc/Shared/Monitoring/BusinessMetricsMiddleware.cssrc/Web/e2e/provider/portal.spec.tssrc/Web/e2e/support/auth.tssrc/Web/e2e/support/mocks.tstests/MeAjudaAi.Integration.Tests/Middleware/GeographicRestrictionIntegrationTests.cs
💤 Files with no reviewable changes (1)
- docs/api-automation.md
✅ Files skipped from review due to trivial changes (1)
- src/Modules/Bookings/Application/Events/BookingRealtimeEventsHandler.cs
🚧 Files skipped from review as they are similar to previous changes (3)
- src/Web/e2e/support/mocks.ts
- docs/roadmap.md
- src/Shared/Monitoring/BusinessMetricsMiddleware.cs
- Replace test.skip with test.fixme with tracking note for provider dashboard
- Use window.location.origin in auth.ts for runtime API URL
- Remove duplicate onlyActive param in GetAllAllowedCities.bru URL
- Use {{apiVersion}} variable in CreateAllowedCity.bru Location header
✅ Contrato da API ValidadoNenhuma breaking change detectada pelo |
Code Coverage Report
|
Minimum allowed line rate is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit