Skip to content

πŸ“ CodeRabbit Chat: Implement requested code changes#218

Merged
frigini merged 9 commits intomasterfrom
coderabbitai/chat/d264a38
Apr 29, 2026
Merged

πŸ“ CodeRabbit Chat: Implement requested code changes#218
frigini merged 9 commits intomasterfrom
coderabbitai/chat/d264a38

Conversation

@coderabbitai
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot commented Apr 29, 2026

Code changes was requested by @frigini.

The following files were modified:

  • src/Modules/Bookings/Infrastructure/Persistence/Configurations/BookingConfiguration.cs
  • src/Modules/Providers/Infrastructure/Persistence/Configurations/ProviderConfiguration.cs

@coderabbitai
Copy link
Copy Markdown
Contributor Author

coderabbitai Bot commented Apr 29, 2026

Important

Review skipped

This PR was authored by the user configured for CodeRabbit reviews. CodeRabbit does not review PRs authored by this user. It's recommended to use a dedicated user account to post CodeRabbit review feedback.

βš™οΈ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 06853794-7638-495e-8725-6d214d58a541

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • πŸ” Trigger review

Comment @coderabbitai help to get the list of available commands and usage tips.

Base automatically changed from feature/extra-implementations-minimize-tech-debts to master April 29, 2026 20:47
@frigini
Copy link
Copy Markdown
Owner

frigini commented Apr 29, 2026

@coderabbitai ainda necessΓ‘rio este PR?

@coderabbitai
Copy link
Copy Markdown
Contributor Author

coderabbitai Bot commented Apr 29, 2026

Tip

For best results, initiate chat on the files or code changes.

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Check PR `#218` details and its diff
gh pr view 218 --repo frigini/MeAjudaAi

echo "---DIFF---"
gh pr diff 218 --repo frigini/MeAjudaAi

echo "---PR 215 comment---"
gh api repos/frigini/MeAjudaAi/issues/comments/4344011079

Length of output: 61745


@frigini: Este PR comeΓ§ou como implementaΓ§Γ£o dos Γ­ndices compostos para BookingConfiguration e ProviderConfiguration (solicitados em #215), mas cresceu bastante e agora inclui dois grupos de mudanΓ§as distintos:


1. πŸ“Œ AlteraΓ§Γ΅es originais solicitadas

  • BookingConfiguration.cs β†’ 3 Γ­ndices compostos nomeados (ix_bookings_provider_date_status, ix_bookings_client_date, ix_bookings_provider_date)
  • ProviderConfiguration.cs β†’ 4 Γ­ndices compostos com filtro partial (ix_providers_deleted_*)

2. πŸš€ Sprint 13.1 β€” Performance Zero-Allocation (nΓ£o solicitado originalmente)

RefatoraΓ§Γ΅es com Span<T> / ReadOnlySpan<char> em vΓ‘rios arquivos:

  • GeographicRestrictionMiddleware, RequestLoggingMiddleware, PermissionOptimizationMiddleware, BusinessMetricsMiddleware
  • RegisterCustomerCommandHandler, KeycloakService
  • DocumentExtensions, PiiMaskingHelper, PhoneNumberValidator, CacheMetrics
  • MessagingExtensions + nova classe OptionsTopicNameConvention (fix de convenΓ§Γ£o de tΓ³pico)
  • Docs (roadmap.md, roadmap-history.md, technical-debt.md), CI (pin azurite:3.33.0) e novos testes

Resumo: o PR ainda Γ© necessΓ‘rio se vocΓͺ quiser os Γ­ndices compostos e/ou as otimizaΓ§Γ΅es de zero-allocation. Caso jΓ‘ tenha incorporado parte dessas mudanΓ§as em outra branch, posso fechar este PR. O que prefere?


🧠 Learnings used
Learnt from: frigini
Repo: frigini/MeAjudaAi PR: 0
File: :0-0
Timestamp: 2026-01-16T21:50:23.593Z
Learning: For frigini/MeAjudaAi Web reviews, prefer commit-by-commit (newest-first) with concise verdicts and concrete follow-ups; prioritize reuse of Shared.Contracts for enums/constants to keep Web aligned with backend/shared code.

Learnt from: frigini
Repo: frigini/MeAjudaAi PR: 0
File: :0-0
Timestamp: 2026-04-20T22:04:25.820Z
Learning: MeAjudaAi (PRs futuros): para cobertura global, NÃO excluir *Configuration e *Extensions (hÑ smoke tests exercitando-os); também não excluir *.Monitoring.*, MeAjudaAi.Shared.Jobs.* e MeAjudaAi.Shared.Mediator.*. Manter excluídos apenas Request/Response/Dto/DTO/IntegrationEvent e *DbContextFactory; Endpoints podem ficar excluídos globalmente, a menos que sejam white-listados por módulo com E2E (ex.: +MeAjudaAi.Modules.Payments.API.*Endpoint; -*Endpoint).

Learnt from: frigini
Repo: frigini/MeAjudaAi PR: 77
File: src/Modules/Providers/Tests/Unit/Application/Queries/GetProvidersByIdsQueryTests.cs:65-77
Timestamp: 2025-12-18T00:35:33.829Z
Learning: MeAjudaAi repo: ExceΓ§Γ£o Γ  polΓ­tica de idioma para comentΓ‘rios β€” em testes, os cabeΓ§alhos AAA (Arrange, Act, Assert) devem permanecer em inglΓͺs e nΓ£o devem ser traduzidos. ComentΓ‘rios/XML continuam em portuguΓͺs; logs em inglΓͺs; mensagens ao usuΓ‘rio (validaΓ§Γ΅es/APIs) em portuguΓͺs.

Learnt from: frigini
Repo: frigini/MeAjudaAi PR: 0
File: :0-0
Timestamp: 2026-04-24T20:02:36.451Z
Learning: MeAjudaAi Shared coverage: Classes de infraestrutura de messaging que dependem de broker RabbitMQ real (RabbitMqDeadLetterService, DeadLetterExtensions, FailedMessageInfo, FailureAttempt, EnvironmentMetadata) sΓ£o candidatas a [ExcludeFromCodeCoverage] pois nΓ£o sΓ£o testΓ‘veis unitariamente. UtilitΓ‘rios puros (PhoneNumberValidator, PiiMaskingHelper, SlugHelper, UuidGenerator) devem ter testes unitΓ‘rios adicionados em vez de serem excluΓ­dos.

@frigini frigini merged commit faee8f2 into master Apr 29, 2026
@frigini frigini deleted the coderabbitai/chat/d264a38 branch April 29, 2026 21:11
@github-actions
Copy link
Copy Markdown

βœ… Contrato da API Validado

Nenhuma breaking change detectada pelo oasdiff em relaΓ§Γ£o Γ  branch base.

@github-actions
Copy link
Copy Markdown

Code Coverage Report

Code Coverage

Project Package Line Rate Branch Rate Health
MeAjudaAi.Web.Admin components/layout 73% 64% βž–
MeAjudaAi.Web.Admin components/providers 93% 92% βœ”
MeAjudaAi.Web.Admin components/ui 100% 86% βœ”
MeAjudaAi.Web.Admin hooks/admin 95% 79% βœ”
MeAjudaAi.Web.Admin lib 100% 100% βœ”
MeAjudaAi.Web.Admin Summary 94% (256 / 272) 80% (118 / 147) -
MeAjudaAi.Web.Customer components/auth 62% 57% βž–
MeAjudaAi.Web.Customer components/bookings 72% 61% βž–
MeAjudaAi.Web.Customer components/home 100% 100% βœ”
MeAjudaAi.Web.Customer components/layout 63% 36% βž–
MeAjudaAi.Web.Customer components/profile 93% 94% βœ”
MeAjudaAi.Web.Customer components/providers 62% 63% βž–
MeAjudaAi.Web.Customer components/reviews 64% 70% βž–
MeAjudaAi.Web.Customer components/search 88% 70% βœ”
MeAjudaAi.Web.Customer components/service 100% 100% βœ”
MeAjudaAi.Web.Customer components/ui 97% 97% βœ”
MeAjudaAi.Web.Customer hooks 70% 52% βž–
MeAjudaAi.Web.Customer lib 100% 100% βœ”
MeAjudaAi.Web.Customer lib/api 83% 80% βœ”
MeAjudaAi.Web.Customer lib/constants 100% 100% βœ”
MeAjudaAi.Web.Customer lib/schemas 92% 80% βœ”
MeAjudaAi.Web.Customer lib/services 94% 86% βœ”
MeAjudaAi.Web.Customer lib/utils 77% 90% βž–
MeAjudaAi.Web.Customer Summary 77% (731 / 945) 71% (631 / 878) -
MeAjudaAi.Web.Provider root 53% 36% ❌
MeAjudaAi.Web.Provider components/dashboard 73% 52% βž–
MeAjudaAi.Web.Provider components/layout 100% 100% βœ”
MeAjudaAi.Web.Provider components/profile 100% 100% βœ”
MeAjudaAi.Web.Provider components/providers 100% 100% βœ”
MeAjudaAi.Web.Provider components/ui 100% 90% βœ”
MeAjudaAi.Web.Provider hooks 0% 0% ❌
MeAjudaAi.Web.Provider lib 100% 100% βœ”
MeAjudaAi.Web.Provider lib/api 100% 93% βœ”
MeAjudaAi.Web.Provider lib/constants 100% 100% βœ”
MeAjudaAi.Web.Provider lib/schemas 87% 75% βœ”
MeAjudaAi.Web.Provider lib/services 100% 100% βœ”
MeAjudaAi.Web.Provider lib/utils 96% 98% βœ”
MeAjudaAi.Web.Provider Summary 75% (314 / 416) 73% (366 / 499) -
Overall Summary 79% (1301 / 1633) 73% (1115 / 1524) -

@github-actions
Copy link
Copy Markdown

Code Coverage

Package Line Rate Branch Rate Complexity Health
MeAjudaAi.ApiService 96% 80% 393 βž–
MeAjudaAi.Modules.Bookings.Application 91% 83% 217 βž–
MeAjudaAi.Modules.Bookings.Domain 97% 98% 68 βž–
MeAjudaAi.Modules.Bookings.Infrastructure 96% 39% 37 βž–
MeAjudaAi.Modules.Communications.API 100% 100% 4 βœ”
MeAjudaAi.Modules.Communications.Application 89% 69% 206 ❌
MeAjudaAi.Modules.Communications.Domain 100% 100% 17 βœ”
MeAjudaAi.Modules.Communications.Infrastructure 92% 57% 59 βž–
MeAjudaAi.Modules.Documents.API 100% 100% 3 βœ”
MeAjudaAi.Modules.Documents.Application 86% 72% 191 ❌
MeAjudaAi.Modules.Documents.Domain 99% 100% 29 βž–
MeAjudaAi.Modules.Documents.Infrastructure 88% 76% 164 ❌
MeAjudaAi.Modules.Locations.API 100% 100% 11 βœ”
MeAjudaAi.Modules.Locations.Application 94% 95% 70 βž–
MeAjudaAi.Modules.Locations.Domain 95% 82% 127 βž–
MeAjudaAi.Modules.Locations.Infrastructure 92% 75% 225 βž–
MeAjudaAi.Modules.Payments.API 100% 100% 3 βœ”
MeAjudaAi.Modules.Payments.Application 97% 92% 55 βž–
MeAjudaAi.Modules.Payments.Domain 95% 86% 105 βž–
MeAjudaAi.Modules.Payments.Infrastructure 90% 71% 169 βž–
MeAjudaAi.Modules.Providers.API 100% 100% 17 βœ”
MeAjudaAi.Modules.Providers.Application 92% 82% 277 βž–
MeAjudaAi.Modules.Providers.Domain 94% 87% 285 βž–
MeAjudaAi.Modules.Providers.Infrastructure 94% 75% 88 βž–
MeAjudaAi.Modules.Ratings.Application 91% 100% 14 βž–
MeAjudaAi.Modules.Ratings.Domain 98% 100% 24 βž–
MeAjudaAi.Modules.Ratings.Infrastructure 90% 75% 23 βž–
MeAjudaAi.Modules.SearchProviders.API 100% 100% 2 βœ”
MeAjudaAi.Modules.SearchProviders.Application 94% 73% 36 βž–
MeAjudaAi.Modules.SearchProviders.Domain 99% 82% 48 βž–
MeAjudaAi.Modules.SearchProviders.Infrastructure 92% 89% 59 βž–
MeAjudaAi.Modules.ServiceCatalogs.API 100% 100% 3 βœ”
MeAjudaAi.Modules.ServiceCatalogs.Application 98% 97% 170 βž–
MeAjudaAi.Modules.ServiceCatalogs.Domain 98% 93% 60 βž–
MeAjudaAi.Modules.ServiceCatalogs.Infrastructure 100% 78% 56 βž–
MeAjudaAi.Modules.Users.API 98% 83% 13 βž–
MeAjudaAi.Modules.Users.Application 94% 91% 203 βž–
MeAjudaAi.Modules.Users.Domain 95% 95% 139 βž–
MeAjudaAi.Modules.Users.Infrastructure 82% 59% 196 ❌
MeAjudaAi.Shared 80% 78% 1383 ❌
Summary 90% (14067 / 15611) 80% (3428 / 4282) 5249 βž–

Minimum allowed line rate is 90%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant