Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: "perf: introduce size hint for storage ... (#695)" #696

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

MrCroxx
Copy link
Collaborator

@MrCroxx MrCroxx commented Sep 9, 2024

What's changed and what's your intention?

Please explain IN DETAIL what the changes are in this PR and why they are needed. :D

This reverts commit 260ef14.

Tried with RisingWave. Not a good abstraction, revert.

Checklist

  • I have written the necessary rustdoc comments
  • I have added the necessary unit tests and integration tests
  • I have passed make all (or make fast instead if the old tests are not modified) in my local environment.

Related issues or PRs (optional)

#694

@MrCroxx MrCroxx added this to the v0.11 milestone Sep 9, 2024
@MrCroxx MrCroxx self-assigned this Sep 9, 2024
@MrCroxx MrCroxx enabled auto-merge (squash) September 9, 2024 10:13
@MrCroxx MrCroxx changed the title Revert "perf: introduce size hint for storage key and value (#695)" revert: "perf: introduce size hint for storage ... (#695)" Sep 9, 2024
@MrCroxx MrCroxx merged commit 22043fc into main Sep 9, 2024
19 checks passed
@MrCroxx MrCroxx deleted the revert-695-xx/hint branch September 9, 2024 10:18
Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
foyer-storage/src/serde.rs 100.00% <ø> (ø)
foyer-storage/src/store.rs 74.72% <100.00%> (-0.08%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant