Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: introduce size hint for storage key and value #695

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Conversation

MrCroxx
Copy link
Collaborator

@MrCroxx MrCroxx commented Sep 9, 2024

What's changed and what's your intention?

Please explain IN DETAIL what the changes are in this PR and why they are needed. :D

As title.

Checklist

  • I have written the necessary rustdoc comments
  • I have added the necessary unit tests and integration tests
  • I have passed make all (or make fast instead if the old tests are not modified) in my local environment.

Related issues or PRs (optional)

close #694

@MrCroxx MrCroxx added feature New feature or request perf Performance optimization labels Sep 9, 2024
@MrCroxx MrCroxx added this to the v0.11 milestone Sep 9, 2024
@MrCroxx MrCroxx self-assigned this Sep 9, 2024
Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
foyer-common/src/code.rs 100.00% <100.00%> (ø)
foyer-storage/src/serde.rs 100.00% <100.00%> (ø)
foyer-storage/src/store.rs 74.79% <100.00%> (+0.34%) ⬆️

... and 1 file with indirect coverage changes

@MrCroxx MrCroxx merged commit 260ef14 into main Sep 9, 2024
22 checks passed
@MrCroxx MrCroxx deleted the xx/hint branch September 9, 2024 08:55
MrCroxx added a commit that referenced this pull request Sep 9, 2024
MrCroxx added a commit that referenced this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request perf Performance optimization
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

perf: support size_hint for StorageKey and StorageValue
1 participant