Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: support size_hint for StorageKey and StorageValue #694

Closed
MrCroxx opened this issue Sep 9, 2024 · 1 comment · Fixed by #695
Closed

perf: support size_hint for StorageKey and StorageValue #694

MrCroxx opened this issue Sep 9, 2024 · 1 comment · Fixed by #695
Assignees
@MrCroxx
Labels
feature New feature or request perf Performance optimization
Milestone
Won't Fix

Comments

@MrCroxx
Copy link
Collaborator

MrCroxx commented Sep 9, 2024

Currently the entry is serialized into a new created IoBytesMut without any size hint, which may cause high page fault overhead.
@MrCroxx MrCroxx added feature New feature or request perf Performance optimization labels Sep 9, 2024
@MrCroxx MrCroxx added this to the v0.11 milestone Sep 9, 2024
@MrCroxx MrCroxx self-assigned this Sep 9, 2024
@MrCroxx MrCroxx mentioned this issue Sep 9, 2024
Merged
3 tasks
@MrCroxx MrCroxx mentioned this issue Sep 9, 2024
Merged
3 tasks
@MrCroxx MrCroxx reopened this Sep 9, 2024
@MrCroxx MrCroxx mentioned this issue Sep 9, 2024
Merged
3 tasks
@MrCroxx
Copy link
Collaborator Author

MrCroxx commented Sep 20, 2024

No needs after using bincode default serialized size as estimated.

@MrCroxx MrCroxx closed this as not planned Won't fix, can't repro, duplicate, stale Sep 20, 2024
@MrCroxx MrCroxx modified the milestones: v0.11, Won't Fix Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MrCroxx MrCroxx

Labels
feature New feature or request perf Performance optimization
Projects
foyer - Development Roadmap
Status: Done
Milestone
Won't Fix
Development

Successfully merging a pull request may close this issue.

perf: introduce size hint for storage key and value foyer-rs/foyer
1 participant
@MrCroxx