Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: use size hint on serde #697

Merged
merged 5 commits into from
Sep 12, 2024
Merged

perf: use size hint on serde #697

merged 5 commits into from
Sep 12, 2024

Conversation

MrCroxx
Copy link
Collaborator

@MrCroxx MrCroxx commented Sep 9, 2024

What's changed and what's your intention?

Please explain IN DETAIL what the changes are in this PR and why they are needed. :D

As title. To reduce buffer growing.

Checklist

  • I have written the necessary rustdoc comments
  • I have added the necessary unit tests and integration tests
  • I have passed make all (or make fast instead if the old tests are not modified) in my local environment.

Related issues or PRs (optional)

#694

@MrCroxx MrCroxx added the perf Performance optimization label Sep 9, 2024
@MrCroxx MrCroxx added this to the v0.11 milestone Sep 9, 2024
@MrCroxx MrCroxx self-assigned this Sep 9, 2024
Copy link

codecov bot commented Sep 9, 2024

Codecov Report

Attention: Patch coverage is 95.00000% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
foyer-storage/src/serde.rs 94.73% 1 Missing ⚠️
Files with missing lines Coverage Δ
foyer-storage/src/store.rs 74.72% <100.00%> (ø)
foyer-storage/src/serde.rs 96.42% <94.73%> (-3.58%) ⬇️

@MrCroxx
Copy link
Collaborator Author

MrCroxx commented Sep 12, 2024

image

LGTM

@MrCroxx MrCroxx merged commit a9d957b into main Sep 12, 2024
22 checks passed
@MrCroxx MrCroxx deleted the xx/hint branch September 12, 2024 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
perf Performance optimization
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants