fix: Add server checks for ticket price

[mrsaicharan1]

Fixes #6280

Short description of what this resolves:

Adds api checks for ticket prices on the server

Changes proposed in this pull request:

• Added check at before_create_object & before_update_object

Checklist

• I have read the Contribution & Best practices Guide and my PR follows them.
• My branch is up-to-date with the Upstream development branch.
• The unit tests pass locally with my changes
• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation (if appropriate)

• All the functions created/modified in this PR contain relevant docstrings.

[codecov]

Codecov Report

Merging #6281 into development will decrease coverage by 0.02%.
The diff coverage is 12.5%.

@@               Coverage Diff               @@
##           development    #6281      +/-   ##
===============================================
- Coverage        65.42%   65.39%   -0.03%     
===============================================
  Files              287      287              
  Lines            14727    14735       +8     
===============================================
+ Hits              9635     9636       +1     
- Misses            5092     5099       +7

Impacted Files	Coverage Δ
app/api/tickets.py	45.13% <12.5%> (-2.49%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 250b920...2c57240. Read the comment docs.

[mrsaicharan1]

@shreyanshdwivedi @iamareebjamal @uds5501 Please have a look.

[shreyanshdwivedi]

LGTM 👍

[iamareebjamal]

:l

[iamareebjamal]

Build failing

[mrsaicharan1]

@iamareebjamal The DELETE test for the tickets was failing as the price & type are not required for a DELETE request. Any suggestions on how I could go about this?

[mrsaicharan1]

According to me, I think that that the condition

if not data.get('price') or not data.get('type'):
        raise UnprocessableEntity({}, "Type/price of ticket is missing")

should only be present under before_create_object as the updation of a ticket might not always involve type and price. What do you think? @uds5501 @shreyanshdwivedi
@iamareebjamal

[shreyanshdwivedi]

I agree @mrsaicharan1
Someone can update only name or any other attribute and this check will create error

[mrsaicharan1]

@iamareebjamal @uds5501 @shreyanshdwivedi Fixed the check to be compatible with the DELETE operation as well. Ready for another review.

[mrsaicharan1]

@iamareebjamal This fix seems to be buggy with donation tickets. I will revert this for now and see what's wrong.