Skip to content

Commit f2320ee

Browse files
committed
Moved common check to function
1 parent aa0359b commit f2320ee

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

app/api/tickets.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,8 @@
2222

2323

2424
def validate_ticket_price(ticket_type, price):
25+
if not data.get('price') and data.get('type'):
26+
raise UnprocessableEntity({}, "Type/price of ticket is missing")
2527
if ticket_type != 'free' and int(price) <= 0:
2628
raise UnprocessableEntity(
2729
{'price': price}, "Price of a paid/donation ticket must be greater than zero")
@@ -189,8 +191,7 @@ def before_update_object(self, ticket, data, view_kwargs):
189191
if not event.is_payment_enabled():
190192
raise UnprocessableEntity(
191193
{'event_id': ticket.event.id}, "Event having paid ticket must have a payment method")
192-
if data.get('price') and data.get('type'):
193-
validate_ticket_price(data.get('type'), data.get('price'))
194+
validate_ticket_price(data.get('type'), data.get('price'))
194195

195196
decorators = (api.has_permission('is_coorganizer', fetch='event_id',
196197
fetch_as="event_id", model=Ticket, methods="PATCH,DELETE"),)

0 commit comments

Comments
 (0)