Skip to content

Conversation

@ashutosh1919
Copy link

@ashutosh1919 ashutosh1919 commented Aug 1, 2019

Fixes #6280

Short description of what this resolves:

Added two lines of snippets of if conditions in two functions to check the price and raise error.

Changes proposed in this pull request:

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.

@shreyanshdwivedi
Copy link
Member

shreyanshdwivedi commented Aug 1, 2019

@ashutosh1919 there is already a PR for the issue you mentioned - #6281
Closing this one

@codecov
Copy link

codecov bot commented Aug 1, 2019

Codecov Report

Merging #6289 into development will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #6289      +/-   ##
===============================================
- Coverage        65.54%   65.52%   -0.02%     
===============================================
  Files              286      286              
  Lines            14589    14593       +4     
===============================================
  Hits              9562     9562              
- Misses            5027     5031       +4
Impacted Files Coverage Δ
app/api/tickets.py 45.87% <0%> (-1.75%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fc0c20...12d890a. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Server checks for ticket prices are missing

2 participants