Skip to content

Conversation

@maze-runnar
Copy link
Contributor

@maze-runnar maze-runnar commented Oct 29, 2021

Fixes #7985
Fixes #8005
Fixes #8004

Short description of what this resolves:

Screenshot from 2021-10-29 08-21-55

Screenshot from 2021-10-30 09-21-39

Screenshot from 2021-10-30 09-04-43

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@auto-label auto-label bot added the fix label Oct 29, 2021
@vercel
Copy link

vercel bot commented Oct 29, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/A8MyLtQThxJAppFjZJqFejgj5FKn
✅ Preview: https://open-event-frontend-git-fork-maze-runnar-group-card-eventyay.vercel.app

@codecov
Copy link

codecov bot commented Oct 29, 2021

Codecov Report

Merging #8002 (4b8f136) into development (d6b67b5) will decrease coverage by 0.08%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #8002      +/-   ##
===============================================
- Coverage        18.65%   18.56%   -0.09%     
===============================================
  Files              619      619              
  Lines             7369     7410      +41     
  Branches           149      149              
===============================================
+ Hits              1375     1376       +1     
- Misses            5966     6006      +40     
  Partials            28       28              
Impacted Files Coverage Δ
app/components/promoted-group-card.js 0.00% <0.00%> (ø)
app/controllers/public/index.js 5.08% <0.00%> (-1.33%) ⬇️
...mponents/forms/events/view/create-discount-code.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6b67b5...4b8f136. Read the comment docs.

Copy link
Member

@pavnesh-c pavnesh-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

We may want to slice the group.about to lesser characters. Its 100 now.

Copy link
Member

@mariobehling mariobehling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thumbnail image are not displayed. Events have their thumbnails, but groups do not show them.

@maze-runnar
Copy link
Contributor Author

Screenshot from 2021-10-30 07-19-35

@maze-runnar
Copy link
Contributor Author

Screenshot from 2021-10-30 09-04-43

@mariobehling
Copy link
Member

Thumbnails are using original images, e.g. https://open-event-frontend-git-fork-maze-runnar-group-card-eventyay.vercel.app/explore/groups?name=fossasia . Check the thumbnail. It is 6MB big. Not really a small thumbnail.

@maze-runnar
Copy link
Contributor Author

I think celery is not working correctly on server side. Let me look.

@maze-runnar
Copy link
Contributor Author

@mariobehling I checked it locally, it's resizing correctly, maybe there is a problem with celery on production.

@mariobehling
Copy link
Member

Ok, will test it after deploying again on live server. Thanks.

@mariobehling mariobehling merged commit 0e6fb2b into fossasia:development Oct 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

4 participants