Skip to content

fix: standard group card height #8002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 31, 2021
Merged

fix: standard group card height #8002

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a1a071c
fix: standard group card height
maze-runnar Oct 29, 2021
24ccee4
f
maze-runnar Oct 29, 2021
8a824b7
show banner url, in case thumbnail is not their
maze-runnar Oct 30, 2021
687e567
fixes https://github.com/fossasia/open-event-frontend/issues/8005
maze-runnar Oct 30, 2021
4b8f136
fix https://github.com/fossasia/open-event-frontend/issues/8004
maze-runnar Oct 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/components/promoted-group-card.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,6 @@ get about() {
if (this.group.about?.length > 100) {
return this.group.about.slice(0, 100) + '...';
}
return this.group.about;
return this.group.about ? this.group.about : 'No information given about group.';
}
}
2 changes: 1 addition & 1 deletion app/templates/components/promoted-group-card.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<div class="{{if this.isWide 'event wide ui grid row'}}" style="height: 100%;">
<div class="{{if this.isWide 'event wide ui grid row'}}" style="height: 400px;">
<div class="ui card {{this.groupClass}} {{if this.isWide 'h-auto' 'h-full'}}">
<a class="image" href={{href-to 'group-public' @group.id}}>
<Widgets::SafeImage @src={{if @group.thumbnailImageUrl @group.thumbnailImageUrl "/images/group.png"}} />
Expand Down