Skip to content

Conversation

@pavnesh-c
Copy link
Member

@pavnesh-c pavnesh-c commented Aug 19, 2021

Fixes #7677

Screenshot:

image

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Aug 19, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/4ytY62Bx28XDs25ggrVux7Grfgew
✅ Preview: https://open-event-frontend-git-fork-pc-beast-group-per-261a06-eventyay.vercel.app

@codecov
Copy link

codecov bot commented Aug 20, 2021

Codecov Report

Merging #7714 (f3e9c9d) into development (9f6b69f) will increase coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #7714   +/-   ##
============================================
  Coverage        18.56%   18.56%           
============================================
  Files              612      613    +1     
  Lines             7197     7200    +3     
  Branches           149      149           
============================================
+ Hits              1336     1337    +1     
- Misses            5834     5836    +2     
  Partials            27       27           
Impacted Files Coverage Δ
app/routes/groups/team/permissions.ts 0.00% <0.00%> (ø)
app/router.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f6b69f...f3e9c9d. Read the comment docs.

@maze-runnar
Copy link
Contributor

@pc-beast what is remaining in this PR?

@pavnesh-c
Copy link
Member Author

@pc-beast what is remaining in this PR?

Adding what all permissions are there for groups. Will do it by evening.

@pavnesh-c
Copy link
Member Author

pavnesh-c commented Aug 20, 2021

I am not able to access the group as an organizer account(I have accepted the invite). Only admins and owners can access the groups page. I think there is some permissions issue there. Should I open a new issue for that?

@pavnesh-c
Copy link
Member Author

pavnesh-c commented Aug 27, 2021

Apparently, #7718 exists for all the tabs in the group. It makes me think that it's intended. Also, I don't feel there are any special privileges for organizers in the current system even #7718 is fixed. Because It says Access forbidden if I try to perform any action in the group settings. Need to discuss it more.

@pavnesh-c pavnesh-c marked this pull request as ready for review September 6, 2021 11:35
@pavnesh-c pavnesh-c changed the title [wip] feat: Groups Team page: add sub page for permissions feat: Groups Team page: add sub page for permissions Sep 6, 2021
@auto-label auto-label bot added the feature label Sep 6, 2021
@pavnesh-c
Copy link
Member Author

Dealing #7718 and other issues in different pr

@mariobehling mariobehling merged commit 1d54ed1 into fossasia:development Sep 6, 2021
@pavnesh-c pavnesh-c deleted the group-permissions branch December 1, 2021 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Groups Team Page: Add sub-page for permissions

3 participants