chore: remove sendAction() #6276

Saumyachitransh01 · 2021-01-08T15:08:03Z

Checklist

I have read the Contribution & Best practices Guide.
My branch is up-to-date with the Upstream development branch.
The acceptance, integration, unit tests and linter pass locally with my changes
I have added tests that prove my fix is effective or that my feature works
I have added necessary documentation (if appropriate)

vercel · 2021-01-08T15:08:09Z

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/65z59ofwk
✅ Preview: https://open-event-frontend-git-fork-saumyachitransh01-sendaction.eventyay.now.sh

MeghalBisht · 2021-01-08T20:25:08Z

app/mixins/event-wizard.js

        if (valid) {
          this.set('data.event.state', 'draft');
-          this.sendAction('save');
+          this.save();


sendAction is not working at some places but closures work well.
eg - event creation failed at step 1
Please refer the error #6203 (review)

So should I revert changes for step 1?

Yes, test all changes and revert whatever is not working

codecov · 2021-01-09T12:03:54Z

Codecov Report

Merging #6276 (0e2aa5a) into development (2e32e93) will increase coverage by 0.13%.
The diff coverage is 0.00%.

@@               Coverage Diff               @@
##           development    #6276      +/-   ##
===============================================
+ Coverage        22.58%   22.71%   +0.13%     
===============================================
  Files              519      520       +1     
  Lines             5704     5745      +41     
  Branches           112      113       +1     
===============================================
+ Hits              1288     1305      +17     
- Misses            4389     4413      +24     
  Partials            27       27

Impacted Files	Coverage Δ
app/components/account/password-section.js	`25.00% <0.00%> (ø)`
app/components/modals/add-system-role-modal.js	`33.33% <0.00%> (ø)`
app/components/modals/add-user-role-modal.js	`37.50% <0.00%> (ø)`
.../modals/admin/content/new-event-sub-topic-modal.js	`25.00% <0.00%> (ø)`
...ents/modals/admin/content/new-event-topic-modal.js	`33.33% <0.00%> (ø)`
...nents/modals/admin/content/new-event-type-modal.js	`33.33% <0.00%> (ø)`
.../components/modals/confirm-event-transfer-modal.js	`0.00% <0.00%> (ø)`
app/components/nav-bar.js	`33.33% <0.00%> (ø)`
app/components/side-bar.js	`78.94% <0.00%> (ø)`
app/components/widgets/forms/date-picker.js	`66.66% <0.00%> (ø)`
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e32e93...0e2aa5a. Read the comment docs.

iamareebjamal · 2021-01-12T11:01:27Z

@maze-runnar @sachinchauhan2889 Status of review?

maze-runnar · 2021-01-12T11:20:17Z

app/components/forms/admin/content/pages-form.js

    submit(data) {
      this.onValid(() => {
-        this.sendAction('save', data);
+        this.save(data);


Uncaught TypeError: _this.save is not a function

sachinchauhan2889

checked all non admin changes.

discount code form is not working.
access code form is not working.
order form is not working.

all are throwing this error in console.

maze-runnar · 2021-01-12T11:21:04Z

app/components/forms/admin/content/social-links-form.js

    submit() {
      this.onValid(() => {
-        this.sendAction('save');
+        this.save();


maze-runnar · 2021-01-12T11:21:37Z

app/components/forms/admin/settings/analytics-form.js

  actions: {
    submit() {
-      this.sendAction('save');
+      this.save();


maze-runnar · 2021-01-12T11:22:37Z

app/components/forms/admin/settings/images-form.js

    submit() {
      this.onValid(() => {
-        this.sendAction('save');
+        this.save();


maze-runnar · 2021-01-12T11:23:28Z

app/components/forms/admin/settings/payment-gateway-form.js

          });
        }
-        this.sendAction('save');
+        this.save();


maze-runnar · 2021-01-12T11:24:25Z

app/components/forms/admin/settings/system-form.js

    submit() {
      this.onValid(() => {
-        this.sendAction('save');
+        this.save();


maze-runnar · 2021-01-12T11:25:46Z

app/components/forms/events/view/create-access-code.js

    submit(data) {
      this.onValid(() => {
-        this.sendAction('save', data);
+        this.save(data);


maze-runnar · 2021-01-12T11:27:32Z

app/components/forms/events/view/create-discount-code.js

    submit(data) {
      this.onValid(() => {
-        this.sendAction('save', data);
+        this.save(data);


sachinchauhan2889

checked all non-admin routes. working fine.

removing sendAction()

19b74b7

vercel bot deployed to Preview January 8, 2021 15:08 View deployment

MeghalBisht reviewed Jan 8, 2021

View reviewed changes

revert

5affd22

vercel bot deployed to Preview January 9, 2021 11:26 View deployment

fix

0503fcf

vercel bot deployed to Preview January 9, 2021 11:56 View deployment

fix

b1efead

vercel bot deployed to Preview January 10, 2021 14:04 View deployment

Saumyachitransh01 requested a review from iamareebjamal January 10, 2021 14:14

fix

736a8f4

vercel bot deployed to Preview January 10, 2021 14:27 View deployment

iamareebjamal requested review from maze-runnar and sachinchauhan2889 January 10, 2021 16:44

maze-runnar reviewed Jan 12, 2021

View reviewed changes

sachinchauhan2889 suggested changes Jan 12, 2021

View reviewed changes

maze-runnar reviewed Jan 12, 2021

View reviewed changes

app/components/forms/admin/settings/analytics-form.js Outdated

actions: {

submit() {

this.sendAction('save');

this.save();

Copy link

Contributor

maze-runnar Jan 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maze-runnar reviewed Jan 12, 2021

View reviewed changes

app/components/forms/admin/settings/payment-gateway-form.js Outdated

});

}

this.sendAction('save');

this.save();

Copy link

Contributor

maze-runnar Jan 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maze-runnar reviewed Jan 12, 2021

View reviewed changes

fix

e715aba

vercel bot deployed to Preview January 12, 2021 13:23 View deployment

Update billing.js

0e2aa5a

vercel bot deployed to Preview January 12, 2021 13:39 View deployment

iamareebjamal requested review from maze-runnar and sachinchauhan2889 January 16, 2021 22:31

sachinchauhan2889 reviewed Jan 17, 2021

View reviewed changes

iamareebjamal changed the title ~~removing sendAction()~~ chore: remove sendAction() Jan 17, 2021

auto-label bot added the chore label Jan 17, 2021

iamareebjamal merged commit 2bf1209 into fossasia:development Jan 17, 2021

MeghalBisht mentioned this pull request May 19, 2021

Use closure actions instead of sendAction in the project. #1519

Closed

chore: remove sendAction() #6276

chore: remove sendAction() #6276

Uh oh!

Conversation

Saumyachitransh01 commented Jan 8, 2021

Checklist

Uh oh!

vercel bot commented Jan 8, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Jan 9, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

iamareebjamal commented Jan 12, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sachinchauhan2889 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sachinchauhan2889 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

vercel bot commented Jan 8, 2021 •

edited

Loading

codecov bot commented Jan 9, 2021 •

edited

Loading