Skip to content

Conversation

@ARKEOLOGIST
Copy link

…he project

Fixes #1519

Short description of what this resolves:

Added closure actions in place of sendAction in several files of the project.

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Jan 1, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/9cak1gw4n
✅ Preview: https://open-event-frontend-git-fork-arkeologist-arka.eventyay.vercel.app

@codecov
Copy link

codecov bot commented Jan 1, 2021

Codecov Report

Merging #6203 (3c9bae5) into development (cfce6d2) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #6203   +/-   ##
============================================
  Coverage        22.93%   22.93%           
============================================
  Files              522      522           
  Lines             5698     5698           
  Branches           110      110           
============================================
  Hits              1307     1307           
  Misses            4364     4364           
  Partials            27       27           
Impacted Files Coverage Δ
app/components/account/password-section.js 25.00% <0.00%> (ø)
app/components/forms/admin/content/pages-form.js 0.00% <0.00%> (ø)
...omponents/forms/admin/content/social-links-form.js 0.00% <0.00%> (ø)
.../components/forms/admin/settings/analytics-form.js 0.00% <0.00%> (ø)
app/components/forms/admin/settings/images-form.js 0.00% <0.00%> (ø)
...ponents/forms/admin/settings/microservices-form.js 0.00% <0.00%> (ø)
app/components/forms/events/view/edit-session.js 0.00% <0.00%> (ø)
app/components/modals/add-system-role-modal.js 33.33% <0.00%> (ø)
app/components/modals/add-user-role-modal.js 37.50% <0.00%> (ø)
.../modals/admin/content/new-event-sub-topic-modal.js 25.00% <0.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfce6d2...88ea948. Read the comment docs.

Copy link
Member

@MeghalBisht MeghalBisht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Event creation failed at wizard step 1.
2021-01-01 (2)

@ARKEOLOGIST
Copy link
Author

@MeghalBisht deployed a fix. There was a minor typo that might have caused that issue.

@ARKEOLOGIST ARKEOLOGIST closed this Jan 2, 2021
@ARKEOLOGIST ARKEOLOGIST deleted the arka branch January 2, 2021 02:53
@MeghalBisht MeghalBisht mentioned this pull request Jan 8, 2021
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use closure actions instead of sendAction in the project.

2 participants