Skip to content

chore: remove sendAction() #6276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 17, 2021
Merged

chore: remove sendAction() #6276

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
19b74b7
removing sendAction()
Saumyachitransh01 Jan 8, 2021
5affd22
revert
Saumyachitransh01 Jan 9, 2021
0503fcf
fix
Saumyachitransh01 Jan 9, 2021
b1efead
fix
Saumyachitransh01 Jan 10, 2021
736a8f4
fix
Saumyachitransh01 Jan 10, 2021
e715aba
fix
Saumyachitransh01 Jan 12, 2021
0e2aa5a
Update billing.js
Saumyachitransh01 Jan 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/components/account/password-section.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ export default Component.extend(FormMixin, {
},
submit() {
this.onValid(() => {
this.sendAction('changePassword', { passwordCurrent: this.passwordCurrent, passwordNew: this.passwordNew });
this.changePassword({ passwordCurrent: this.passwordCurrent, passwordNew: this.passwordNew });
});
}
}
Expand Down
2 changes: 1 addition & 1 deletion app/components/forms/admin/content/pages-form.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ export default Component.extend(FormMixin, {
actions: {
submit(data) {
this.onValid(() => {
this.sendAction('save', data);
this.save(data);
Copy link
Contributor

@maze-runnar maze-runnar Jan 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uncaught TypeError: _this.save is not a function

Screenshot from 2021-01-12 16-49-56

});
},
deletePage(data) {
Expand Down
2 changes: 1 addition & 1 deletion app/components/forms/admin/content/social-links-form.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export default Component.extend(FormMixin, {
actions: {
submit() {
this.onValid(() => {
this.sendAction('save');
this.save();
Copy link
Contributor

@maze-runnar maze-runnar Jan 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot from 2021-01-12 16-50-50

});
}
}
Expand Down
2 changes: 1 addition & 1 deletion app/components/forms/admin/settings/analytics-form.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import Component from '@ember/component';
export default Component.extend({
actions: {
submit() {
this.sendAction('save');
this.save();
Copy link
Contributor

@maze-runnar maze-runnar Jan 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot from 2021-01-12 16-51-25

}
}
});
2 changes: 1 addition & 1 deletion app/components/forms/admin/settings/images-form.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ export default Component.extend(FormMixin, {
actions: {
submit() {
this.onValid(() => {
this.sendAction('save');
this.save();
Copy link
Contributor

@maze-runnar maze-runnar Jan 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot from 2021-01-12 16-52-25

});
}
}
Expand Down
2 changes: 1 addition & 1 deletion app/components/forms/admin/settings/microservices-form.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ export default Component.extend(FormMixin, {
actions: {
submit() {
this.onValid(() => {
this.sendAction('save');
this.save();
});
}
}
Expand Down
2 changes: 1 addition & 1 deletion app/components/forms/admin/settings/payment-gateway-form.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,7 @@ export default Component.extend(FormMixin, {
'omiseLiveSecret' : null
});
}
this.sendAction('save');
this.save();
Copy link
Contributor

@maze-runnar maze-runnar Jan 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot from 2021-01-12 16-53-17

});
}
}
Expand Down
2 changes: 1 addition & 1 deletion app/components/forms/admin/settings/system-form.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@ export default Component.extend(FormMixin, {
actions: {
submit() {
this.onValid(() => {
this.sendAction('save');
this.save();
Copy link
Contributor

@maze-runnar maze-runnar Jan 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot from 2021-01-12 16-54-13

});
}
}
Expand Down
2 changes: 1 addition & 1 deletion app/components/forms/events/view/create-access-code.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ export default Component.extend(FormMixin, {
},
submit(data) {
this.onValid(() => {
this.sendAction('save', data);
this.save(data);
Copy link
Contributor

@maze-runnar maze-runnar Jan 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot from 2021-01-12 16-55-33

});
},
copiedText() {
Expand Down
2 changes: 1 addition & 1 deletion app/components/forms/events/view/create-discount-code.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ export default Component.extend(FormMixin, {
},
submit(data) {
this.onValid(() => {
this.sendAction('save', data);
this.save(data);
Copy link
Contributor

@maze-runnar maze-runnar Jan 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot from 2021-01-12 16-56-56

});
},
copiedText() {
Expand Down
2 changes: 1 addition & 1 deletion app/components/forms/events/view/edit-session.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ export default Component.extend(FormMixin, {
actions: {
submit() {
this.onValid(() => {
this.sendAction('save');
this.save();
});
}
}
Expand Down
2 changes: 1 addition & 1 deletion app/components/forms/orders/order-form.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -515,7 +515,7 @@ export default Component.extend(FormMixin, {
const currentUser = this.data.user;
currentUser.set('firstName', this.buyerFirstName);
currentUser.set('lastName', this.buyerLastName);
this.sendAction('save', data);
this.save(data);
});
},
modifyHolder(holder) {
Expand Down
2 changes: 1 addition & 1 deletion app/components/forms/session-speaker-form.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -441,7 +441,7 @@ export default Component.extend(FormMixin, {
actions: {
submit() {
this.onValid(() => {
this.sendAction('save');
this.save();
});
},

Expand Down
2 changes: 1 addition & 1 deletion app/components/modals/add-system-role-modal.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ export default class AddSystemRoleModal extends ModalBase.extend(FormMixin) {
@action
addRole() {
this.onValid(() => {
this.sendAction('addSystemRole');
this.addSystemRole();
});
}

Expand Down
2 changes: 1 addition & 1 deletion app/components/modals/add-user-role-modal.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ export default class AddUserRoleModal extends ModalBase.extend(FormMixin) {
@action
addRole() {
this.onValid(() => {
this.sendAction('addUserRoles');
this.addUserRoles();
});
}

Expand Down
2 changes: 1 addition & 1 deletion app/components/modals/admin/content/new-event-sub-topic-modal.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ export default ModalBase.extend(FormMixin, {
addEventProperty(modelInstance, eventTopic) {
this.onValid(() => {
modelInstance.set('eventTopic', eventTopic);
this.sendAction('addEventProperty', modelInstance);
this.addEventProperty(modelInstance);
});
}
},
Expand Down
2 changes: 1 addition & 1 deletion app/components/modals/admin/content/new-event-topic-modal.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ export default ModalBase.extend(FormMixin, {
actions: {
addEventProperty(modelInstance) {
this.onValid(() => {
this.sendAction('addEventProperty', modelInstance);
this.addEventProperty(modelInstance);
});
}
},
Expand Down
2 changes: 1 addition & 1 deletion app/components/modals/admin/content/new-event-type-modal.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ export default ModalBase.extend(FormMixin, {
actions: {
addEventProperty(modelInstance) {
this.onValid(() => {
this.sendAction('addEventProperty', modelInstance);
this.addEventProperty(modelInstance);
});
}
},
Expand Down
2 changes: 1 addition & 1 deletion app/components/modals/confirm-event-transfer-modal.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ export default ModalBase.extend(FormMixin, {
actions: {
submit() {
this.onValid(() => {
this.sendAction('transferEvent');
this.transferEvent();
});
},
close() {
Expand Down
2 changes: 1 addition & 1 deletion app/components/nav-bar.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ export default class NavBar extends Component {
@action
handleKeyPress() {
if (event.code === 'Enter') {
this.sendAction('search');
this.search();
document.querySelector('#mobile-bar').classList.remove('show-bar');
}
}
Expand Down
2 changes: 1 addition & 1 deletion app/components/side-bar.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ export default class SideBar extends Component {
handleKeyPress() {
if (event.code === 'Enter') {
this.set('sidebarVisible', false);
this.sendAction('search');
this.search();
}
}

Expand Down
2 changes: 1 addition & 1 deletion app/components/widgets/forms/date-picker.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ export default Component.extend(FormMixin, {
actions: {
onChange() {
if (this.onChange) {
this.sendAction('onChange');
this.onChange();
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion app/components/widgets/forms/time-picker.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ export default Component.extend({
actions: {
onChange() {
if (this.onChange) {
this.sendAction('onChange', this.value);
this.onChange(this.value);
}
}
}
Expand Down