Skip to content

fix: Fix export events module(URL fetch logic) #3294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 30, 2019
Merged

fix: Fix export events module(URL fetch logic) #3294

merged 3 commits into from
Jul 30, 2019

Conversation

mrsaicharan1
Copy link
Member

@mrsaicharan1 mrsaicharan1 commented Jul 19, 2019 •
edited
Loading

EventExport
Fixes #3293

Short description of what this resolves:

Fixes event exports with the help of loader service

Related Server fix:

Changes proposed in this pull request:

  • Implemented an action to fix downloads & file serving
  • Modified component template logic

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@auto-label auto-label bot added the fix label Jul 19, 2019
@mrsaicharan1 mrsaicharan1 mentioned this pull request Jul 19, 2019
Closed
6 tasks
niranjan94
niranjan94 suggested changes Jul 20, 2019
View reviewed changes
Anupam-dagar
Anupam-dagar reviewed Jul 24, 2019
View reviewed changes
Copy link
Member

@Anupam-dagar Anupam-dagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mrsaicharan1 travis is failing

@mrsaicharan1 mrsaicharan1 requested a review from abhinavk96 July 25, 2019 07:14
@mrsaicharan1
Copy link
Member Author

@mrsaicharan1 travis is failing

Updated the branch. Travis is passing now.

abhinavk96
abhinavk96 suggested changes Jul 30, 2019
View reviewed changes
Copy link
Contributor

@abhinavk96 abhinavk96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the success message displayed twice in the GIF?

@mrsaicharan1
Copy link
Member Author

Why is the success message displayed twice in the GIF?

Click on start, on success, message to indicate the exported event is now available for download
Click on download, on success, message to indicate the exported event has been downloaded.

@abhinavk96 abhinavk96 merged commit 45b588d into fossasia:development Jul 30, 2019
@kushthedude kushthedude mentioned this pull request Feb 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@uds5501 uds5501 Awaiting requested review from uds5501

@shreyanshdwivedi shreyanshdwivedi Awaiting requested review from shreyanshdwivedi

3 more reviewers

@Anupam-dagar Anupam-dagar Anupam-dagar left review comments

@niranjan94 niranjan94 niranjan94 requested changes

@abhinavk96 abhinavk96 abhinavk96 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Event Export non-functional

4 participants

@mrsaicharan1 @niranjan94 @abhinavk96 @Anupam-dagar