Skip to content

Conversation

@kushthedude
Copy link
Member

@codecov
Copy link

codecov bot commented Feb 10, 2020

Codecov Report

Merging #4042 into development will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #4042      +/-   ##
===============================================
+ Coverage         21.9%   21.95%   +0.05%     
===============================================
  Files              460      459       -1     
  Lines             4735     4723      -12     
===============================================
  Hits              1037     1037              
+ Misses            3698     3686      -12

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46ad4ce...3be3b10. Read the comment docs.

@mrsaicharan1
Copy link
Member

How is this the solution?

@kushthedude
Copy link
Member Author

kushthedude commented Feb 10, 2020 via email

@mrsaicharan1
Copy link
Member

If there's an extra param, why would you change the whole logic? There's a precise workflow in place. Please check it out on the server and FE.
I don't think this is the correct fix.

@kushthedude
Copy link
Member Author

The URL fetch logic was added in this #3294, Indeed the cause for invalid localhost URL specified in the issue might be empty fields for API URL & Frontend URL in Settings.

@kushthedude kushthedude requested review from iamareebjamal and removed request for iamareebjamal February 13, 2020 18:17
@iamareebjamal
Copy link
Member

#4042 (comment)

@kushthedude kushthedude closed this Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Celery accesses SMTP configs before exporting event

3 participants