Added useTransparentBackground feature for Add2App use cases
#267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use standard Activity as calling class to support FlutterFragmentActivity
add eval javascript sink onUrlChanged ...
fix document
android: add rect, fullScreen, userAgent, eval
ios and android more implement
ready to 0.0.10
iOS delegate and some features
[Android] Back button navigates back now instead of closing webview
Add pub badge
Add pub badge to README
Update Android SDK to 27 and Gradle to 3.2.1
Update readme to add the withLocalUrl argument
add back, forward, reload method on iOS
Enable progress indicator for page load with WebviewScaffold
Do not call onReceiveValue on null reference
…uttercommunity#187) * separate openUrl and reloadUrl to keep WebView settings * enable mixed content support in Android WebView * enable mixed content support in Android WebView * increase version number * always allow mixed content * reconfig Mixed Content Mode as Compatibility Mode * fix bug UIViewController nil, support multiple windows in Android * add global clean cookie function
* added allowFileURLs for Android
fix exception when intent is null
* adding minSdkVersion * Update build.gradle
For some reason WebViewScaffold.hidden property wasn't passed to webviewReference.launch call. Because of that WebView was always visible when shown using scaffold, even when hidden was set to true
Pass hidden state when opening WebViewScaffold
|
hello @wouterhardeman thank you for PR and sorry for being late. I think that maybe instead of adding flag |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using Flutter in an Add2App scenario.
I was using the plugin on Android, but the web page did not appear on the screen. While debugging I found out the native WebView is rendered behind the FlutterView. The scaffold used in
webview_scaffold.dartdoes not set a background, which will result in thescaffoldBackgroundColorvalue from theThemeDatabeing used. I would prefer to not set a custom background for every scaffold I use and have the theme value be transparent.If preferred I can change it to allow any custom
backgroundColorto be set, but in most scenarios it won't even be visible. I think usingbackgroundColorcould cause confusion among the users.This is probably also an issue with how Flutter works in an Add2App scenario. I suspect the FlutterView is always forced on top of other views on Android.