[Android] separate openUrl and reloadUrl to keep WebView settings #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charafau
pushed a commit
that referenced
this pull request
Apr 7, 2020
* separate openUrl and reloadUrl to keep WebView settings * enable mixed content support in Android WebView * enable mixed content support in Android WebView * increase version number * always allow mixed content * reconfig Mixed Content Mode as Compatibility Mode * fix bug UIViewController nil, support multiple windows in Android * add global clean cookie function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on Android side, reloadUrl() recall openUrl() and reset all settings to default values, I think it is better to keep those settings from launch() and just call WebView.loadUrl() with new a url value