-
Notifications
You must be signed in to change notification settings - Fork 936
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable progress indicator for page load with WebviewScaffold #160
Conversation
…e underlying Scaffold to be shown while waiting for page load
Hello I tested this functionality in iPhone 7 emulator works well. But i'm having an issue with my android device Samsung J7 it's stuck loading. How i run the webview
If i remove the hidden property it works well, of course it doesn't display the circular loading. Here's the logs when running.
Later i'll test in a physical iPhone device, and if there's a problem i'll let you know. .... I test it with an iPhone 6, and works well. |
Hidden: True , is not working sometimes, I think it has something to do with being out of memory. Is there any way change/increase the WebView Cache Size? |
Works for me. Thank you @js1972 |
Enable progress indicator for page load with WebviewScaffold
With regards to issue #159 which was a request to enable a page load "waiting" indicator of some sort. I've had a quick crack at it myself here.
Added two optional parameters to the WebviewScaffold widget:
hidden
andinitialChild
.By setting
hidden
to true the underling Scaffold widget is shown (defaulting to a CircularProgressIndicator as the body). Then we track the state change so that when the page is loadedshow()
is called on the webview.If the
initialChild
parameter is also set to a Widget - then it is shown instead of the default CircularProgressIndicator.