Add DropdownButton#1903
Merged
Merged
Conversation
Fixes #1855
googlebot
added
the
cla: yes
chalin
reviewed
Dec 5, 2018
| }, | ||
| { | ||
| "name": "DropdownButton", | ||
| "sample": "DropdownButton", |
Contributor
There was a problem hiding this comment.
I'm not seeing this field being used anywhere. Consider dropping it.
Contributor
Author
There was a problem hiding this comment.
The sample field is in a bunch of the entries (Scaffold, AppBar), including PopupMenuButton, which I copied. Should I delete it for just this one and/or file an issue to look into the sample fields?
Contributor
There was a problem hiding this comment.
Filing an issue is probably the best option, thanks.
Contributor
Author
There was a problem hiding this comment.
I'll drop it for this one, since I don't know that a sample exists AND file that issue.
chalin
approved these changes
Dec 5, 2018
chalin
left a comment
chalin
left a comment
Contributor
There was a problem hiding this comment.
I nit, otherwise LGTM. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1855