Skip to content

Added DropdownButton to the widget catalog#1460

Closed
awazgyawali wants to merge 2 commits into
flutter:dashfrom
awazgyawali:widgets-catalog
Closed

Added DropdownButton to the widget catalog#1460
awazgyawali wants to merge 2 commits into
flutter:dashfrom
awazgyawali:widgets-catalog

Conversation

@awazgyawali

@awazgyawali awazgyawali commented Oct 12, 2018

Copy link
Copy Markdown

Addresses this issue flutter/flutter#14460
We might need to add "Spinner" word somewhere to make Android developers easy to find the widget.

Fernando Toledo and others added 2 commits October 11, 2018 16:24
@googlebot

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@googlebot googlebot added the cla: no Contributor has not signed the Contributor License Agreement label Oct 12, 2018
@awazgyawali

Copy link
Copy Markdown
Author

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers
Corporate signers

I signed it!

@googlebot

Copy link
Copy Markdown

CLAs look good, thanks!

@googlebot googlebot added cla: yes Contributor has signed the Contributor License Agreement and removed cla: no Contributor has not signed the Contributor License Agreement labels Oct 12, 2018

@Sfshaza Sfshaza left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chalin, can you take a look? I know this PR is against the master branch, but we'll need to add it to the new branch as well.

},
{
"name": "DropdownButton",
"description": "A input field to choose an item from a list.",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"A input field to choose..." => "An input field for choosing..."

I thought the idea was to add Spinner to this description for Android users?

"Input and selections"
],
"link": "https://docs.flutter.io/flutter/widgets/DropdownButton-class.html",
"image": "<img alt='' src='/images/catalog-widget-placeholder.png'>"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why a placeholder image?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind, we use lots of them.

@chalin

chalin commented Oct 26, 2018

Copy link
Copy Markdown
Contributor

Given that this is not a P0, @awazgyawali could you close this PR and reopen one over the dash branch?

@chalin chalin added the cl.wont-fix Issue closed as it either can't be or won't be fixed label Oct 26, 2018
@awazgyawali awazgyawali changed the base branch from widgets-catalog to dash November 1, 2018 07:53
@awazgyawali awazgyawali closed this Nov 1, 2018
@awazgyawali

Copy link
Copy Markdown
Author

OK @chalin

@chalin

chalin commented Nov 1, 2018

Copy link
Copy Markdown
Contributor

Thanks!

@MarkOSullivan94

Copy link
Copy Markdown
Contributor

Has this been merged in?

@chalin

chalin commented Dec 13, 2018

Copy link
Copy Markdown
Contributor

No, but #1903 was merged and it added DropdownButton.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cl.wont-fix Issue closed as it either can't be or won't be fixed cla: yes Contributor has signed the Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants