Skip to content

Add DropdownButton #1903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kwalrath merged 2 commits into from
Dec 5, 2018
Merged

Add DropdownButton #1903

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ff4c4b2
Add DropdownButton
kwalrath Dec 5, 2018
dbd7460
Remove unused (?) "sample" field
kwalrath Dec 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/_data/catalog/widgets.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,6 +235,17 @@
"link": "https://docs.flutter.io/flutter/material/IconButton-class.html",
"image": "<img alt='' src='https://storage.googleapis.com/material-design/publish/material_v_11/assets/0B_udO5B8pzrzdXVuTlBoOTBjcU0/components_buttons_other1.png'>"
},
{
"name": "DropdownButton",
"sample": "DropdownButton",

@chalin chalin Dec 5, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not seeing this field being used anywhere. Consider dropping it.

@kwalrath kwalrath Dec 5, 2018

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sample field is in a bunch of the entries (Scaffold, AppBar), including PopupMenuButton, which I copied. Should I delete it for just this one and/or file an issue to look into the sample fields?

@chalin chalin Dec 5, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filing an issue is probably the best option, thanks.

@kwalrath kwalrath Dec 5, 2018

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll drop it for this one, since I don't know that a sample exists AND file that issue.

"description": "Shows the currently selected item and an arrow that opens a menu for selecting another item.",
"categories": [],
"subcategories": [
"Buttons"
],
"link": "https://docs.flutter.io/flutter/material/DropdownButton-class.html",
"image": "<img alt='' src='/images/catalog-widget-placeholder.png'>"
},
{
"name": "PopupMenuButton",
"sample": "PopupMenuButton",
Expand Down