Skip to content

Added DropdownButton to the widget catalog #1460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
awazgyawali wants to merge 2 commits into from
Closed

Added DropdownButton to the widget catalog #1460

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
01ad1e3
WIP
Oct 11, 2018
3d0dbb0
Added DropdownButton to the widget catalog
awazgyawali Oct 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/_assets/css/_bootstrap_adjust.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,14 @@ a.card {
padding: bs-spacer(4) 0;
}

.nav-tabs .nav-link.active {
.nav-tabs .nav-link,
.nav-tabs .nav-link:hover {
border: none;
border-bottom: 2px solid $site-color-primary;
border-bottom: 2px solid transparent;
}

.nav-tabs .nav-link.active {
border-color: $site-color-primary;
}

@mixin pre-defaults {
Expand Down
2 changes: 1 addition & 1 deletion src/_assets/css/_header.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@

.btn {
@include media-breakpoint-up(md) {
margin-left: bs-spacer(4);
margin-right: bs-spacer(4);
}
}

Expand Down
12 changes: 12 additions & 0 deletions src/_data/catalog/widgets.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1608,5 +1608,17 @@
],
"link": "https://docs.flutter.io/flutter/widgets/AnimatedWidgetBaseState-class.html",
"image": "<img alt='' src='/images/catalog-widget-placeholder.png'>"
},
{
"name": "DropdownButton",
"description": "A input field to choose an item from a list.",

@Sfshaza Sfshaza Oct 15, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"A input field to choose..." => "An input field for choosing..."

I thought the idea was to add Spinner to this description for Android users?

"categories": [
"Material Components"
],
"subcategories": [
"Input and selections"
],
"link": "https://docs.flutter.io/flutter/widgets/DropdownButton-class.html",
"image": "<img alt='' src='/images/catalog-widget-placeholder.png'>"

@Sfshaza Sfshaza Oct 15, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why a placeholder image?

@sfshaza2 sfshaza2 Nov 1, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind, we use lots of them.

}
]
20 changes: 15 additions & 5 deletions src/development/ui/widgets-catalog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,20 @@ platform, and interactive widgets.
In addition to browsing widgets by category,
you can also see all the widgets in the [Flutter widget index](/api-and-reference/widgets).

<div>
{% for section in site.data.catalog.index %}
- ### [{{section.name}}](/api-and-reference/widgets/{{section.id}})
{:.catalog-category-title}

{{section.description}}
{:.card}
{% capture modulo3 %}{{ forloop.index0 | modulo:3 }}{% endcapture %}
{% if modulo3 == '0' %}
<div class="card-deck">
{% endif %}
<a class="card" href="/development/ui/widgets/{{section.id}}">
<div class="card-body">
<header class="card-title">{{section.name}}</header>
<p class="card-text">{{section.description}}</p>
</div>
</a>
{% if modulo3 == '2' or forloop.last %}
</div>
{% endif %}
{% endfor %}
</div>