This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[cloud_functions]Adding error code because 'Code cannot be nil' #978
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the app reaches this line it crashes because FlutterError asserts a non-null code. I'm reaching this line because I improperly formatted my function parameters, so I am naming the code "formattingError". The localized description should describe what exactly went wrong.
Contributor
Author
|
This causes a crash. |
cyanglaz
changed the title
cyanglaz
added
the
submit queue
collinjackson
suggested changes
Apr 8, 2019
Contributor
There was a problem hiding this comment.
Please add Android implementation in CloudFunctionsPlugin.java as well.
Please update CHANGELOG and pubspec.yaml for release.
I would love to have an integration test for this case. Do you have any suggestions for how to trigger this error case to occur? See https://github.com/flutter/plugins/blob/master/packages/cloud_functions/example/test/cloud_functions.dart
collinjackson
added
bugfix
and removed
submit queue
Contributor
|
Looks like this was fixed on iOS in #1210 so I'm going to close this one |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the app reaches this line it crashes because FlutterError asserts a non-null code. On the dart side this is referred to as a. 'generic error', so that is what I'm naming the code. The localized description should describe what exactly went wrong.