Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

@radvansky-tomas
Copy link

On android, usually much sooner than firebase timeout, socket timeout exception occurs. This is not handled properly and invalid format envelope exception is thrown. Exception is not handled and whole call is interrupted as non handled dart exception.

pulyaevskiy/firebase-functions-interop#43
flutter/flutter#24997

… exception occurs. This is not handled properly and invalid format envelope exception is thrown. Exception is not handled and whole call is interrupted as non handled dart exception.

pulyaevskiy/firebase-functions-interop#43
flutter/flutter#24997
@amirh
Copy link
Contributor

amirh commented Jan 16, 2019

@kroikie

@cyanglaz cyanglaz changed the title Add SocketTimeoutException for Cloud Functions [cloud_functions]Add SocketTimeoutException for Cloud Functions Feb 22, 2019
@collinjackson
Copy link
Contributor

collinjackson commented Apr 8, 2019

I'd like to go ahead and merge this. but it says the PR is from an unknown repository. Can you merge with the latest master, include a CHANGELOG/pubspec.yaml update and possibly give me access to your branch so I can more easily land?

@radvansky-tomas
Copy link
Author

@collinjackson Invitation sent, feel free to perform any necessary change. My branch contains fixes for cloud_functions SocketTimeOut Exception and cloud_firestore feature for documents paging using document snapshots directly

@collinjackson
Copy link
Contributor

Thanks @radvansky-tomas. For some reason it's still showing up as unknown repository.

Screen Shot 2019-05-02 at 11 45 49

Can you close this PR and open a new one with the conflicts resolved and perhaps that will fix it?

@collinjackson
Copy link
Contributor

I've added the Java implementation to #978. I think this PR isn't really necessary once that's landed because the error message will be more descriptive.

@collinjackson
Copy link
Contributor

I'll go ahead and close this one in favor of #978

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants