This repository was archived by the owner on Feb 22, 2023. It is now read-only.
cloud functions multiple app support #1210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iskakaushik
reviewed
Feb 21, 2019
| FirebaseFunctions.getInstance().getHttpsCallable(functionName); | ||
| Map<String, Object> parameters = call.argument("parameters"); | ||
| String appName = call.argument("app"); | ||
| FirebaseApp app = FirebaseApp.getInstance(appName); |
Contributor
There was a problem hiding this comment.
if appName is null do we want FirebaseApp.getInstance(), thats for default FirebaseApp as opposed to FirebaseApp.getInstance(null) which might throw? (it's not very clear per docs https://firebase.google.com/docs/reference/android/com/google/firebase/FirebaseApp.html#getInstance(java.lang.String))
Contributor
Author
There was a problem hiding this comment.
I think appName cannot be null with the firebase_core plugin that we are depending on. There is an assert(name != null) in firebase_core. The default app is named __FIRAPP_DEFAULT on iOS and [DEFAULT] on Android.
Note that app can't be null either; see the Dart CloudFunctions constructor.
cyanglaz
reviewed
Feb 21, 2019
Contributor
|
|
idealopamp
pushed a commit
to idealopamp/plugins
that referenced
this pull request
Feb 21, 2019
rishabnayak
added a commit
to rishabnayak/plugins
that referenced
this pull request
Mar 1, 2019
julianscheel
pushed a commit
to jusst-engineering/plugins
that referenced
this pull request
Mar 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#27888