This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
[webview_flutter] Add zoomEnabled to webview flutter platform interface #4404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
p: webview_flutter
13 tasks
stuartmorgan
suggested changes
Oct 1, 2021
packages/webview_flutter/webview_flutter_platform_interface/CHANGELOG.md
Outdated
Show resolved
Hide resolved
packages/webview_flutter/webview_flutter_platform_interface/pubspec.yaml
Outdated
Show resolved
Hide resolved
|
@bparrishMines @mvanbeusekom Could one of you take a look as well, per the newly-documented two-committer policy? |
Thank you again @stuartmorgan. Is there a way to force a new CI build? The failure is a timeout and seems unrelated to my changes |
|
I've restarted the failing test. (There was an issue with that test across the repo at the end of last week.) |
|
This should automatically be published within a couple of hours, unblocking the next PR (or PRs; you can do the two implementation changes as either one PR or two as you prefer, since they don't depend on each other). Thanks again! |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 5, 2021
NickalasB
added a commit
to NickalasB/plugins
that referenced
this pull request
Oct 5, 2021
* master: [webview_flutter] Add zoomEnabled to webview flutter platform interface (flutter#4404) [ci] Remove obsolete Dockerfile (flutter#4405) Fix order-dependant platform interface tests (flutter#4406) [google_maps_flutter]: LatLng longitude loses precision in constructor #90574 (flutter#4374)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 5, 2021
12 tasks
mgonzalezc
pushed a commit
to mgonzalezc/plugins
that referenced
this pull request
Oct 12, 2021
* master: (1126 commits) [webview_flutter] Adjust test URLs again (flutter#4407) [google_sign_in] Add serverAuthCode attribute to google_sign_in_platform_interface user data (flutter#4179) [camera] Add filter for unsupported cameras on Android (flutter#4418) [webview_flutter] Update webview platform interface with new methods for running JavaScript. (flutter#4401) [webview_flutter] Add zoomEnabled to webview flutter platform interface (flutter#4404) [ci] Remove obsolete Dockerfile (flutter#4405) Fix order-dependant platform interface tests (flutter#4406) [google_maps_flutter]: LatLng longitude loses precision in constructor #90574 (flutter#4374) [google_maps_flutter] Add Marker drag events (flutter#2838) [flutter_plugin_tools] Validate pubspec description (flutter#4396) Add file_selector to the repo list (flutter#4395) [in_app_purchase] Fix in_app_purchase_android/README.md (flutter#4363) [google_maps_flutter_web] Add Marker drag events (flutter#4385) [webview_flutter] Fixed todos in FlutterWebView.java (flutter#4394) Handle `PurchaseStatus.restored` correctly in example. (flutter#4393) Handle restored purchases in iOS example app (flutter#4392) [file_selector] Remove custom analysis options (flutter#4382) [flutter_plugin_tools] Check licenses in Kotlin (flutter#4373) Fixed _CastError when running example App (flutter#4390) [in_app_purchase] Ensure the introductoryPriceMicros field is transported as a String. (flutter#4370) ... # Conflicts: # packages/quick_actions/ios/Classes/FLTQuickActionsPlugin.m
camsim99
pushed a commit
to camsim99/plugins
that referenced
this pull request
Oct 18, 2021
…ce (flutter#4404) This is the first-step task to add a zoomEnabled param on the WebView widget.
NickalasB
deleted the
add_zoomEnabled_to_webview_flutter_platform_interface
branch
amantoux
pushed a commit
to amantoux/plugins
that referenced
this pull request
Dec 11, 2021
…ce (flutter#4404) This is the first-step task to add a zoomEnabled param on the WebView widget.
KyleFin
pushed a commit
to KyleFin/plugins
that referenced
this pull request
Dec 21, 2021
…ce (flutter#4404) This is the first-step task to add a zoomEnabled param on the WebView widget.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
webview_flutterwas recently updated to be a Federated Plugin, this PR is part of the instructions on changing Federated Plugins.This is the first-step task to add a
zoomEnabledparam on theWebViewwidget.If this is approved, merged, and published, it will be fast-followed by two other small PRs updating
webview_flutter_wkwebviewandwebview_flutter_android.I have been maintaining #3325 for a decent chunk of time and I'm hoping following these new Federated plugin guidelines can get this puppy over the finish line and we can get off our Forked version of this plugin.
List which issues are fixed by this PR. You must list at least one issue.
Implements flutter/flutter#70731
Implements flutter/flutter#48283
Relates to flutter/flutter#48245
Relates to flutter/flutter#60921
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
dart format.)[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.