[in_app_purchase] Fix in_app_purchase_android/README.md #4363

Uda-Titor · 2021-09-18T00:43:58Z

Fix broken README link.

Related URL
#4351

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

google-cla · 2021-09-18T00:44:01Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

mvanbeusekom

Hi @ryoheiudagawa1995, thanks for the PR. I have two small requests.

Relative links won't work when packages are uploaded to pub.dev so I suggest to update to a full web address (see review comment).

Second please update the version in the pubspec.yaml and CHANGELOG.md files as most people read the README on pub.dev which means this change needs to be published.

mvanbeusekom · 2021-09-20T14:24:47Z

packages/in_app_purchase/in_app_purchase_android/README.md

@@ -24,6 +24,6 @@ If you would like to contribute to the plugin, check out our
 [contribution guide](https://github.com/flutter/plugins/blob/master/CONTRIBUTING.md).


-[1]: ../in_app_purchase/in_app_purchase
+[1]: ../in_app_purchase


Relative links won't work on pub.dev so let's update this to:

Suggested change

[1]: ../in_app_purchase

[1]: https://github.com/flutter/plugins/tree/master/packages/in_app_purchase/in_app_purchase

I fixed in
2a81932

…se_android/README.md

Uda-Titor · 2021-09-21T05:30:59Z

Thanks for the advice.

I fixed two small requests.

mvanbeusekom

Sorry I realised the link should better point to the in_app_purchase package on pub.dev so left another suggestion. Also a nit in the description for the CHANGELOG.

mvanbeusekom · 2021-09-21T06:47:16Z

packages/in_app_purchase/in_app_purchase_android/README.md

@@ -24,6 +24,6 @@ If you would like to contribute to the plugin, check out our
 [contribution guide](https://github.com/flutter/plugins/blob/master/CONTRIBUTING.md).


-[1]: ../in_app_purchase/in_app_purchase
+[1]: https://github.com/flutter/plugins/tree/master/packages/in_app_purchase


@ryoheiudagawa1995, I think it is better to point to the repository of in_app_purchase package it self (which would be https://github.com/flutter/plugins/tree/master/packages/in_app_purchase/in_app_purchase, since that is wat the text is also referring to (to the in_app_purchase package). Thinking about it, it would make even more sense to point to the package on pub.dev as that is where most users would retrieve it from.

Should have thought about that the first time (sorry) but maybe you can do another update and change it to:

Suggested change

[1]: https://github.com/flutter/plugins/tree/master/packages/in_app_purchase

[1]: https://pub.dev/packages/in_app_purchase

mvanbeusekom · 2021-09-21T06:51:06Z

packages/in_app_purchase/in_app_purchase_android/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 0.1.4+8
+
+* Fix broken link in packages/in_app_purchase/in_app_purchase_android/README.


Since the CHANGELOG is already part of the packages/in_app_purchase/in_app_purchase_android folder you can leave this out of the comment as it is more difficult to read and might confuse users. The following should suffice:

Suggested change

* Fix broken link in packages/in_app_purchase/in_app_purchase_android/README.

* Fix a broken link in the README.

mvanbeusekom

LGTM, thank you for this change and your patience.

I will add the wait for tree to go green label and the PR will be merged automatically when all steps go green.

Uda-Titor · 2021-09-25T01:33:57Z

@mvanbeusekom

It looks like the CI never ends.
How can I run CI again?

cyanglaz · 2021-09-26T02:55:20Z

~~Landing without waiting for green as it is a README only change, the CI seems to be stuck and it's not worth~~ ~~waiting for another round of CI to land this.~~
~~I doubled checked upstream is green.~~

CC @stuartmorgan

Actually, I can't merge it. I think the ci.yaml validation is required for manual merge and it is also stuck. @ryoheiudagawa1995 if you want to re-trigger the CI, you can do:
git commit -m "retrigger ci" --allow-empty & git push

fluttergithubbot · 2021-09-27T01:28:05Z

This pull request is not suitable for automatic merging in its current state.

The status or check suite publishable has failed. Please fix the issues identified (or deflake) before re-applying this label.

google-cla · 2021-09-27T13:38:15Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

mvanbeusekom · 2021-09-30T08:20:30Z

@ryoheiudagawa1995, sorry for the inconvenience but there is a conflict regarding the version numbers in the CHANGELOG.md and pubspec.yaml. Could you merge / rebase with the latest master branch and push the update? This should also fix the tree and I will make sure the PR is merged a.s.a.p.

…se_android/README.md

…ter/plugins#4363)

* master: [google_maps_flutter] Add Marker drag events (flutter#2838) [flutter_plugin_tools] Validate pubspec description (flutter#4396) Add file_selector to the repo list (flutter#4395) [in_app_purchase] Fix in_app_purchase_android/README.md (flutter#4363) [google_maps_flutter_web] Add Marker drag events (flutter#4385) [webview_flutter] Fixed todos in FlutterWebView.java (flutter#4394) Handle `PurchaseStatus.restored` correctly in example. (flutter#4393) Handle restored purchases in iOS example app (flutter#4392) [file_selector] Remove custom analysis options (flutter#4382) [flutter_plugin_tools] Check licenses in Kotlin (flutter#4373) Fixed _CastError when running example App (flutter#4390) [in_app_purchase] Ensure the introductoryPriceMicros field is transported as a String. (flutter#4370) Load navigation controls immediately. (flutter#4377) [camera] Fix IllegalStateException being thrown in Android implementation when switching activities. (flutter#4319) # Conflicts: # packages/webview_flutter/webview_flutter/CHANGELOG.md # packages/webview_flutter/webview_flutter_android/CHANGELOG.md

* master: (1126 commits) [webview_flutter] Adjust test URLs again (flutter#4407) [google_sign_in] Add serverAuthCode attribute to google_sign_in_platform_interface user data (flutter#4179) [camera] Add filter for unsupported cameras on Android (flutter#4418) [webview_flutter] Update webview platform interface with new methods for running JavaScript. (flutter#4401) [webview_flutter] Add zoomEnabled to webview flutter platform interface (flutter#4404) [ci] Remove obsolete Dockerfile (flutter#4405) Fix order-dependant platform interface tests (flutter#4406) [google_maps_flutter]: LatLng longitude loses precision in constructor #90574 (flutter#4374) [google_maps_flutter] Add Marker drag events (flutter#2838) [flutter_plugin_tools] Validate pubspec description (flutter#4396) Add file_selector to the repo list (flutter#4395) [in_app_purchase] Fix in_app_purchase_android/README.md (flutter#4363) [google_maps_flutter_web] Add Marker drag events (flutter#4385) [webview_flutter] Fixed todos in FlutterWebView.java (flutter#4394) Handle `PurchaseStatus.restored` correctly in example. (flutter#4393) Handle restored purchases in iOS example app (flutter#4392) [file_selector] Remove custom analysis options (flutter#4382) [flutter_plugin_tools] Check licenses in Kotlin (flutter#4373) Fixed _CastError when running example App (flutter#4390) [in_app_purchase] Ensure the introductoryPriceMicros field is transported as a String. (flutter#4370) ... # Conflicts: # packages/quick_actions/ios/Classes/FLTQuickActionsPlugin.m

Uda-Titor requested review from cyanglaz and LHLL as code owners September 18, 2021 00:43

google-cla bot added the cla: no label Sep 18, 2021

github-actions bot added p: in_app_purchase platform-android labels Sep 18, 2021

Fix broken README link.

27af99e

Uda-Titor force-pushed the fix/in_app_purchase_android/README.md branch from d4c8ff6 to 27af99e Compare September 18, 2021 00:53

google-cla bot added cla: yes and removed cla: no labels Sep 18, 2021

mvanbeusekom suggested changes Sep 20, 2021

View reviewed changes

Uda-Titor added 4 commits September 21, 2021 14:14

fix: in README.md in_app_purchase_android

2a81932

fix: pubspec.yml and CHANGELOG.md

24409e6

Merge remote-tracking branch 'upstream/master' into fix/in_app_purcha…

aa2a2f0

…se_android/README.md

update: in_app_purchase_android/pubspec.yaml

e87c38d

mvanbeusekom suggested changes Sep 21, 2021

View reviewed changes

fix: in_app_purchase_android/README.md

62ad56b

mvanbeusekom approved these changes Sep 21, 2021

View reviewed changes

mvanbeusekom added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Sep 21, 2021

retrigger ci

37e7f28

fluttergithubbot removed the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Sep 27, 2021

google-cla bot added cla: no and removed cla: yes labels Sep 27, 2021

github-actions bot added the platform-ios label Sep 27, 2021

Uda-Titor force-pushed the fix/in_app_purchase_android/README.md branch from dd85b55 to 37e7f28 Compare September 27, 2021 13:40

google-cla bot added cla: yes and removed cla: no labels Sep 27, 2021

github-actions bot removed the platform-ios label Sep 27, 2021

Merge remote-tracking branch 'upstream/master' into fix/in_app_purcha…

f6325f5

…se_android/README.md

mvanbeusekom added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Sep 30, 2021

fluttergithubbot merged commit 5e54355 into flutter:master Sep 30, 2021

engine-flutter-autoroll mentioned this pull request Sep 30, 2021

Roll Plugins from 90b2844ce7e5 to 63eb67532a7a (2 revisions) flutter/flutter#91039

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 30, 2021

5e54355 [in_app_purchase] Fix in_app_purchase_android/README.md (flut…

75ca595

…ter/plugins#4363)

amantoux pushed a commit to amantoux/plugins that referenced this pull request Dec 11, 2021

[in_app_purchase] Fix in_app_purchase_android/README.md (flutter#4363)

879591a

KyleFin pushed a commit to KyleFin/plugins that referenced this pull request Dec 21, 2021

[in_app_purchase] Fix in_app_purchase_android/README.md (flutter#4363)

1d518d8

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[in_app_purchase] Fix in_app_purchase_android/README.md #4363

[in_app_purchase] Fix in_app_purchase_android/README.md #4363

Uda-Titor commented Sep 18, 2021 •

edited

Loading

google-cla bot commented Sep 18, 2021

mvanbeusekom left a comment

mvanbeusekom Sep 20, 2021

Uda-Titor Sep 21, 2021 •

edited

Loading

Uda-Titor commented Sep 21, 2021

mvanbeusekom left a comment

mvanbeusekom Sep 21, 2021

mvanbeusekom Sep 21, 2021

mvanbeusekom left a comment •

edited

Loading

Uda-Titor commented Sep 25, 2021

cyanglaz commented Sep 26, 2021 •

edited

Loading

fluttergithubbot commented Sep 27, 2021

google-cla bot commented Sep 27, 2021

mvanbeusekom commented Sep 30, 2021

	[1]: ../in_app_purchase
	[1]: https://github.com/flutter/plugins/tree/master/packages/in_app_purchase/in_app_purchase

	[1]: https://github.com/flutter/plugins/tree/master/packages/in_app_purchase
	[1]: https://pub.dev/packages/in_app_purchase

		@@ -1,3 +1,7 @@
		## 0.1.4+8

		* Fix broken link in packages/in_app_purchase/in_app_purchase_android/README.

	* Fix broken link in packages/in_app_purchase/in_app_purchase_android/README.
	* Fix a broken link in the README.

[in_app_purchase] Fix in_app_purchase_android/README.md #4363

[in_app_purchase] Fix in_app_purchase_android/README.md #4363

Conversation

Uda-Titor commented Sep 18, 2021 • edited Loading

Pre-launch Checklist

google-cla bot commented Sep 18, 2021

mvanbeusekom left a comment

Choose a reason for hiding this comment

mvanbeusekom Sep 20, 2021

Choose a reason for hiding this comment

Uda-Titor Sep 21, 2021 • edited Loading

Choose a reason for hiding this comment

Uda-Titor commented Sep 21, 2021

mvanbeusekom left a comment

Choose a reason for hiding this comment

mvanbeusekom Sep 21, 2021

Choose a reason for hiding this comment

mvanbeusekom Sep 21, 2021

Choose a reason for hiding this comment

mvanbeusekom left a comment • edited Loading

Choose a reason for hiding this comment

Uda-Titor commented Sep 25, 2021

cyanglaz commented Sep 26, 2021 • edited Loading

fluttergithubbot commented Sep 27, 2021

google-cla bot commented Sep 27, 2021

mvanbeusekom commented Sep 30, 2021

Uda-Titor commented Sep 18, 2021 •

edited

Loading

Uda-Titor Sep 21, 2021 •

edited

Loading

mvanbeusekom left a comment •

edited

Loading

cyanglaz commented Sep 26, 2021 •

edited

Loading