[google_maps_flutter]: LatLng longitude loses precision in constructor #90574

[Murray-Meller]

This PR helps avoid unnecessary loss of longitude precision in the LatLng constructor.

See issue for more details.

Issues:

Fixes flutter/flutter#90574

Pre-launch Checklist

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
• I read the Tree Hygiene wiki page, which explains my responsibilities.
• I read and followed the relevant style guides and ran the auto-formatter. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
• I signed the CLA.
• The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
• I listed at least one issue that this PR fixes in the description above.
• I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
• I updated CHANGELOG.md to add a description of the change.
• I updated/added relevant documentation (doc comments with ///).
• I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
• All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

[google-cla]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

[Murray-Meller]

@googlebot I signed it!

[google-cla]

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

[MurrayMeller]

@googlebot I consent.

[stuartmorgan]

Two minor comment nits, but otherwise looks great. Thanks for all the added test coverage!

[Murray-Meller]

Thanks for the review, @stuartmorgan. I have addressed both your comments.

I was wondering if you'd be able to help me understand more about my pipeline failures, where I could look and what I could do to get them fixed?

Incase it changes, these checks were failing:

• ci.yaml validation
• submit-queue

[ditman]

Incase it changes, these checks were failing:

ci.yaml validation
submit-queue

I can explain:

• submit-queue tracks the status of tests of the commits in the master branch of flutter/plugins. If the tests don't pass in master, other PRs are blocked, until master recovers.
• ci.yaml validation validates that the config for one of our continuous integration systems (LUCI) is OK. The case why it fails is because of a transient error, or because the branch was forked off at a point in master where the test was broken (and a fix was missing). (I checked this branch, and I didn't see any changes related to that validation, so it's probably a transient failure, and I restarted the check.)

[stuartmorgan]

LGTM

[stuartmorgan]

Adding @ditman for secondary review per Flutter policy.

[ditman]

LGTM!

[MurrayMeller]

Thanks @stuartmorgan & @ditman.

One last question if I may, what is the timeline/process for this making it into a plugin release?

[ditman]

One last question if I may, what is the timeline/process for this making it into a plugin release?

@MurrayMeller For each push to master, a set of post-submit + release actions are generated. See them here for this PR:

• https://github.com/flutter/plugins/runs/3769724548

When all the "Cirrus CI" tests pass, the "Release" action gets triggered, and if that's successful, it's already available to people:

• https://pub.dev/packages/google_maps_flutter_platform_interface/changelog#213

(A flutter pub upgrade should grab the latest available version of the platform_interface package)

[MurrayMeller]

Thank again, @ditman. Much appreciated.

[ditman]

@MurrayMeller thanks again for your contribution!! Keep them coming!