Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Remove some trivial custom analysis options files #4379

Merged
merged 4 commits into from
Sep 24, 2021
Merged

Remove some trivial custom analysis options files #4379

merged 4 commits into from
Sep 24, 2021

Conversation

stuartmorgan
Copy link
Contributor

Remove a few of the trivial-to-fix legacy analysis option files that were bulk added in the transition to matching flutter/flutter's analysis options.

Part of flutter/flutter#76229

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

@google-cla google-cla bot added the cla: yes label Sep 23, 2021
gaaclarke
gaaclarke approved these changes Sep 23, 2021
View reviewed changes
Copy link
Member

@gaaclarke gaaclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@stuartmorgan stuartmorgan merged commit d3c892f into flutter:master Sep 24, 2021
@stuartmorgan stuartmorgan deleted the custom-analysis-options-simple branch September 24, 2021 02:38
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 24, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 24, 2021
@engine-flutter-autoroll
d3c892f Remove some trivial custom analysis options files (flutter/pl…
e1e0802 
…ugins#4379)
fluttergithubbot pushed a commit to flutter/flutter that referenced this pull request Sep 24, 2021
@engine-flutter-autoroll
d3c892f Remove some trivial custom analysis options files (flutter/pl…
37c1d87 
…ugins#4379) (#90649)
amantoux pushed a commit to amantoux/plugins that referenced this pull request Sep 27, 2021
@stuartmorgan @amantoux
Remove some trivial custom analysis options files (flutter#4379)
fdeabcb 
Remove a few of the trivial-to-fix legacy analysis option files that were bulk added in the transition to matching flutter/flutter's analysis options.

Part of flutter/flutter#76229
NickalasB added a commit to NickalasB/plugins that referenced this pull request Sep 27, 2021
@NickalasB
Merge branch 'master' into add_zoom_to_android_webview
8dd870b 
* master: (51 commits)
  [webview_flutter] Update version number app_facing package (flutter#4375)
  [webview_flutter] Adjust integration test domains (flutter#4383)
  Remove some trivial custom analysis options files (flutter#4379)
  [google_maps_flutter_platfomr_interface] Add Marker drag events (flutter#2653)
  [flutter_plugin_tools] Improve version check error handling (flutter#4376)
  [flutter_plugin_tools] Allow overriding breaking change check (flutter#4369)
  [url_launcher] Error handling when URL cannot be parsed with Uri.parse (flutter#4365)
  [webview_flutter] Migrate main package to fully federated architecture. (flutter#4366)
  [google_sign_in] Bump minimum Flutter version and iOS deployment target (flutter#4334)
  Add false secret lists, and enforce ordering (flutter#4372)
  [camera_web] Update usage documentation (flutter#4371)
  [video_player] VTT Support (flutter#2878)
  Require authors file (flutter#4367)
  [flutter_plugin_tools] Fix federated safety check (flutter#4368)
  [webview_flutter] Extract WKWebView implementation into a separate package (flutter#4345)
  [webview_flutter] Extract Android implementation into a separate package (flutter#4343)
  [in_app_purchase] Ensure the `introductoryPriceMicros` field is populated correctly. (flutter#4364)
  [flutter_plugin_tools] Add a federated PR safety check (flutter#4329)
  [camera] Add web support (flutter#4240)
  [webview_flutter] Bump minimum Flutter version and iOS deployment target (flutter#4361)
  ...

# Conflicts:
#	packages/webview_flutter/webview_flutter/lib/platform_interface.dart
#	packages/webview_flutter/webview_flutter/lib/src/webview_method_channel.dart
#	packages/webview_flutter/webview_flutter/lib/webview_flutter.dart
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Oct 29, 2021
@engine-flutter-autoroll @clocksmith
d3c892f Remove some trivial custom analysis options files (flutter/pl…
88667d3 
…ugins#4379) (flutter#90649)
KyleFin pushed a commit to KyleFin/plugins that referenced this pull request Dec 21, 2021
@stuartmorgan @KyleFin
Remove some trivial custom analysis options files (flutter#4379)
b0ff6be 
Remove a few of the trivial-to-fix legacy analysis option files that were bulk added in the transition to matching flutter/flutter's analysis options.

Part of flutter/flutter#76229
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gaaclarke gaaclarke gaaclarke approved these changes

Assignees
No one assigned
Labels
cla: yes p: cross_file p: flutter_plugin_android_lifecycle p: plugin_platform_interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stuartmorgan @gaaclarke