Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[flutter_plugin_tools] Improve version check error handling #4376

Merged
merged 4 commits into from
Sep 23, 2021
Merged

[flutter_plugin_tools] Improve version check error handling #4376

merged 4 commits into from
Sep 23, 2021

Conversation

stuartmorgan
Copy link
Contributor

Catches invalid CHANGELOG formats and logs useful error messages for them,
rather than throwing FormatExceptions.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

@stuartmorgan
[flutter_plugin_tools] Improve version check error handling
08205ee 
Catches invalid CHANGELOG formats and logs useful error messages for them,
rather than throwing FormatExceptions.
@stuartmorgan stuartmorgan requested a review from ditman September 23, 2021 14:38
@google-cla google-cla bot added the cla: yes label Sep 23, 2021
ditman
ditman approved these changes Sep 23, 2021
View reviewed changes
Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

script/tool/lib/src/version_check_command.dart Outdated Show resolved Hide resolved
script/tool/test/version_check_command_test.dart Show resolved Hide resolved
@stuartmorgan @ditman
Fix string
16767e5 
Co-authored-by: David Iglesias <[email protected]>
@stuartmorgan stuartmorgan added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Sep 23, 2021
@fluttergithubbot
Copy link

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite ios-platform_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot fluttergithubbot removed the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Sep 23, 2021
@stuartmorgan stuartmorgan merged commit d2c6c43 into flutter:master Sep 23, 2021
@stuartmorgan stuartmorgan deleted the changelog-exception-fix branch September 23, 2021 19:40
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 23, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 23, 2021
@engine-flutter-autoroll
d2c6c43 [flutter_plugin_tools] Improve version check error handling (f…
7e28aa7 
…lutter/plugins#4376)
amantoux pushed a commit to amantoux/plugins that referenced this pull request Sep 27, 2021
@stuartmorgan @amantoux
[flutter_plugin_tools] Improve version check error handling (flutter#…
dfdac3e 
…4376)

Catches invalid CHANGELOG formats and logs useful error messages for them,
rather than throwing FormatExceptions.
NickalasB added a commit to NickalasB/plugins that referenced this pull request Sep 27, 2021
@NickalasB
Merge branch 'master' into add_zoom_to_android_webview
8dd870b 
* master: (51 commits)
  [webview_flutter] Update version number app_facing package (flutter#4375)
  [webview_flutter] Adjust integration test domains (flutter#4383)
  Remove some trivial custom analysis options files (flutter#4379)
  [google_maps_flutter_platfomr_interface] Add Marker drag events (flutter#2653)
  [flutter_plugin_tools] Improve version check error handling (flutter#4376)
  [flutter_plugin_tools] Allow overriding breaking change check (flutter#4369)
  [url_launcher] Error handling when URL cannot be parsed with Uri.parse (flutter#4365)
  [webview_flutter] Migrate main package to fully federated architecture. (flutter#4366)
  [google_sign_in] Bump minimum Flutter version and iOS deployment target (flutter#4334)
  Add false secret lists, and enforce ordering (flutter#4372)
  [camera_web] Update usage documentation (flutter#4371)
  [video_player] VTT Support (flutter#2878)
  Require authors file (flutter#4367)
  [flutter_plugin_tools] Fix federated safety check (flutter#4368)
  [webview_flutter] Extract WKWebView implementation into a separate package (flutter#4345)
  [webview_flutter] Extract Android implementation into a separate package (flutter#4343)
  [in_app_purchase] Ensure the `introductoryPriceMicros` field is populated correctly. (flutter#4364)
  [flutter_plugin_tools] Add a federated PR safety check (flutter#4329)
  [camera] Add web support (flutter#4240)
  [webview_flutter] Bump minimum Flutter version and iOS deployment target (flutter#4361)
  ...

# Conflicts:
#	packages/webview_flutter/webview_flutter/lib/platform_interface.dart
#	packages/webview_flutter/webview_flutter/lib/src/webview_method_channel.dart
#	packages/webview_flutter/webview_flutter/lib/webview_flutter.dart
KyleFin pushed a commit to KyleFin/plugins that referenced this pull request Dec 21, 2021
@stuartmorgan @KyleFin
[flutter_plugin_tools] Improve version check error handling (flutter#…
389773b 
…4376)

Catches invalid CHANGELOG formats and logs useful error messages for them,
rather than throwing FormatExceptions.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ditman ditman ditman approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stuartmorgan @fluttergithubbot @ditman