This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[in_app_purchase] Ensure the introductoryPriceMicros
field is populated correctly.
#4364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the SKUDetailsWrapper map used in the unit test to match the output from the JAVA code and causes the tests to fail (proving issue 90244).
The SKUDetailsWrapper property is send using a JSON key with the name `introductoryPriceAmountMicros`. This commit updates the JSON key to use the correct name and makes sure it passes all unit tests again.
Update version to 0.1.4+7 and added a change description to the CHANGELOG.md.
cyanglaz
approved these changes
Sep 20, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mvanbeusekom
added
the
waiting for tree to go green
(Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.
label
Sep 20, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 20, 2021
…is populated correctly. (flutter/plugins#4364)
fluttergithubbot
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 20, 2021
…is populated correctly. (flutter/plugins#4364) (#90412)
I believe this commit breaks queryProductDetails on Android, because the defaultValue for this field is set to be a string, when it should be an int. As a result, I am getting |
Will provide a fix today. |
mvanbeusekom
added a commit
to Baseflow/flutter-plugins
that referenced
this pull request
Sep 22, 2021
Update the unit test so it tests for the introductoryPriceAmountMicros field to be of type String. This test will be failing to prove the issue described here flutter#4364 (comment).
mvanbeusekom
added a commit
to Baseflow/flutter-plugins
that referenced
this pull request
Sep 22, 2021
Converts the introductoryPriceAmountMicros field to a String value before it is send as JSON string from Java to Dart. This will solve the issue (flutter#4364 (comment)) in a non-breaking manor (updating the type on the Dart side would introduce a breaking change).
mvanbeusekom
added a commit
to Baseflow/flutter-plugins
that referenced
this pull request
Sep 22, 2021
Update the unit test so it tests for the introductoryPriceAmountMicros field to be of type String. This test will be failing to prove the issue described here flutter#4364 (comment).
mvanbeusekom
added a commit
to Baseflow/flutter-plugins
that referenced
this pull request
Sep 22, 2021
Converts the introductoryPriceAmountMicros field to a String value before it is send as JSON string from Java to Dart. This will solve the issue (flutter#4364 (comment)) in a non-breaking manor (updating the type on the Dart side would introduce a breaking change).
11 tasks
amantoux
pushed a commit
to amantoux/plugins
that referenced
this pull request
Sep 27, 2021
This was referenced Sep 27, 2021
NickalasB
added a commit
to NickalasB/plugins
that referenced
this pull request
Sep 27, 2021
* master: (51 commits) [webview_flutter] Update version number app_facing package (flutter#4375) [webview_flutter] Adjust integration test domains (flutter#4383) Remove some trivial custom analysis options files (flutter#4379) [google_maps_flutter_platfomr_interface] Add Marker drag events (flutter#2653) [flutter_plugin_tools] Improve version check error handling (flutter#4376) [flutter_plugin_tools] Allow overriding breaking change check (flutter#4369) [url_launcher] Error handling when URL cannot be parsed with Uri.parse (flutter#4365) [webview_flutter] Migrate main package to fully federated architecture. (flutter#4366) [google_sign_in] Bump minimum Flutter version and iOS deployment target (flutter#4334) Add false secret lists, and enforce ordering (flutter#4372) [camera_web] Update usage documentation (flutter#4371) [video_player] VTT Support (flutter#2878) Require authors file (flutter#4367) [flutter_plugin_tools] Fix federated safety check (flutter#4368) [webview_flutter] Extract WKWebView implementation into a separate package (flutter#4345) [webview_flutter] Extract Android implementation into a separate package (flutter#4343) [in_app_purchase] Ensure the `introductoryPriceMicros` field is populated correctly. (flutter#4364) [flutter_plugin_tools] Add a federated PR safety check (flutter#4329) [camera] Add web support (flutter#4240) [webview_flutter] Bump minimum Flutter version and iOS deployment target (flutter#4361) ... # Conflicts: # packages/webview_flutter/webview_flutter/lib/platform_interface.dart # packages/webview_flutter/webview_flutter/lib/src/webview_method_channel.dart # packages/webview_flutter/webview_flutter/lib/webview_flutter.dart
clocksmith
pushed a commit
to clocksmith/flutter
that referenced
this pull request
Oct 29, 2021
…is populated correctly. (flutter/plugins#4364) (flutter#90412)
KyleFin
pushed a commit
to KyleFin/plugins
that referenced
this pull request
Dec 21, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
cla: yes
p: in_app_purchase
platform-android
waiting for tree to go green
(Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a typo the
SkuDetailsWrapper.introductoryPriceMicros
field wasn't populated correctly with the values send from the native side.The first commit of this PR updates the existing unit tests to prove the existence of the issue. The second commit fixes the implementation of the
SkuDetailsWrapper
class so the tests succeed and populate the field correctly.Fixes flutter/flutter#90244
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
dart format
.)[shared_preferences]
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.