Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[flutter_plugin_tools] Adjust diff logging #4312

Merged
merged 1 commit into from
Sep 3, 2021
Merged

[flutter_plugin_tools] Adjust diff logging #4312

merged 1 commit into from
Sep 3, 2021

Conversation

stuartmorgan
Copy link
Contributor

@stuartmorgan stuartmorgan commented Sep 3, 2021 •
edited
Loading

Moves diff logging out of a helper, which would not be expected to do
logging, and into specific commands where logging the diff base is
useful.

Fixes some log spam during tests as a side effect.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

@stuartmorgan
[flutter_plugin_tools] Adjust diff logging
bdc6867 
Moves diff logging out of a helper, which would not be expected to do
logging, and into specific commands where logging the diff base is
useful.

Fixes some log spam during tests as a side effect.
@stuartmorgan stuartmorgan requested a review from Hixie September 3, 2021 20:40
@google-cla google-cla bot added the cla: yes label Sep 3, 2021
Hixie
Hixie approved these changes Sep 3, 2021
View reviewed changes
Copy link
Contributor

@Hixie Hixie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan stuartmorgan added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Sep 3, 2021
@fluttergithubbot fluttergithubbot merged commit 300100b into flutter:master Sep 3, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 3, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 3, 2021
@engine-flutter-autoroll
300100b [flutter_plugin_tools] Adjust diff logging (flutter/plugins#4312
e86f035 
)
@stuartmorgan stuartmorgan deleted the tool-diff-logging-fix branch September 4, 2021 02:36
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 4, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 4, 2021
@engine-flutter-autoroll
300100b [flutter_plugin_tools] Adjust diff logging (flutter/plugins#4312
7c172b5 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 4, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 4, 2021
@engine-flutter-autoroll
300100b [flutter_plugin_tools] Adjust diff logging (flutter/plugins#4312
e8c958f 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 5, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 5, 2021
@engine-flutter-autoroll
300100b [flutter_plugin_tools] Adjust diff logging (flutter/plugins#4312
c34c0fe 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 5, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 5, 2021
@engine-flutter-autoroll
300100b [flutter_plugin_tools] Adjust diff logging (flutter/plugins#4312
6f3adb7 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 5, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 5, 2021
@engine-flutter-autoroll
300100b [flutter_plugin_tools] Adjust diff logging (flutter/plugins#4312
8b81b16 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 6, 2021
@engine-flutter-autoroll
300100b [flutter_plugin_tools] Adjust diff logging (flutter/plugins#4312
03a67f4 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 6, 2021
@engine-flutter-autoroll
300100b [flutter_plugin_tools] Adjust diff logging (flutter/plugins#4312
ea8b3a8 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 6, 2021
@engine-flutter-autoroll
300100b [flutter_plugin_tools] Adjust diff logging (flutter/plugins#4312
e61e329 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 7, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 7, 2021
@engine-flutter-autoroll
300100b [flutter_plugin_tools] Adjust diff logging (flutter/plugins#4312
a11c852 
)
NickalasB added a commit to NickalasB/plugins that referenced this pull request Sep 7, 2021
@NickalasB
Merge branch 'master' into add_zoom_to_android_webview
a5f2be6 
* master: (490 commits)
  Allow neutral conclusion in publishing check (flutter#4321)
  Revert "[image_picker] add forceFullMetadata to interface" (flutter#4314)
  [image_picker] add forceFullMetadata to interface (flutter#4288)
  [flutter_plugin_tools] Adjust diff logging (flutter#4312)
  Remove gradle.properties from plugins (flutter#4309)
  build-examples .pluginToolsConfig.yaml support (flutter#4305)
  [camera_web] Make plugin publishable for the first time. (flutter#4304)
  adds option to re-authenticate on google silent sign in (flutter#4251)
  [ci.yaml] Add builders to recipes cq (flutter#4306)
  Add scripts for Windows LUCI recipe (flutter#4303)
  [video_player] Ensure seekTo is not called before video player is initialized.  (flutter#4300)
  Ensure setExposureOffset returns new value on Android (flutter#4301)
  Add a way to opt a file out of Dart formatting (flutter#4292)
  [flutter_plugin_tools] Add Linux support to native-test (flutter#4294)
  [image_picker]Android update cache (flutter#4124)
  [flutter_plugin_tools] Fix build-examples for packages (flutter#4248)
  [flutter_plugin_tool] Migrate 'publish' to new base command (flutter#4290)
  [flutter_plugin_tool] Move branch-switching logic from tool_runner.sh to tool (flutter#4268)
  [flutter_plugin_tool] Add support for running Windows unit tests (flutter#4276)
  [camera_web] Do not flip the video on the back camera (flutter#4281)
  ...

# Conflicts:
#	packages/webview_flutter/webview_flutter/CHANGELOG.md
#	packages/webview_flutter/webview_flutter/android/src/main/java/io/flutter/plugins/webviewflutter/FlutterWebView.java
#	packages/webview_flutter/webview_flutter/pubspec.yaml
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 7, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 7, 2021
@engine-flutter-autoroll
300100b [flutter_plugin_tools] Adjust diff logging (flutter/plugins#4312
a472686 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 8, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 8, 2021
@engine-flutter-autoroll
300100b [flutter_plugin_tools] Adjust diff logging (flutter/plugins#4312
6223a0b 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 8, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 8, 2021
@engine-flutter-autoroll
300100b [flutter_plugin_tools] Adjust diff logging (flutter/plugins#4312
9110383 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 8, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 8, 2021
@engine-flutter-autoroll
300100b [flutter_plugin_tools] Adjust diff logging (flutter/plugins#4312
3352740 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 8, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 8, 2021
@engine-flutter-autoroll
300100b [flutter_plugin_tools] Adjust diff logging (flutter/plugins#4312
609a61c 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 8, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 8, 2021
@engine-flutter-autoroll
300100b [flutter_plugin_tools] Adjust diff logging (flutter/plugins#4312
a504a38 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 9, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 9, 2021
@engine-flutter-autoroll
300100b [flutter_plugin_tools] Adjust diff logging (flutter/plugins#4312
bc4bf83 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 9, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 9, 2021
@engine-flutter-autoroll
300100b [flutter_plugin_tools] Adjust diff logging (flutter/plugins#4312
9afe521 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 9, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 9, 2021
@engine-flutter-autoroll
300100b [flutter_plugin_tools] Adjust diff logging (flutter/plugins#4312
a859c9a 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 9, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 9, 2021
@engine-flutter-autoroll
300100b [flutter_plugin_tools] Adjust diff logging (flutter/plugins#4312
1792e8a 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 9, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 9, 2021
@engine-flutter-autoroll
300100b [flutter_plugin_tools] Adjust diff logging (flutter/plugins#4312
4aed945 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 9, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 9, 2021
@engine-flutter-autoroll
300100b [flutter_plugin_tools] Adjust diff logging (flutter/plugins#4312
154171a 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 9, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 9, 2021
@engine-flutter-autoroll
300100b [flutter_plugin_tools] Adjust diff logging (flutter/plugins#4312
9c252dc 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 9, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 9, 2021
@engine-flutter-autoroll
300100b [flutter_plugin_tools] Adjust diff logging (flutter/plugins#4312
8044ca2 
)
fotiDim pushed a commit to fotiDim/plugins that referenced this pull request Sep 13, 2021
@stuartmorgan @fotiDim
[flutter_plugin_tools] Adjust diff logging (flutter#4312)
1321dbd
amantoux pushed a commit to amantoux/plugins that referenced this pull request Sep 27, 2021
@stuartmorgan @amantoux
[flutter_plugin_tools] Adjust diff logging (flutter#4312)
e5a89d5
KyleFin pushed a commit to KyleFin/plugins that referenced this pull request Dec 21, 2021
@stuartmorgan @KyleFin
[flutter_plugin_tools] Adjust diff logging (flutter#4312)
ffbb497
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Hixie Hixie Hixie approved these changes

Assignees
No one assigned
Labels
cla: yes waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stuartmorgan @Hixie @fluttergithubbot