Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Add scripts for Windows LUCI recipe #4303

Merged
merged 3 commits into from
Sep 2, 2021

Conversation

stuartmorgan
Copy link
Contributor

See flutter/flutter#89373 for context. This
sets up the script and config file to replicate the current plugins.py
recipe's behavior using the planned generic recipe.

These are currently unused, but are being landed first so that the
generic recipe has something to test against.

Part of flutter/flutter#89373

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

See flutter/flutter#89373 for context. This
sets up the script and config file to replicate the current plugins.py
recipe's behavior using the planned generic recipe.

These are currently unused, but are being landed first so that the
generic recipe has something to test against.

Part of flutter/flutter#89373
Copy link

@CaseyHillers CaseyHillers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@christopherfujino has put a lot of thought into the single recipe design, so I'll let him check this aligns with it

@@ -0,0 +1,7 @@
#!/bin/bash

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL our windows bots have bash, sounds like I can do some cleanup :-)

Copy link
Contributor Author

@stuartmorgan stuartmorgan Sep 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line wouldn't actually work on the Windows bot presumably (they run it with bash foo.sh), but I kept it for consistency with the existing bash scripts in the repo.

Copy link
Member

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan
Copy link
Contributor Author

submit-queue is wrong again; landing manually.

@stuartmorgan stuartmorgan merged commit 887ba2d into flutter:master Sep 2, 2021
@stuartmorgan stuartmorgan deleted the windows-luci-setup branch September 2, 2021 17:04
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 2, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 2, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 2, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 3, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 3, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 3, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 3, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 3, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 3, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 8, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 8, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 8, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 8, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 8, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 9, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 9, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 9, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 9, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 9, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 9, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 9, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 9, 2021
fotiDim pushed a commit to fotiDim/plugins that referenced this pull request Sep 13, 2021
See flutter/flutter#89373 for context. This
sets up the script and config file to replicate the current plugins.py
recipe's behavior using the planned generic recipe.

These are currently unused, but are being landed first so that the
generic recipe has something to test against.

Part of flutter/flutter#89373
amantoux pushed a commit to amantoux/plugins that referenced this pull request Sep 27, 2021
See flutter/flutter#89373 for context. This
sets up the script and config file to replicate the current plugins.py
recipe's behavior using the planned generic recipe.

These are currently unused, but are being landed first so that the
generic recipe has something to test against.

Part of flutter/flutter#89373
KyleFin pushed a commit to KyleFin/plugins that referenced this pull request Dec 21, 2021
See flutter/flutter#89373 for context. This
sets up the script and config file to replicate the current plugins.py
recipe's behavior using the planned generic recipe.

These are currently unused, but are being landed first so that the
generic recipe has something to test against.

Part of flutter/flutter#89373
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants