-
Notifications
You must be signed in to change notification settings - Fork 9.8k
Conversation
See flutter/flutter#89373 for context. This sets up the script and config file to replicate the current plugins.py recipe's behavior using the planned generic recipe. These are currently unused, but are being landed first so that the generic recipe has something to test against. Part of flutter/flutter#89373
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@christopherfujino has put a lot of thought into the single recipe design, so I'll let him check this aligns with it
@@ -0,0 +1,7 @@ | |||
#!/bin/bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIL our windows bots have bash, sounds like I can do some cleanup :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line wouldn't actually work on the Windows bot presumably (they run it with bash foo.sh
), but I kept it for consistency with the existing bash scripts in the repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
See flutter/flutter#89373 for context. This sets up the script and config file to replicate the current plugins.py recipe's behavior using the planned generic recipe. These are currently unused, but are being landed first so that the generic recipe has something to test against. Part of flutter/flutter#89373
See flutter/flutter#89373 for context. This sets up the script and config file to replicate the current plugins.py recipe's behavior using the planned generic recipe. These are currently unused, but are being landed first so that the generic recipe has something to test against. Part of flutter/flutter#89373
See flutter/flutter#89373 for context. This sets up the script and config file to replicate the current plugins.py recipe's behavior using the planned generic recipe. These are currently unused, but are being landed first so that the generic recipe has something to test against. Part of flutter/flutter#89373
See flutter/flutter#89373 for context. This
sets up the script and config file to replicate the current plugins.py
recipe's behavior using the planned generic recipe.
These are currently unused, but are being landed first so that the
generic recipe has something to test against.
Part of flutter/flutter#89373
Pre-launch Checklist
dart format
.)[shared_preferences]
///
).