Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Remove gradle.properties from plugins #4309

Merged
merged 1 commit into from
Sep 3, 2021
Merged

Remove gradle.properties from plugins #4309

merged 1 commit into from
Sep 3, 2021

Conversation

stuartmorgan
Copy link
Contributor

The plugin-level gradle.properties file is not used, only the app-level
file, so these are cruft.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

@stuartmorgan
Remove gradle.properties from plugins
e156a64 
The plugin-level gradle.properties file is not used, only the app-level
file, so these are cruft.
@stuartmorgan stuartmorgan requested a review from blasten September 3, 2021 18:47
@google-cla google-cla bot added the cla: yes label Sep 3, 2021
@stuartmorgan
Copy link
Contributor Author

Since it sounds like these are completely unused anyway, I'm not bothering with a ton of CHANGELOG updates.

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 7, 2021
@engine-flutter-autoroll
17c4149 Remove gradle.properties from plugins (flutter/plugins#4309)
1010782
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 8, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 8, 2021
@engine-flutter-autoroll
17c4149 Remove gradle.properties from plugins (flutter/plugins#4309)
4537c39
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 8, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 8, 2021
@engine-flutter-autoroll
17c4149 Remove gradle.properties from plugins (flutter/plugins#4309)
cdda964
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 8, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 8, 2021
@engine-flutter-autoroll
17c4149 Remove gradle.properties from plugins (flutter/plugins#4309)
72a3716
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 8, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 8, 2021
@engine-flutter-autoroll
17c4149 Remove gradle.properties from plugins (flutter/plugins#4309)
edc5324
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 8, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 8, 2021
@engine-flutter-autoroll
17c4149 Remove gradle.properties from plugins (flutter/plugins#4309)
04d7080
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 9, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 9, 2021
@engine-flutter-autoroll
17c4149 Remove gradle.properties from plugins (flutter/plugins#4309)
7f5d93a
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 9, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 9, 2021
@engine-flutter-autoroll
17c4149 Remove gradle.properties from plugins (flutter/plugins#4309)
8278f5f
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 9, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 9, 2021
@engine-flutter-autoroll
17c4149 Remove gradle.properties from plugins (flutter/plugins#4309)
6c076ca
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 9, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 9, 2021
@engine-flutter-autoroll
17c4149 Remove gradle.properties from plugins (flutter/plugins#4309)
4eba6e6
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 9, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 9, 2021
@engine-flutter-autoroll
17c4149 Remove gradle.properties from plugins (flutter/plugins#4309)
770dfcd
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 9, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 9, 2021
@engine-flutter-autoroll
17c4149 Remove gradle.properties from plugins (flutter/plugins#4309)
7ad0d57
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 9, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 9, 2021
@engine-flutter-autoroll
17c4149 Remove gradle.properties from plugins (flutter/plugins#4309)
f7de044
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 9, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 9, 2021
@engine-flutter-autoroll
17c4149 Remove gradle.properties from plugins (flutter/plugins#4309)
83341ea
fotiDim pushed a commit to fotiDim/plugins that referenced this pull request Sep 13, 2021
@stuartmorgan @fotiDim
Remove gradle.properties from plugins (flutter#4309)
238e383
amantoux pushed a commit to amantoux/plugins that referenced this pull request Sep 27, 2021
@stuartmorgan @amantoux
Remove gradle.properties from plugins (flutter#4309)
1e3fbfa
KyleFin pushed a commit to KyleFin/plugins that referenced this pull request Dec 21, 2021
@stuartmorgan @KyleFin
Remove gradle.properties from plugins (flutter#4309)
cde52e3
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@blasten blasten blasten approved these changes

@bparrishMines bparrishMines Awaiting requested review from bparrishMines

@cyanglaz cyanglaz Awaiting requested review from cyanglaz

@LHLL LHLL Awaiting requested review from LHLL

Assignees
No one assigned
Labels
cla: yes p: android_alarm_manager p: android_intent p: battery Edits files for a battery plugin p: camera p: connectivity p: device_info p: espresso p: flutter_plugin_android_lifecycle p: google_maps_flutter p: google_sign_in p: image_picker p: in_app_purchase p: local_auth p: package_info p: path_provider p: quick_actions p: sensors p: share p: shared_preferences p: url_launcher p: video_player p: wifi_info_flutter platform-android waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stuartmorgan @blasten @fluttergithubbot