Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

@Knupper
Copy link

@Knupper Knupper commented Jan 9, 2019

Hey,

here my implementation to add region support for cloud_functions (see #24333).

King regards

Max

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@Knupper
Copy link
Author

Knupper commented Jan 9, 2019

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Jan 9, 2019
@Knupper
Copy link
Author

Knupper commented Jan 28, 2019

Any updates or feedback is appreciated.

@slightfoot slightfoot self-requested a review February 8, 2019 11:07
Copy link
Member

@slightfoot slightfoot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Knupper I checked FirebaseApp hoping we got a default region for the project through in google-services.json but we don't. With Firestore now going multi-region it might be worth combining efforts here if there is a more direct route.

Other change that might be worth making is that FirebaseApp should be able to be passed in. This might already be in another PR. Might be worth making another PR for that however.

References to how Firestore plugin does it.
https://github.com/flutter/plugins/blob/master/packages/cloud_firestore/lib/src/firestore.dart#L132
https://github.com/flutter/plugins/blob/master/packages/cloud_firestore/android/src/main/java/io/flutter/plugins/firebase/cloudfirestore/CloudFirestorePlugin.java#L80
https://firebase.google.com/docs/reference/android/com/google/firebase/functions/FirebaseFunctions.html#getInstance%28com.google.firebase.FirebaseApp%2C+java.lang.String%29

@slightfoot slightfoot requested a review from kroikie February 11, 2019 11:46
@slightfoot
Copy link
Member

@kroikie hey Arthur, Needs a second review and I nominate you 😁 If your happy with it, then I leave it for you to merge and release 👍

@cyanglaz cyanglaz changed the title Add region support for cloud functions [cloud_functions]Add region support for cloud functions Feb 23, 2019
@Knupper
Copy link
Author

Knupper commented Feb 25, 2019

@slightfoot can be closed, we have region support now :)

@slightfoot
Copy link
Member

Looks like PR #1210 has superseded this one with support for multiple Apps and Regions. Closing.

@slightfoot slightfoot closed this Feb 25, 2019
@dshukertjr
Copy link

dshukertjr commented Sep 24, 2019

Wait, so do we have region support for cloud functions plug in now? If it is, it is super unclear as to how to call functions in different regions.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants