Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@keyonghan
Copy link
Contributor

Now only $flutter/osx_sdk property is being used, and it's safe to remove deprecated entries from ci.yaml.

Part of flutter/flutter#127534

xcode: 14e222b
$flutter/osx_sdk : >-
{
"sdk_version": "14e222b"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need the runtime versions listed anywhere?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No on the platform level. We have only one target needing runtimes. See Mac Unopt below.

@keyonghan keyonghan added the autosubmit Merge PR when tree becomes green via auto submit App label May 30, 2023
@auto-submit auto-submit bot merged commit 79bdbb8 into flutter:main May 30, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 30, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 30, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 30, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 30, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 30, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request May 30, 2023
…127890)

flutter/engine@a6d3124...1ba8091

2023-05-30 [email protected] Handle a11y focus event on Ios and android (flutter/engine#41777)
2023-05-30 [email protected] Fix unitialized SkRect (flutter/engine#42403)
2023-05-30 [email protected] Update engine testing to use api 33 for android tests.  (flutter/engine#42351)
2023-05-30 [email protected] Reland: "Adding app lifecycle notification for macOS and Linux, add `hidden` state." (#40542) (flutter/engine#42418)
2023-05-30 [email protected] [Impeller] Fixed GlyphAtlasWithLotsOfdUniqueGlyphSize (flutter/engine#42423)
2023-05-30 [email protected] Remove legacy xcode properties/dependencies (flutter/engine#42368)
2023-05-30 [email protected] Roll Skia from bab82f14da1a to fed417995ba9 (7 revisions) (flutter/engine#42424)
2023-05-30 [email protected] [Impeller] removed vulkan unit test csv (flutter/engine#42354)
2023-05-30 [email protected] Roll Skia from d22106cc40a0 to bab82f14da1a (7 revisions) (flutter/engine#42420)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@keyonghan keyonghan deleted the cleanup_legacy_xcode_entries branch August 31, 2023 20:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants