-
Notifications
You must be signed in to change notification settings - Fork 6k
[ci.yaml] Add xcode dependency #42488
[ci.yaml] Add xcode dependency #42488
Conversation
|
This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter. Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed. |
.ci.yaml
Outdated
| [ | ||
| {"dependency": "open_jdk", "version": "version:11"} | ||
| {"dependency": "open_jdk", "version": "version:11"}, | ||
| {"dependency": "xcode", "version": "14a5294e"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding a comment about if/how this is related to line 58 below and whether both need to be updated if one changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dnfield
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
dnfield
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
I eagerly merged this into #42483. |
|
Scenario test is still failing, though. |
f180133 to
e7d299b
Compare
No description provided.