Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@CaseyHillers
Copy link
Contributor

No description provided.

@CaseyHillers CaseyHillers requested review from dnfield and keyonghan June 1, 2023 18:04
@flutter-dashboard
Copy link

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

.ci.yaml Outdated
[
{"dependency": "open_jdk", "version": "version:11"}
{"dependency": "open_jdk", "version": "version:11"},
{"dependency": "xcode", "version": "14a5294e"}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding a comment about if/how this is related to line 58 below and whether both need to be updated if one changes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of adding dependencies, we should CP #42299.
We have been cleaning xcode related configs, and targeting to use only $flutter/osx_sdk property for all targets. This is the cleanup PR: #42368, which may need a CP as well.

Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zanderso
Copy link
Member

zanderso commented Jun 1, 2023

I eagerly merged this into #42483.

@zanderso
Copy link
Member

zanderso commented Jun 1, 2023

Scenario test is still failing, though.

@CaseyHillers CaseyHillers force-pushed the flutter-3.10-candidate.1 branch from f180133 to e7d299b Compare June 1, 2023 18:43
@dnfield
Copy link
Contributor

dnfield commented Jun 1, 2023

@CaseyHillers CaseyHillers added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 1, 2023
@auto-submit auto-submit bot merged commit 2a3401c into flutter:flutter-3.10-candidate.1 Jun 1, 2023
FlutterSu pushed a commit to flutter-rosita/engine that referenced this pull request Sep 14, 2023
FlutterSu pushed a commit to flutter-rosita/engine that referenced this pull request Dec 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants