This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Fixed GlyphAtlasWithLotsOfdUniqueGlyphSize #42423
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaaclarke
force-pushed
the
fix-GlyphAtlasWithLotsOfdUniqueGlyphSize
branch
from
1d9e18e to
2b2154f
Compare
gaaclarke
force-pushed
the
fix-GlyphAtlasWithLotsOfdUniqueGlyphSize
branch
from
2b2154f to
aca6c0b
Compare
gaaclarke
changed the title
gaaclarke
commented
May 30, 2023
| ASSERT_NE(atlas, nullptr); | ||
| ASSERT_NE(atlas->GetTexture(), nullptr); | ||
|
|
||
| ASSERT_EQ(atlas->GetTexture()->GetSize().width * 2, |
Member
Author
There was a problem hiding this comment.
The aspect ratio of the texture isn't really consequential. It just matters that there is an atlas that has all the glyphs (and it fits into texture the size the hardware can support).
dnfield
approved these changes
May 30, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 30, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 30, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 30, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 30, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 30, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 30, 2023
…127890) flutter/engine@a6d3124...1ba8091 2023-05-30 [email protected] Handle a11y focus event on Ios and android (flutter/engine#41777) 2023-05-30 [email protected] Fix unitialized SkRect (flutter/engine#42403) 2023-05-30 [email protected] Update engine testing to use api 33 for android tests. (flutter/engine#42351) 2023-05-30 [email protected] Reland: "Adding app lifecycle notification for macOS and Linux, add `hidden` state." (#40542) (flutter/engine#42418) 2023-05-30 [email protected] [Impeller] Fixed GlyphAtlasWithLotsOfdUniqueGlyphSize (flutter/engine#42423) 2023-05-30 [email protected] Remove legacy xcode properties/dependencies (flutter/engine#42368) 2023-05-30 [email protected] Roll Skia from bab82f14da1a to fed417995ba9 (7 revisions) (flutter/engine#42424) 2023-05-30 [email protected] [Impeller] removed vulkan unit test csv (flutter/engine#42354) 2023-05-30 [email protected] Roll Skia from d22106cc40a0 to bab82f14da1a (7 revisions) (flutter/engine#42420) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes flutter/flutter#127715
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.