Add gem test #7
Merged
Add gem test #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will rebase this. Then All tests will succeed. |
Signed-off-by: Daijiro Fukuda <[email protected]>
|
Now all tests have succeeded. Only the new gem test uses the latest Fluentd, and other tests use v1.12 for now. When the following fix of Fluentd is merged, other tests also start to use the latest Fluentd. Or perhaps we can adjust gemfile or gemspec of this repository. |
It is enough to just wait PR merged, IMHO. But it is good practice to test with latest version, so how about using latest Fluentd in gem job? |
|
Thanks for your review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following this, I added CI for Gem.
Currently, the test fails because of the following issue.