Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Support Fluentd after v1.13.3 #8

Merged
merged 1 commit into from
Mar 2, 2023
Merged

CI: Support Fluentd after v1.13.3 #8

merged 1 commit into from
Mar 2, 2023

Conversation

daipom
Copy link
Contributor

@daipom daipom commented Feb 21, 2023

I confirmed this makes the following CI successful.

@daipom daipom requested a review from kenhys March 1, 2023 06:28
kenhys
kenhys approved these changes Mar 2, 2023
View reviewed changes
Copy link
Contributor

@kenhys kenhys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kenhys kenhys merged commit 0ee60a0 into fluent-plugins-nursery:main Mar 2, 2023
@daipom daipom deleted the ci-support-fluentd-after-v1.13.3 branch March 2, 2023 06:31
@daipom
Copy link
Contributor Author

daipom commented Mar 2, 2023

Thanks for your review!

@kenhys
Copy link
Contributor

kenhys commented Mar 2, 2023

NOTE: fluentd v1.14.0 or later must be required.

@daipom
Copy link
Contributor Author

daipom commented Mar 2, 2023

NOTE: fluentd v1.14.0 or later must be required.

Oh, could this cause the tests not to work on v1.13.3 or so on?

@kenhys
Copy link
Contributor

kenhys commented Mar 2, 2023

Oh, could this cause the tests not to work on v1.13.3 or so on?

Oops, I've misinterpreted the introduced changes.
(PositionFile load interface is not changed, so no need to require newer version.)

@daipom
Copy link
Contributor Author

daipom commented Mar 2, 2023

Oh, could this cause the tests not to work on v1.13.3 or so on?

Oops, I've misinterpreted the introduced changes. (PositionFile load interface is not changed, so no need to require newer version.)

Yes! I think so too! The codes in lib/ use PositionFile.load from before.
I have confirmed the current tests succeed on Fluentd v1.13,3!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenhys kenhys kenhys approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI: Support Fluentd after v1.13.3
2 participants
@daipom @kenhys