Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Update CI #5

Merged
merged 1 commit into from
Feb 17, 2023
Merged

CI: Update CI #5

merged 1 commit into from
Feb 17, 2023

Conversation

daipom
Copy link
Contributor

@daipom daipom commented Feb 17, 2023

Update Ruby and Fluentd versions and so on.

I fixed to run the tests on the latest Fluentd, but should we add some Fluentd versions as before?
If so, I will fix it.

And, should we create a gem test instead of the following steps?
(Like https://github.com/fluent-plugins-nursery/fluent-plugin-out-http/blob/master/.github/workflows/test.yml)

        rake build
        gem install ./pkg/fluent-plugin-utmpx*.gem

If so, I will make the PR following this.

Signed-off-by: Daijiro Fukuda <[email protected]>
@kenhys
Copy link
Contributor

kenhys commented Feb 17, 2023

I fixed to run the tests on the latest Fluentd, but should we add some Fluentd versions as before?
If so, I will fix it.

When I created this gem, targeting a specific version of fluentd, but currently, it is enough to work
with packaged version in td-agent.
Thus, targeting the latest fluentd seems enough to test it, IMHO

@kenhys kenhys self-requested a review February 17, 2023 06:38
Copy link
Contributor

@kenhys kenhys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kenhys kenhys merged commit 035b284 into fluent-plugins-nursery:main Feb 17, 2023
@daipom daipom deleted the update-ci branch February 17, 2023 06:39
@kenhys
Copy link
Contributor

kenhys commented Feb 17, 2023

If so, I will make the PR following this.

Welcome PR to simplify testing task in another PR.

@daipom
Copy link
Contributor Author

daipom commented Feb 17, 2023

I see! Thanks for your review!

@ashie
Copy link
Member

ashie commented Feb 17, 2023

When I created this gem, targeting a specific version of fluentd,

This is because this plugin depends on in_tail/position_file.rb in fluentd.
There are incompatible changes between 1.11 and 1.12 in this class.

I think in_tail/position_file is considered as a private utility for in_tail, so fluent-plugin-utmpx shouldn't use it.

@daipom
Copy link
Contributor Author

daipom commented Feb 17, 2023

I see! Thanks!

@daipom
Copy link
Contributor Author

daipom commented Feb 17, 2023

Sorry, I didn't notice that Bundler was still choosing Fluentd v1.12.

https://github.com/fluent-plugins-nursery/fluent-plugin-utmpx/actions/runs/4201345210/jobs/7288262037#step:3:69

The current test doesn't work with the latest Fluentd, I will see this more.

This was referenced Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants